Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31299873rwd; Thu, 6 Jul 2023 19:43:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4R5CbeD6I0bZ9Nn6U8Cm5ermpbPvESqzQVN6ooYHlpjAUfJbE5XNg2PwCY/KEulQ0wyEI X-Received: by 2002:a05:6a00:1acb:b0:64f:aea5:7b49 with SMTP id f11-20020a056a001acb00b0064faea57b49mr3511154pfv.17.1688697814714; Thu, 06 Jul 2023 19:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688697814; cv=none; d=google.com; s=arc-20160816; b=EJR5YyrdZy+hoSCbWhiu40GvgTc8IQKCFnw4Aky+nXgGn8oko2SI7H+bX1/AEwl+GO PVGm4GU7Td1kRLXpm8ZUOYkZ3rWq3riQGgl0bAehTBMnw+hRCNTCqMapGvhlsmho9RUT 5Ffd1CaJ7JJu4GUz/mvBwfB1k+2JIRAiJDcTUR3Df/Xz3XAwrCahs7nkyxeDsBNZjU0V XB5S6pqyeCRYQ3BzHFqqh7qIxlc/XrmUllLTdIbpR1zPZjWt2owp9lskSKXY192os8sp 4zSt1yJLyozHUB3ZWQiApf1xW/r+Wie/IFpGjhUQ2P6c+nnS7F5IsdGqea3O1WPzWmmn QZ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ToGgo4FL9IvT1nm6GbZacuMx4NkLcI7NUhlTJGMzvYg=; fh=cApCqPUNb9Ho1/BdysBS3w4tFzOq23o8VT57ziHKebI=; b=q7Zgd2czDtfQundamFHjEbnlEFRbstkKX9nPxfIGELgRNH2ddAPaXUknOsNtVOIetM MFk2Pr3r1ifTrtxTFQRCdZvn5gKwMu1fTYk1a5pv1Vzi3aBWoN9t57qTWp3SwijZAj/7 WD6pirxPYxBFC+mnF1UEOpUdSkx1dNkOXWJBb2dQVPvg/7LBFv1dVABCPNdYSMCn7qUN kQQd8aiAP73uqmwQZ1T0+bn4t/Ks3qByL7r90GgtoeU9oZ+ht+7iOcznWiFdqsL8ltV2 iKgOAVHexyAeoxQwsLzDpNq5uCln/IAF60gwgM8648yiQhcnm3Vxny461Ts5KCfPTAG7 C+YQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 24-20020aa79158000000b00675807330bfsi2503203pfi.194.2023.07.06.19.43.20; Thu, 06 Jul 2023 19:43:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbjGGCQk (ORCPT + 99 others); Thu, 6 Jul 2023 22:16:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjGGCQi (ORCPT ); Thu, 6 Jul 2023 22:16:38 -0400 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB541709 for ; Thu, 6 Jul 2023 19:16:37 -0700 (PDT) Received: from ed3e173716be.home.arpa (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowABnLOl6dadk665DCQ--.49713S2; Fri, 07 Jul 2023 10:16:26 +0800 (CST) From: Jiasheng Jiang To: joel@jms.id.au, andrew@aj.id.au Cc: linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] soc: aspeed: socinfo: Add kfree for kstrdup Date: Fri, 7 Jul 2023 10:16:25 +0800 Message-Id: <20230707021625.7727-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowABnLOl6dadk665DCQ--.49713S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jry3GF13Ww17uF1ktFy7KFg_yoW3XFXE9r 4UCw15Xry5G3s7Za45ZrsYvryq9ay29r1fCa1fKF13AFWUJFZxWFy2gr97Zr1rWr4xAF98 J34UtryrJw17GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_ Gr1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUgVyxUUUUU= X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add kfree() in the later error handling in order to avoid memory leak. Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver") Signed-off-by: Jiasheng Jiang --- drivers/soc/aspeed/aspeed-socinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c index 1ca140356a08..3f759121dc00 100644 --- a/drivers/soc/aspeed/aspeed-socinfo.c +++ b/drivers/soc/aspeed/aspeed-socinfo.c @@ -137,6 +137,7 @@ static int __init aspeed_socinfo_init(void) soc_dev = soc_device_register(attrs); if (IS_ERR(soc_dev)) { + kfree(attrs->machine); kfree(attrs->soc_id); kfree(attrs->serial_number); kfree(attrs); -- 2.25.1