Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8aa1704a-f34e-1bf2-76cc-1324b0a0404a@amd.com>
Date:   Fri, 7 Jul 2023 06:55:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 5/8] fpga: xilinx-pr-decoupler: Convert to
 devm_platform_ioremap_resource()
To:     Yangtao Li <frank.li@vivo.com>, Moritz Fischer <mdf@kernel.org>,
        Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
        Tom Rix <trix@redhat.com>
Cc:     linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230705094655.44753-1-frank.li@vivo.com>
 <20230705094655.44753-5-frank.li@vivo.com>
Content-Language: en-US
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230705094655.44753-5-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnM3cld6MkFRVENhVVFidzNNd281VExvc0l0cXFBUGhrVktxdFk5S0NBTHVa?=
 =?utf-8?B?TTViV1RDKzBOQWNodEd3UFlteUxBcnpMSE85Tkw5c0RITGVhU0YrSTlYcFpS?=
 =?utf-8?B?OGlqZkJUWS91MkpmNE15NGRwdzY2TkhaQXBsV3pCUHdUVGlKM0dXdUc0dmw0?=
 =?utf-8?B?U2NpVnlzTERNaHh4Z3lVQmlqcUxaVlV4VTJORTBsZUVWMFB6QWJLSlB2cXZ2?=
 =?utf-8?B?eGxFdmEzbG5IbFB4REd6aXRXVDQwWVlVUzBPcUEreGhzU3I4VVdrZnB4SUd2?=
 =?utf-8?B?T241cFlYNVpqL3RZY1BhbGRhMm1mVFFVcVZRQ3hSREhUMk90Mm5wamtJMVUw?=
 =?utf-8?B?dXdITjU3eWFsMEhGMlVVNGVvVy9XbEt6eE1EbituQ05URmdKOUtCdHJQRVBp?=
 =?utf-8?B?bGVlditGOWpTU3NMbnlZQUMzOWVycHRkOHU0ajhZMHdkTVVVUUhjVGQxMi90?=
 =?utf-8?B?OXJVei9yZldMSllWSmUzUEdIbHVUVXUwVjJwNkNyZkk0MVk0ZGNOR3I3ZHhF?=
 =?utf-8?B?NlUvdmFhbVFmcU4zSE8rSDBkUUhtMW85NGJBdXBWU1QxRGdBZTViNXA1anBz?=
 =?utf-8?B?UWhubWhvek95VWhEUTFyR2wrKzF2UWdDVlVBc0JWQmxXeXBOWGYxYnA0NnJk?=
 =?utf-8?B?UFEvUC9xcGlMUFA1MHhadHdNNVZIeDc3UGlkQ2pCVnUzeGgvaS9KcFdZNm1t?=
 =?utf-8?B?NXZMNE1iWUxCMElvb0FOMkdqZ0JpR0ZFVys1Slcyb0hDeE11N2ZJSjZ0QmVC?=
 =?utf-8?B?TG1FVDVFNWpuTEFDVUUzZ1ZSQS9ocEpUSkQzSGdyaEpBQ2tuakF5L1BEMzcv?=
 =?utf-8?B?alBrQkNIUzU3UXBScXRLVEgzNEVWc2paVU1uQmtQSHkxWmRhZW9WSFBDbEdx?=
 =?utf-8?B?UWw3Z2JhanF1S1VWVVBRSlZxUTdxYmNQcDBtN3hIcWtVU0xGT2VyZlRoM3J5?=
 =?utf-8?B?WVJKZXFodnJmZW5HN3EraXB1TWUxZm1ObEc1STJxbEFrd2ZIWHNpeTVEaHlh?=
 =?utf-8?B?RGY0NWJlRWN4UU5QNnBOWjhVdFZpc1Jab215Y0RvTmNUVEE5MXNHTk9pSjFZ?=
 =?utf-8?B?eUpUTlF4Y3V6M051eElmUFVtM0NIcmZEWlhvNjJaQlZLRUNTZE9jV0I2UFlK?=
 =?utf-8?B?T3lxN2ZsQXhGdTFvZXF4ZWxlU0dTbHJPa20rR21DQUNkcjFDSWpZMnJ1bjJK?=
 =?utf-8?B?S2hJSTN1dDJHYS93RDNYUmpOV0FxWmNycnhYYXoxd1loVVRKOTZKZ3hUZ0Vo?=
 =?utf-8?B?eHpzVjQvSktOZjBNUlFKVnBZTXJaME1VcGVVWk0zNXZzTG1LcVM1L3E1eXZO?=
 =?utf-8?B?R05aZWtQaHFwcGROT21KajQ0OXBGNE4ySXdlMWpibXFRYVRUcFR2OGhtdWM2?=
 =?utf-8?B?VmEvNnd1V3BkMVpLSi9vWnlBNHN5ZmNsZkoyZm1iSk55MTlUeVU5K0N3c3F2?=
 =?utf-8?B?dVdoaU9kenJyTWc0Tk5STXFBTWVuNE9lUXpWSVRzU2EzMUhzZU0vWVlRWWNy?=
 =?utf-8?B?azR3Zk9ya2NvbjZjRkZFNVBUTHN5T3BCcjhxNEFTV3F3UjJ6OWN0U2g2UEk0?=
 =?utf-8?B?VU41Yk5JeUx2OWwwVis5dnRRSFdCSDZKcXRrMk05d3JHZDBsNXl3OWlXK3VX?=
 =?utf-8?B?YzZMcFp3djlKWjFRdm5mV0VrZGxrM3RpTWs1Q0J3Ujc0UEsyYk90UExHKzJJ?=
 =?utf-8?B?eUNKMjJmUGhoczFPeFR4ZXB4MFZDWmxwVG9TaFZDdkxJV0dLRUxjWmZYVG51?=
 =?utf-8?B?eXdYNmU3OWhubjhYUllkb1FWN25aV2pmYzhRdjlHK2EzVjdSbWdGdW9KdzVB?=
 =?utf-8?B?YnJjVDUvekJ5THJ4Q3RvUHZPR1RlR0ZuZk1GZUk5aTg0cHpRVTk5OFRYOFJh?=
 =?utf-8?B?dUtabXova2didHZXaUJkWDhmK2F1NkNFNzNXNDl6Q2dCd0hXdElMNVMwdFdC?=
 =?utf-8?B?N0Nsem8zSkhOU0xmL2oxSWU0SC85R1hPVnhSRm0wRi83SVdKTWc3aVMrZmVQ?=
 =?utf-8?B?dEU1eFRvcmEvN05jZDM2cjJyOVVHOW9RcFpqWmtQTDhkWGVPZHBhd0FnSjBu?=
 =?utf-8?B?a3NJSzR3alRxUmVOQkxwbm1vZXcwMEZyVlpkbFE0S3JXSVpORXBPdTJ4RkJs?=
 =?utf-8?Q?QCNUAnypgaDV6l1gkk5RndoC5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 031dcadf-b146-4a64-a774-08db7ea66970
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 04:55:40.4931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7GCKwiBNpHKkTPY4znrRM6NyiTL0IsDYzltqDPb0xgRt1RiUXnASYcjYyMLP190z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4975
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/5/23 11:46, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   drivers/fpga/xilinx-pr-decoupler.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index b76d85449b8f..208d9560f56d 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>   	struct xlnx_pr_decoupler_data *priv;
>   	struct fpga_bridge *br;
>   	int err;
> -	struct resource *res;
>   
>   	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
>   	if (!priv)
> @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>   			priv->ipconfig = match->data;
>   	}
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->io_base = devm_ioremap_resource(&pdev->dev, res);
> +	priv->io_base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(priv->io_base))
>   		return PTR_ERR(priv->io_base);
>   

Acked-by: Michal Simek <michal.simek@amd.com>

M