Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e2407b7-fcdd-f047-66be-87ab371301f0@sberdevices.ru>
Date:   Fri, 7 Jul 2023 07:45:40 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [RFC PATCH v5 14/17] docs: net: description of MSG_ZEROCOPY for
 AF_VSOCK
Content-Language: en-US
To:     Stefano Garzarella <sgarzare@redhat.com>
CC:     Stefan Hajnoczi <stefanha@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Bobby Eshleman <bobby.eshleman@bytedance.com>,
        <kvm@vger.kernel.org>, <virtualization@lists.linux-foundation.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@sberdevices.ru>, <oxffffaa@gmail.com>
References: <20230701063947.3422088-1-AVKrasnov@sberdevices.ru>
 <20230701063947.3422088-15-AVKrasnov@sberdevices.ru>
 <CAGxU2F410NSNSzdNS4m-9UM8rZFBFpe5LeNZtkF0VzJc5_JFmg@mail.gmail.com>
From:   Arseniy Krasnov <avkrasnov@sberdevices.ru>
In-Reply-To: <CAGxU2F410NSNSzdNS4m-9UM8rZFBFpe5LeNZtkF0VzJc5_JFmg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06.07.2023 20:06, Stefano Garzarella wrote:
> On Sat, Jul 01, 2023 at 09:39:44AM +0300, Arseniy Krasnov wrote:
>> This adds description of MSG_ZEROCOPY flag support for AF_VSOCK type of
>> socket.
>>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>> ---
>> Documentation/networking/msg_zerocopy.rst | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
>> index b3ea96af9b49..34bc7ff411ce 100644
>> --- a/Documentation/networking/msg_zerocopy.rst
>> +++ b/Documentation/networking/msg_zerocopy.rst
>> @@ -7,7 +7,8 @@ Intro
>> =====
>>
>> The MSG_ZEROCOPY flag enables copy avoidance for socket send calls.
>> -The feature is currently implemented for TCP and UDP sockets.
>> +The feature is currently implemented for TCP, UDP and VSOCK (with
>> +virtio transport) sockets.
>>
>>
>> Opportunity and Caveats
>> @@ -174,7 +175,7 @@ read_notification() call in the previous snippet. A notification
>> is encoded in the standard error format, sock_extended_err.
>>
>> The level and type fields in the control data are protocol family
>> -specific, IP_RECVERR or IPV6_RECVERR.
>> +specific, IP_RECVERR or IPV6_RECVERR (for TCP or UDP socket).
>>
>> Error origin is the new type SO_EE_ORIGIN_ZEROCOPY. ee_errno is zero,
>> as explained before, to avoid blocking read and write system calls on
>> @@ -201,6 +202,7 @@ undefined, bar for ee_code, as discussed below.
>>
>>       printf("completed: %u..%u\n", serr->ee_info, serr->ee_data);
>>
>> +For VSOCK socket, cmsg_level will be SOL_VSOCK and cmsg_type will be 0.
> 
> Maybe better to move up, just under the previous change.
> 
> By the way, should we define a valid type value for vsock
> (e.g. VSOCK_RECVERR)?

Yes I think, I'll add it in the same patch which adds SOL_VSOCK.

Thanks, Arseniy

> 
>>
>> Deferred copies
>> ~~~~~~~~~~~~~~~
>> @@ -235,12 +237,15 @@ Implementation
>> Loopback
>> --------
>>
>> +For TCP and UDP:
>> Data sent to local sockets can be queued indefinitely if the receive
>> process does not read its socket. Unbound notification latency is not
>> acceptable. For this reason all packets generated with MSG_ZEROCOPY
>> that are looped to a local socket will incur a deferred copy. This
>> includes looping onto packet sockets (e.g., tcpdump) and tun devices.
>>
>> +For VSOCK:
>> +Data path sent to local sockets is the same as for non-local sockets.
>>
>> Testing
>> =======
>> @@ -254,3 +259,6 @@ instance when run with msg_zerocopy.sh between a veth pair across
>> namespaces, the test will not show any improvement. For testing, the
>> loopback restriction can be temporarily relaxed by making
>> skb_orphan_frags_rx identical to skb_orphan_frags.
>> +
>> +For VSOCK type of socket example can be found in  tools/testing/vsock/
>> +vsock_test_zerocopy.c.
> 
> For VSOCK socket, example can be found in
> tools/testing/vsock/vsock_test_zerocopy.c
> 
> (we should leave the entire path on the same line)
> 
>> --
>> 2.25.1
>>
>