Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f128bc05-e1c4-12b0-0456-1483683b823d@amd.com>
Date:   Fri, 7 Jul 2023 06:57:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] dmaengine: xilinx: xdma: Fix Judgment of the return
 value
Content-Language: en-US
To:     Minjie Du <duminjie@vivo.com>, Lizhi Hou <lizhi.hou@amd.com>,
        Brian Xu <brian.xu@amd.com>,
        Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
        Vinod Koul <vkoul@kernel.org>,
        "open list:XILINX XDMA DRIVER" <dmaengine@vger.kernel.org>,
        "moderated list:ARM/ZYNQ ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     opensource.kernel@vivo.com
References: <20230705113912.16247-1-duminjie@vivo.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230705113912.16247-1-duminjie@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHl2UmFqVm1xK0UrSGlLNEFrdWExRCtpYzloR1FVZjcvcVJCa2gxalIzL2Y0?=
 =?utf-8?B?QzFtV1Rvb0czN1hxMFliN28rTitCYnhZSlprMGI5djQrWUM3Z2dFcHgwb2RZ?=
 =?utf-8?B?NVhiWEVJTWxEOXJqR3BmOTdGdTZPUXJROWhidUgycWUzQ1VzZGJwVGR3TFZw?=
 =?utf-8?B?YnpIYlFsYTNCNnRCSmNsek1mcWZRRWVmZmpMSyt2dWsvV3hCTmFnVEJ2WkNK?=
 =?utf-8?B?WXdIVFV4dFdyM2Y4eXU0SlhrckxrQjJEeVd3SEMrbWNoN1J2dkVhcERJaEd3?=
 =?utf-8?B?QzdlQlE3SmJzMWs1V0JOd3lOb2NEd2RGeWpsTGhzaGJlWjRxSEJVa1puMlVl?=
 =?utf-8?B?NkNySHZLRmVUd1dDUU84OXYrM3FCTFRWODZQV3Q1TnpWQzVnV1RhYVB5RWU2?=
 =?utf-8?B?T2tPWGU0UkZjMFVPYWRFUHd4enNRZXI3c3ZwK0FSdVU5UjRsYWJKUkVvaG5G?=
 =?utf-8?B?bFB0OG1oa0lYcGNLSG1TYzJ3Tk1hRFhHWHlPc3ZmVk82eEF4NGFDdyt4MWgx?=
 =?utf-8?B?emd5MVNReU1ZZHZCck1vT1FHTmt0TE9HZnBuWEswQkQrRTByVGdvMlpzVVUr?=
 =?utf-8?B?eCs0VUlWZlBEWTErc0MrckRuVnI4alh0WkpxUVBSUlZLRktndktXMmVhTnlI?=
 =?utf-8?B?V2oxQUdYVFFEeDBJaHhoMkhGajlFTHBycmJ0c04wU0p5d0NNWkRZNXA0TGtZ?=
 =?utf-8?B?eU5TdkRkVkJqUU54azE1bnpZWVBNd3RpZU9LdDVReFFYb2V1T1podGZDNEVT?=
 =?utf-8?B?NE9ja0ZxaDdRZUNyMXZFdzUvcXlYZXZsMElLbmZCL1Y3TDZ5end4MWhIOUgv?=
 =?utf-8?B?VCtYZGFCRGFENnFWU0t2NER1ZEQ1UUxEV0JWeGhVaENTbC9zNElWME5Yajdv?=
 =?utf-8?B?SzdDQnZYTWhBSjBCdHc0c0NSZ1VMbS91bEswRU5kUWhaSGhleCtkS1dXRjJR?=
 =?utf-8?B?dkoyeVdwVmVzdXBYN1RQc2tFMzNGd1doYm55c2JOQTBlTHFvQUF1cTNFcUkw?=
 =?utf-8?B?dTMvK2xnTWc0ZXBOV3hsZERhbXN4WHA3OFJHcGhLUVAxdVQwVy9CREhuM2Nw?=
 =?utf-8?B?ZWhvM0lvOCtwUWZneGRxSjc2akE0a3BPMnNYbXZjMzhycUVucDhEWldGM0Q1?=
 =?utf-8?B?ZEJGRkxhNGFoT2xxMU14OHpuM2htMXFwNm5xdWV5cThNaUI2T1RLNTNldmhx?=
 =?utf-8?B?ZU9ZcTgwMHdkNUVJSGZYZzlydnBEN1ZENExTYVFrM0ZYem91ODcvODlML211?=
 =?utf-8?B?STB1NGtzRyt0STQwSG1BZk1MVVlyMFc1RGxGVGF4STFLT1IwNnJueThpT1Ur?=
 =?utf-8?B?c2NBWFhqdmNiSXpVRkpmTGM1VUwzcGpuUUsvY3p2M0EwR0hWY05lTWRqUXpz?=
 =?utf-8?B?NlFiWGlaOFE3L2xnRDMvekl3WnN2TWp6bmhXZldsNjJ4TU8zL2xudjVNdnNa?=
 =?utf-8?B?cXRiS3pwR2orQnBrSlliS05qUG1MM0czamtzTmMvaXFOdm85M1Z5RVd5M1gy?=
 =?utf-8?B?cUE0azBJQkJBenpUaHcyLzVGQTNha0NpSHkzWFQ0dXdnZWJadDNQNURQNFlI?=
 =?utf-8?B?NzNOWCswczhPNkFIZzk1ZjBhUm95dFR3djU4UGlGZXdCR2F4MThOTlJjQ2cv?=
 =?utf-8?B?OVkxRlhZYkw5MjN0dU1UT0t4RllQOWpwaTlCYU8wRTVNWHZnemZaUjh0NXdW?=
 =?utf-8?B?Q2QvLzY4VFBiMUFkaENaNkdqalBSRTAyK0VIS1dBeW41amk0RDFWUjQ4QWYy?=
 =?utf-8?B?OHl6dkdkcE5KcTErK1dJU3BPVy9wVTJqa0VNTmJFMUxybXhhMlU4anJOSnc2?=
 =?utf-8?B?YzlDSmcxd1NaOWFSVjM1WFNOeDUvalhuamZCb09BUjNKRTMyWFJaTTJhbS95?=
 =?utf-8?B?T2JDTWVJK2xHYkJNQXgrQVRoU0ZoQWoyM3NReGhvWnZIak9UT1RRblBtTW5q?=
 =?utf-8?B?WFUwUm5tcnY5ck1iNWNmdEcxMFJZd2dqK25TdElBck5OK1NoVVgyVTQ5VEMv?=
 =?utf-8?B?ZUp6c0ZjNTQ5QXlicmd5cUlXY01YOGY2bjlRNlJTOTVWUHZIZVYwaVJ2OG1D?=
 =?utf-8?B?dkhydWQzNFZOaHlIckdxSGkrVTUrZTY3TDA2OEJXV3ZkT0RKbDVpNEU5SnNS?=
 =?utf-8?Q?y8bt/6zb6QSzyYUPHix45+Cyf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6965040f-a025-4a72-0fcc-08db7ea6b4ad
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 04:57:46.6620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eT8a9ttFKOYrP3AP/qQtrQt3wUbOekPBuuJahXFC9tY2Q3lUw73WK/zqHEQLZsFL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5020
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/5/23 13:39, Minjie Du wrote:
> Fix: make IS_ERR() judge the devm_ioremap_resource() function return.
> 
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   drivers/dma/xilinx/xdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
>   	}
>   
>   	reg_base = devm_ioremap_resource(&pdev->dev, res);
> -	if (!reg_base) {
> +	if (IS_ERR(reg_base)) {
>   		xdma_err(xdev, "ioremap failed");
>   		goto failed;
>   	}

Acked-by: Michal Simek <michal.simek@amd.com>

M