Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] tools: testing: Corrected a clerical error
To:     Lu Hongfei <luhongfei@vivo.com>
Cc:     opensource.kernel@vivo.com, Andrii Nakryiko <andrii@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        Anton Protopopov <aspsk@isovalent.com>, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230706095339.4048-1-luhongfei@vivo.com>
From:   Hou Tao <houtao@huaweicloud.com>
Message-ID: <dd226e17-2f3a-4cca-429d-9dd2d711425c@huaweicloud.com>
Date:   Fri, 7 Jul 2023 15:05:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20230706095339.4048-1-luhongfei@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi,

On 7/6/2023 5:53 PM, Lu Hongfei wrote:
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> ---
>  tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> index 3ca14ad36607..e1ee979e6acc 100644
> --- a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> +++ b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> @@ -399,7 +399,7 @@ static void perfbuf_libbpf_setup(void)
>  	ctx->skel = perfbuf_setup_skeleton();
>  
>  	memset(&attr, 0, sizeof(attr));
> -	attr.config = PERF_COUNT_SW_BPF_OUTPUT,
> +	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
>  	attr.type = PERF_TYPE_SOFTWARE;
>  	attr.sample_type = PERF_SAMPLE_RAW;
>  	/* notify only every Nth sample */

Acked-by: Hou Tao <houtao1@huawei.com>

Please update the subject of the patch in v2. The subject should be
something like: "[PATCH bpf-next] selftests/bpf: xxxxxx"

Just be curious. How do you find out the typo ? Is there any similar
typos in bpf selftests and could you please fix these typos as well ?