Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Jul 2023 15:53:54 +0800
From:   Chen-Yu Tsai <wenst@chromium.org>
To:     =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado 
        <nfraprado@collabora.com>
Cc:     Daniel Lezcano <daniel.lezcano@linaro.org>, kernel@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Bernhard =?iso-8859-1?Q?Rosenkr=E4nzer?= <bero@baylibre.com>,
        Amit Kucheria <amitk@kernel.org>,
        Balsam CHIHI <bchihi@baylibre.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Make readings
 valid in filtered mode
Message-ID: <20230707075354.GA1333497@google.com>
References: <20230706161509.204546-1-nfraprado@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230706161509.204546-1-nfraprado@collabora.com>
Precedence: bulk

On Thu, Jul 06, 2023 at 12:14:33PM -0400, N?colas F. R. A. Prado wrote:
> Currently, when a controller is configured to use filtered mode, thermal
> readings are valid only about 30% of the time.
> 
> Upon testing, it was noticed that lowering any of the interval settings
> resulted in an improved rate of valid data. The same was observed when
> decreasing the number of samples for each sensor (which also results in
> quicker measurements).
> 
> Retrying the read with a timeout longer than the time it takes to
> resample (about 344us with these settings and 4 sensors) also improves
> the rate.
> 
> Lower all timing settings to the minimum, configure the filtering to
> single sample, and poll the measurement register for at least one period
> to improve the data validity on filtered mode.  With these changes in
> place, out of 100000 reads, a single one failed, ie 99.999% of the data
> was valid.
> 
> Signed-off-by: N?colas F. R. A. Prado <nfraprado@collabora.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>

on Hayato. Reading out the temperature is now quite reliable.

> 
> ---
> 
>  drivers/thermal/mediatek/lvts_thermal.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 1e11defe4f35..b5fb1d8bc3d8 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -58,11 +58,11 @@
>  #define LVTS_PROTTC(__base)		(__base + 0x00CC)
>  #define LVTS_CLKEN(__base)		(__base + 0x00E4)
>  
> -#define LVTS_PERIOD_UNIT			((118 * 1000) / (256 * 38))
> -#define LVTS_GROUP_INTERVAL			1
> -#define LVTS_FILTER_INTERVAL		1
> -#define LVTS_SENSOR_INTERVAL		1
> -#define LVTS_HW_FILTER				0x2
> +#define LVTS_PERIOD_UNIT			0
> +#define LVTS_GROUP_INTERVAL			0
> +#define LVTS_FILTER_INTERVAL		0
> +#define LVTS_SENSOR_INTERVAL		0
> +#define LVTS_HW_FILTER				0x0

This hunk conflicts with

    thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts

from your other series

>  #define LVTS_TSSEL_CONF				0x13121110
>  #define LVTS_CALSCALE_CONF			0x300
>  #define LVTS_MONINT_CONF			0x9FBF7BDE

on this line.

> @@ -257,6 +257,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
>  	struct lvts_sensor *lvts_sensor = thermal_zone_device_priv(tz);
>  	void __iomem *msr = lvts_sensor->msr;
>  	u32 value;
> +	int rc;
>  
>  	/*
>  	 * Measurement registers:
> @@ -269,7 +270,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
>  	 * 16	: Valid temperature
>  	 * 15-0	: Raw temperature
>  	 */
> -	value = readl(msr);
> +	rc = readl_poll_timeout(msr, value, value & BIT(16), 240, 400);
>  
>  	/*
>  	 * As the thermal zone temperature will read before the
> @@ -282,7 +283,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
>  	 * functionning temperature and directly jump to a system
>  	 * shutdown.
>  	 */
> -	if (!(value & BIT(16)))
> +	if (rc)
>  		return -EAGAIN;
>  
>  	*temp = lvts_raw_to_temp(value & 0xFFFF);
> -- 
> 2.41.0
>