Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <dlemoal@kernel.org>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 09/11] ata: pata_ixp4xx: Remove unnecessary return value check
Date:   Fri,  7 Jul 2023 17:55:11 +0800
Message-Id: <20230707095513.64224-9-frank.li@vivo.com>
In-Reply-To: <20230707095513.64224-1-frank.li@vivo.com>
References: <20230707095513.64224-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nOlgNHpx6RXlzbRFogWoqtnvCRcbh7ahArk222xH4Dq5ZFwK4ezGXct1951h?=
 =?us-ascii?Q?86DzikLbAsLYTYOGuRenyQNWxbn9EuK5BwAqQ5BBkxqdSIND3IA64DWlNXq6?=
 =?us-ascii?Q?jIfgFxdd3CJ43n5CKSeQUjlSiDFuz+tIvMuuxo9jBuhkMC3ozJ1f3chPbQS7?=
 =?us-ascii?Q?rPgqlY3+v5JwdaaDtMmfKfkbD3DK18gkfdR11Gbn8f+6rD9td9X/yM/WNqun?=
 =?us-ascii?Q?3k4mNl6xPGefZEbS2uDhj6aXEbS7Wf3KM+Gi+B+7G4gcV0QZPtQdKSfLKGuY?=
 =?us-ascii?Q?p3H9KTSSWtLiNdnJY+/fzw3IIj0FdqDnmeWMmSDxEqFCukSQODQOvTGVqcVZ?=
 =?us-ascii?Q?AV3GaE7c/6ueWzv+elXxUbgaVIxShcnZGmPoR4eBrumCW0fPBRMVUD1RB3lx?=
 =?us-ascii?Q?nGUN3l90j7x+/WludYdkoxjEXT/Z01gWy2CsPS6jkskF2gBvm411pYnVsiNp?=
 =?us-ascii?Q?G2jkr8tmiScb6w3prxg57q/SCfgedwdbN3hLvg/Fmu1yfMBDk71+wWyZfIz9?=
 =?us-ascii?Q?BttXHml8Lo98LfelE4IWumXF4RmQG2c/2ShAMsrb7y/ImWl/6BrLj2/r5XAj?=
 =?us-ascii?Q?d3k1uHCEvxjlc6hs/u2jUGFRtr/jZO2EtnD/uhywKDxA0UpIj34fALX/AXZ2?=
 =?us-ascii?Q?MfczKJvVFPw/Bm7KcaxcYqgOoLxkUpNUYoxDMozm4IlugnZy3nGOLu6+poXR?=
 =?us-ascii?Q?nWvthoPpUQvZi6VCDPvQn74UYir9KRQT6kBGaCoT40U0LSP7oKLdWA/8bznj?=
 =?us-ascii?Q?LkmLpEd9su9Qpwdn1ncYoAsx9nFU4Rw1En2HLq3nDS1A48mykznqMGQjtfXJ?=
 =?us-ascii?Q?VoiDicNuJ34PUfC/aexkWyBAy+i26WuYgdyi4f62xMBUeSEyFFQ8C228y6WC?=
 =?us-ascii?Q?e6D9j3LQf8eLbseEagjVTWI9NQDMJ7lGenGl9E+uoEJhDC3r+f7ifSY7L47I?=
 =?us-ascii?Q?r2+sM1uYkcwgmIWnQSyn3VaZOebs7X5L9+IK3e+JU0NR1C+MySmN3UdBK9EJ?=
 =?us-ascii?Q?cg0zgCv9dnXlYZGXKqX2qA2EVAaTZKc1DprP60fd8agA2vDAam3NeC4bDcpF?=
 =?us-ascii?Q?n5j+H7OTpjSwP4uOD9SNimi+wE1DLLitq8xnZb+YOmsK2+USMfjGmfxzcQXZ?=
 =?us-ascii?Q?s36Abn9vmhWQRNJza0UexxhWI1PjhdJhLFERhPR9WnxvUfDjWrNDAxsOqFKg?=
 =?us-ascii?Q?rwavWY33opXLjPbGqTjAA9S8Q2JlIJcOaUtjrsoJITTol4XZc8Va8hIppk0d?=
 =?us-ascii?Q?6eX2yt5HdSAHU+lIcVyDlVxUo/Ii9VchmB+S7zpHuTzee8Zv+koBHP9f6sXK?=
 =?us-ascii?Q?h4b98saBFFt14+3iaNTHSS/trE2r8XbJ5BpVpLjwb6z/pV0frV9dBfvj97y0?=
 =?us-ascii?Q?uL+ILgdE1uMXXGZMy8B4uOq/8fVcxQscO0ZG8c2/KqUcOtb6m0KhxbPHjxsR?=
 =?us-ascii?Q?p3zTyL6yRExfqVp3QNfHfEFUNOEY1rMzDoCoyvCKjjucDXvDNUg7LHORdRjC?=
 =?us-ascii?Q?HvxfZIA579l912RwJdES/99iFrCkAJoryQigxU+KHcThr4kapWYvACZP+eDI?=
 =?us-ascii?Q?qOBAaaVmNMdxX65NPxYqTFJ6F1/Gg5E/gWuU6TXv?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dda7866d-2020-4390-a93d-08db7ed052b4
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 09:55:41.1002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XynZJJd27PMOaMRy75RDfuEg/JHDL7D4jJm2N4QoIDNVOCzMbIrPGDVm3pNF5VzztOxZ10m5sQMEv6Y9esVQ1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4356
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0
is invalid") says, there is no need to check if the platform_get_irq
return value is 0. Let's remove it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/ata/pata_ixp4xx_cf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 1b9f67e16864..246bb4f8f1f7 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -274,12 +274,9 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
 		return PTR_ERR(ixpp->ctl);
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq > 0)
-		irq_set_irq_type(irq, IRQ_TYPE_EDGE_RISING);
-	else if (irq < 0)
+	if (irq < 0)
 		return irq;
-	else
-		return -EINVAL;
+	irq_set_irq_type(irq, IRQ_TYPE_EDGE_RISING);
 
 	/* Just one port to set up */
 	ixp4xx_setup_port(ixpp->host->ports[0], ixpp, cmd->start, ctl->start);
-- 
2.39.0