Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31906113rwd; Fri, 7 Jul 2023 06:12:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlFPKdOOqqDKbyJwJN10e3Yx3s5oMTnwcUmBD0TOcsgOVfeIp5xuvyo4t54LD/AZvjBzO+ZC X-Received: by 2002:a17:90b:1812:b0:262:f550:6413 with SMTP id lw18-20020a17090b181200b00262f5506413mr12470522pjb.6.1688735528480; Fri, 07 Jul 2023 06:12:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688735528; cv=none; d=google.com; s=arc-20160816; b=zF060wgyzz2kLrU3PgeihMowZLWK9ip3cxF9tY8B0D6kKhpACYViLhX0etv64Z4F+E SenbFUGFJgv+aSqw8bcDMeyxUBfCqFvhZuvkOdu0mjSAA+knKdL0Tgl+uem03N9T3Tvg 3nTwPEOyT4dk/tFkfON9ZNoyFfC5NQCS4UJ+5PpXM4SrFILwBpQsaK1D9uNAD+jgP9+z +cEgLMQTNlG42pkyMda2S2aX3xiV08sIdhqqMRd35s7ZuMVN2hcW/LMyoaHcr2o+RLYS zwrkZlzJf8GDnKGwDEbULjqGTz3tbBswk16BYbmolTDQasqLEaRatL5TN4KLvA40Ixfs 4qow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mbKtKR0hDOfsYUOd60G4dTNAhNP0rnZEhKEo7PpA4V8=; fh=rbhqnBC6cCRXnGu5F2u1vm6SB1gRdJeXa1eTC81cG6o=; b=iswd/M42gNLwzalSfgo3haYJ08IMftHEORA7aAJySd/ZtXZTDXYX7Yen3gxjyzzHeM 5WIPqrFPZjT4JqnXJfg8tYbpzTiRU1Y+PmLNMYzRMlK69TwM29yeoVYOJyiGBRVAjHDt I9ac+3LsKaBBJsjbeDfvk6avN+kVGhZYhP/s5a8oeYQACy1dcvzKtx8UPFNquGVWg/iG /mlLqTdyD10rkzKJ1M+fR2XDSPQwIvwjoIAOjsHlUoZ3DWtqueIGj6hPFLvRNbc0wJUa mudeP82Afqrin01Ck8LEPJBigRmWDhRevL8QOwtWIt6XdK0V238ancdAYS7vX2MnOeCu A8Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aNit0vig; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id me3-20020a17090b17c300b00262e5a82047si2270765pjb.44.2023.07.07.06.11.43; Fri, 07 Jul 2023 06:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aNit0vig; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbjGGMh3 (ORCPT + 99 others); Fri, 7 Jul 2023 08:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjGGMh2 (ORCPT ); Fri, 7 Jul 2023 08:37:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A597219B2 for ; Fri, 7 Jul 2023 05:37:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3470560DC0 for ; Fri, 7 Jul 2023 12:37:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A995C433C9; Fri, 7 Jul 2023 12:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688733446; bh=mbKtKR0hDOfsYUOd60G4dTNAhNP0rnZEhKEo7PpA4V8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aNit0vigHHp6kJop50zKvZLhCninNHuUv51E8A2M/HAcu4U6AxigDvOK3VHzYcc27 iulTRe9aU+L3G0VRNAGyHmrZEVmZNuqRHSGS6TJL+5P7acNhqJeKRFHousBnwkqJbD kE5yQ3wUtizjtjgSs/usjN0zuOqkf7UeJZ1djz8GOEmmVTFUO4RNmb9PVe2KYA453S OmEnnmGub1KgD+cOFKaV8QpALMKkYCq1HYfLxkGeGqz80F9rKs776WgOcXBJcHhgtv t+kenDKJFKxbNk5FdJFcWv/NExLVkXDdAjzp1/iS/TzMJop8msfCvX2qVB1owFzLeO H738e/iPLQzig== Date: Fri, 7 Jul 2023 13:37:21 +0100 From: Mark Brown To: Johan Hovold Cc: Srinivas Kandagatla , perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: codecs: wcd938x: fix dB range for HPHL and HPHR Message-ID: References: <20230705125723.40464-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Oq9TbAv/U+d9U0n3" Content-Disposition: inline In-Reply-To: X-Cookie: Victory or defeat! X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Oq9TbAv/U+d9U0n3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 07, 2023 at 09:35:44AM +0200, Johan Hovold wrote: > On Wed, Jul 05, 2023 at 01:57:23PM +0100, Srinivas Kandagatla wrote: > > +static const DECLARE_TLV_DB_SCALE(line_gain, -3000, 150, -3000); > This looks wrong, and indeed that forth argument appears to be a mute > flag. I guess that one should have been 0 (false) here? Yes, it is - it's for flagging if the lowest value is mute (many devices integrate mute into a volume control). > Headphone output also appears to be way too loud by default with this > patch (alone) applied. Perhaps it's just the default mixer settings need > to be updated to match? Some of the discussion on IRC suggested that this might be the case. --Oq9TbAv/U+d9U0n3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSoBwAACgkQJNaLcl1U h9AnzQf+JyxvsKCayD52fTwBgQXf7YiLtnekXQaVpcyZ7dKwsUT7h0Pnp01wyq8N PQdur2WE72RmuSn0Qi0GUxH633LL66Yxm9eMAnwoIvrM7iX0sK7EfuGz8tVSKCEE 1VRUYEDJE00q/CAvBIKZ79/D/cYNqjGYoOw0272ChF96RX/bdtUusc8p1KCuVmXT VT+Pkdxr1iiApyNCtEvWLspdPGTWIZvQqCYvyz9HDWvtE8dNaiWvSzAlQUawDZoM gT3lHCvA3Xhrr3rG39ZouHdnoSlHrXbuJJAJABeDVHYFRAqVpj1/Ld6rtbQzCQvB pC1fLqmsZlCcGwLTUHtWhNMetyUNOQ== =Qwsi -----END PGP SIGNATURE----- --Oq9TbAv/U+d9U0n3--