Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To:     Yangtao Li <frank.li@vivo.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 17/18] drm/arcpgu: Convert to
 devm_platform_ioremap_resource()
Thread-Topic: [PATCH 17/18] drm/arcpgu: Convert to
 devm_platform_ioremap_resource()
Thread-Index: AQHZsKOzyL8hyObJekyqbo39+sWVwq+uSwb9
Date:   Fri, 7 Jul 2023 13:24:58 +0000
Message-ID: <DS7PR12MB90414173AA812CA294A4B1A7A12DA@DS7PR12MB9041.namprd12.prod.outlook.com>
References: <20230707072034.48977-1-frank.li@vivo.com>
 <20230707072034.48977-17-frank.li@vivo.com>
In-Reply-To: <20230707072034.48977-17-frank.li@vivo.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DS7PR12MB9041:EE_|SJ0PR12MB6904:EE_
x-ms-office365-filtering-correlation-id: 25f6f417-a874-4ac7-69a6-08db7eed8fa1
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Os8QJWt4mYjZIH67nLtYwzOSJVRrGwWlgRcmV83N6tEBe1wJYT6MEW7t3sudhsTWE6ZklloerNKWL/TQn2aFauhB6IxL7MPsCTGSk2xJ2ci6YizcNtHcNGPaZq25iNU1Ih06jit5YKYRw6THEYu8xRm3oiVSyw8+t316CdnwsuXNmtgHH6acacATKcS9Ab2XXcy+PjMD2Z/Kht+i6ww8fjH/2JhnZfF3Br+VJL62YdrI1exGSrqVDlDwQu0xYXEguhV5kImkmzLJLG7wzQzWmdC5J3GtNAbg3U0AWlCH2FUt6TtIEWaqVtnZN4yGy/JWo8MMl+mnPLP2OJIbkqZAqWDlQzGLgkCdesTmqsrK9wYLMWoKVoimLaGEL+jEkQp5UPU69uTsojnpwPXgKs1KRVan8IGbJsSqg23OL4Whcb2eW4/Hhl2O7n5WQzUpXXSZ+MfKefc+KlxZ2Y+J8mIhfsWjrokqzA4slIE33oXPaY53ECC3+p1EWLmNKrlYMvUSfZkaseP2D600QW00PxWkyRuPs1/PTPRQ964Lm8jItfuiNv0ji47LKHLKWxQksX+muqmx9Ac6219BLIwo+SKgdTX8oa9G+YM/F3Wk5E2VVek=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9041.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199021)(66476007)(66446008)(91956017)(52536014)(64756008)(66556008)(4326008)(6916009)(5660300002)(66946007)(41300700001)(38100700002)(76116006)(316002)(8936002)(8676002)(86362001)(33656002)(55016003)(2906002)(38070700005)(186003)(7696005)(83380400001)(71200400001)(26005)(6506007)(9686003)(122000001)(54906003)(478600001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?piAfKsC0UAoQN7EEg1F7hB20gzKJbPiEDCCvnW+XlaFF2K+N0lXHLfBsjq?=
 =?iso-8859-1?Q?ZzPLJcHfn4Ee2CK3rRrAyate2ffASljK/3FlOVsZIUOZ+e3lnwidYNvzzt?=
 =?iso-8859-1?Q?TUmjnpfJO3tudA6eOg8WXOuSi7xvPttEsqybCp/tMwP2o6jDoKKi9u+qUb?=
 =?iso-8859-1?Q?rRLRxCmyUIXJKbIqfcj8n6EoGlRZdI0CM868Hsaji8BsTn81mJaSBhhEL1?=
 =?iso-8859-1?Q?mOtc3dFJT7B3uezPVvVa3Iv99eWcX1G0z1zvtmlES/zrYPXF9BjL04/bW/?=
 =?iso-8859-1?Q?UCwg5k7dLwEmDXz/KsvWIPeYadi8pX7BIejOLNJQhYUeXyo1/HpQMUjc1X?=
 =?iso-8859-1?Q?Itse2pEYaXDUbrGkUvmDm+WuOr2oS3aLWhXHVd/KKn0B21Y+yKffO99hUh?=
 =?iso-8859-1?Q?NbHE1k8IeeD+OUnl7kVFlFNbIZ8J7Zq6MFbjsRs/tR883WeyZ58227IQMa?=
 =?iso-8859-1?Q?lc/vtfZ9Gn/1ky9MBy9V5wIn/nSNo0yT6qLiUemL6fNOwkx4xIOlk5TxP3?=
 =?iso-8859-1?Q?BIDS1tH3o6sfo1SYc48zzEdEz90fp6JXeZyUfy2NuG2hg0GTCN/g6HF6CH?=
 =?iso-8859-1?Q?f90UlhMr3ZKdLLsmkxzydiWHozXWYCddtywXgvQ3/+ItC07gh7jP6XovfN?=
 =?iso-8859-1?Q?o0gZTmCNOUUNaeMsOhJFQ4KFNF8CEpb/POlu1Jf9Sii23fHDx0mmm3jF97?=
 =?iso-8859-1?Q?aEDqe7BzJkQyQOzarZmKHbRl9HczJEWWRz/efYcj1LqgbOLk6iGisCVrSX?=
 =?iso-8859-1?Q?N0SehS+pQE3cUrRxdIprqyihG5Sn1NBr/fvN0O8aN+s5qQjwzDN31KmESo?=
 =?iso-8859-1?Q?DcYXpjD0hvBPwWDBEva8s7Gb5cZH4z7MKLHEFmKK2EgFymKRla6oCd9y8f?=
 =?iso-8859-1?Q?Lvjj6exb93b4gQ/b10qs0Q9b13zND7m/DOBSNxrb8/2PpgbX8Z0gSEr+d6?=
 =?iso-8859-1?Q?0X+hT+Ugr4J78uYZqSDd2bQ4EcjTZxm/8dXaUlVOUWpzxmE18o6vuuRiFC?=
 =?iso-8859-1?Q?QzNMzV1QVBOOR4XeWYApTI4cmg3AHJhrgz9uwhNsyu2wOVmohmkIEViLo1?=
 =?iso-8859-1?Q?vONugQRXlRNzsAW/9ccUebfU4g09h9LUcwsy2S3I+0XrXxpZtwSR1WoH/n?=
 =?iso-8859-1?Q?imTMlh9776wVTrmblt768cSQOqVP8zKzvduRzYFklSGADukhokKZZodhoW?=
 =?iso-8859-1?Q?HnOptOdHlBfWduo0PSjaArkdLESagT6XitdHF06+kFLarerS/n1EepEE8p?=
 =?iso-8859-1?Q?9GjLuco1XClhalkzTpD0Q8i0NdyVmCzrrmkQqVYtogV9QOqNTdpTgcvLrk?=
 =?iso-8859-1?Q?c6wbkZVZR5vHIp6bP3NBEYP04JvxS7gnDX383v3d7ZaUm0v730roZhVrep?=
 =?iso-8859-1?Q?ndoPyqTeHe4Q5P7cJkaU4F7iU80OhzDjZzIOhu+zqwrGKYXrVG6v1dEfAv?=
 =?iso-8859-1?Q?cwwzOns9/Prjl8IqSxMvWImMrEHFD+i/PODc4AeUAdaP/5YSjNDXuko82C?=
 =?iso-8859-1?Q?hsqwDxTBwiI9e7JV9f4yrUD51h8TbZ9dZkSCy330NrpObu38OpP36c9NFz?=
 =?iso-8859-1?Q?c2HtLVuM9130b98xsz6XANcMEffbu7W9GtPmKnLtpGpgqfdx/aTitE6UCj?=
 =?iso-8859-1?Q?5UV8zJLlmhGkFSmZoiv6HRx3nf4Axu4g70?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?Q?VXIeOVfoIc9XzyWQ66cfLvZIU5WA6uUyUFpY6DVY2c6EIlW8WJRCzcncwk?=
 =?iso-8859-1?Q?Ti3sN3IJTwPxcQt72LzgzL9Cng3Hhc0CsgN48m6Qvv2stOeVN2Ug0odeu1?=
 =?iso-8859-1?Q?yMVPAodI3nl22LnMQPsNAQttrzl+M4mlELITFylnajoLsJTiNwFibQhIpX?=
 =?iso-8859-1?Q?KUmezGZpuDWMbI/QwB2trGULSNi7UlZb5tqxzAK8YfOd67FXJZu08xyrMV?=
 =?iso-8859-1?Q?B00h+2nnnvGwaFMm5b5N3YNEaDuHYSXHggio79F53OzwLZACZ3HFQmv3pX?=
 =?iso-8859-1?Q?UUd3JLygnoNHHj3ZURYmGve1HaeFcPMxAvdgN7ZgLjoUSeHxTC+NF9RrP8?=
 =?iso-8859-1?Q?HxmpAaEa8Q/FmItD76zg9+BI4skvyp+cTFRl2DQ8L4Mmqt4b0yRcSxOdj6?=
 =?iso-8859-1?Q?Zirak8dmCa+lb+cMZ94Yrzc6HHHqazEGVZzAWIRk0fYVJmZ6WmUHeRNYyb?=
 =?iso-8859-1?Q?NGml7aUzAmx9+TymsWfbQbVBrJFEq5fJE7NJpEj/xU8Yz/AdlDOnrouxH7?=
 =?iso-8859-1?Q?aXY8/dZizdkhi+t8lN//mjcmQkazdNwGI0YqaFeTg7uQJA2HDNMyhNQ6io?=
 =?iso-8859-1?Q?wQB6tEyzHpJ/sBCD6Aeo6b2QdXp+9Ukgln7twz1SEeNrlj8rgljqIXcmIj?=
 =?iso-8859-1?Q?OsfM63kkFwOSDD4AvX/PGT6foUkpHOF9CXkf5RDJaX90r8a4v722P8O1bF?=
 =?iso-8859-1?Q?3kYHhZEnCTkwVUvHf7BJ3KMDLC1yH3ZhlAdzZaNDRfwYaVxg72t80NjeOF?=
 =?iso-8859-1?Q?xYnTwjhSrQyEfYw6IPcMmkDs8FOhcYeOl7AlLuXxJOjOdL315DVFhM2c54?=
 =?iso-8859-1?Q?1J/GlGZNS21am1f/BHKGfnebBWoVYooDeTI5I4GJMPNERYOTH9jGHcLLoc?=
 =?iso-8859-1?Q?qby7Orc5efnNHFiGc9ly6u1nNPwq2eWrMBcK70IzG8wmMY4bfbpBHreqGj?=
 =?iso-8859-1?Q?ZDVAhDhKgNiX6uIlF7cABItTfb/CiRRd?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9041.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f6f417-a874-4ac7-69a6-08db7eed8fa1
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2023 13:24:58.5015
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0RrEalqQa0fmWS77RK+bujJ+NqJlsg3+lRpLlhK9GWwofYO7aduqCDB14cA7yHHDCGvSCm4ufQYKBENiSDoegg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6904
X-Proofpoint-ORIG-GUID: 1r7rWGqSMJz3v19FXuOF4Pa-A3HE01RY
X-Proofpoint-GUID: 1r7rWGqSMJz3v19FXuOF4Pa-A3HE01RY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-07_08,2023-07-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 mlxlogscore=999 malwarescore=0 priorityscore=1501 phishscore=0 mlxscore=0
 spamscore=0 clxscore=1011 suspectscore=0 impostorscore=0 bulkscore=0
 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2305260000 definitions=main-2307070124
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yangtao,=0A=
=0A=
> Use devm_platform_ioremap_resource() to simplify code.=0A=
> =0A=
> Signed-off-by: Yangtao Li <frank.li@vivo.com>=0A=
=0A=
Thanks for the improvement.=0A=
=0A=
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>=0A=
=0A=
> ---=0A=
>  drivers/gpu/drm/tiny/arcpgu.c | 4 +---=0A=
>  1 file changed, 1 insertion(+), 3 deletions(-)=0A=
> =0A=
> diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.=
c=0A=
> index e5b10e41554a..3a5e66d909a4 100644=0A=
> --- a/drivers/gpu/drm/tiny/arcpgu.c=0A=
> +++ b/drivers/gpu/drm/tiny/arcpgu.c=0A=
> @@ -251,7 +251,6 @@ static int arcpgu_load(struct arcpgu_drm_private *arc=
pgu)=0A=
>          struct device_node *encoder_node =3D NULL, *endpoint_node =3D NU=
LL;=0A=
>          struct drm_connector *connector =3D NULL;=0A=
>          struct drm_device *drm =3D &arcpgu->drm;=0A=
> -       struct resource *res;=0A=
>          int ret;=0A=
>  =0A=
>          arcpgu->clk =3D devm_clk_get(drm->dev, "pxlclk");=0A=
> @@ -268,8 +267,7 @@ static int arcpgu_load(struct arcpgu_drm_private *arc=
pgu)=0A=
>          drm->mode_config.max_height =3D 1080;=0A=
>          drm->mode_config.funcs =3D &arcpgu_drm_modecfg_funcs;=0A=
>  =0A=
> -       res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);=0A=
> -       arcpgu->regs =3D devm_ioremap_resource(&pdev->dev, res);=0A=
> +       arcpgu->regs =3D devm_platform_ioremap_resource(pdev, 0);=0A=
>          if (IS_ERR(arcpgu->regs))=0A=
>                  return PTR_ERR(arcpgu->regs);=0A=
>  =0A=
> --=0A=
> 2.39.0=