Date: Tue, 23 Oct 2007 21:42:15 +0100
From: Al Viro <viro@ftp.linux.org.uk>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC] what the hell is going on with /proc/self?
Message-ID: <20071023204215.GD8181@ftp.linux.org.uk>
References: <20071023020336.GC8181@ftp.linux.org.uk> <20071023202039.GK17536@waste.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071023202039.GK17536@waste.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1185
Lines: 27

On Tue, Oct 23, 2007 at 03:20:39PM -0500, Matt Mackall wrote:
> On Tue, Oct 23, 2007 at 03:03:36AM +0100, Al Viro wrote:
> > 	What is the proc_base_stuff[] nonsense about?  AFAICS, that
> > went in with no reason whatsoever in
> > commit 801199ce805a2412bbcd9bfe213092ec656013dd
> > Author: Eric W. Biederman <ebiederm@xmission.com>
> > Date:   Mon Oct 2 02:18:48 2006 -0700
> > 
> > 	Rationale is very weak and patch adds considerable complexity
> > for no good reason.  Besides, it's obfuscated just for the hell of it:
> > 	if (!IS_ERR(result) || PTR_ERR(result) != -ENOENT)
> > instead of
> > 	if (result != ERR_PTR(-ENOENT))
> > etc.
> > 
> > 	Unless there are _real_ plans that would justify that animal,
> > I'm going to get rid of it in the pending patch series (/proc/self
> > cleanups, saner dentry retention for non-process parts, etc.).
> 
> Seems obvious to cc: Eric.

Doh...  Sorry, thought I'd done that.  Eric, my apologies.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/