Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Jul 2023 17:54:51 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     hexingwei001@208suo.com
Cc:     hdegoede@redhat.com, mchehab@kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        colin.i.king@gmail.com, gregkh@linuxfoundation.org,
        sakari.ailus@linux.intel.com
Subject: Re: [PATCH] soc: ti: smartreflex: void function return statements
 are not generally useful
Message-ID: <e13aa236-45f5-4d29-866a-999c04ef3be2@kadam.mountain>
References: <20230707133447.28102-1-panzhiai@cdjrlc.com>
 <d4b290f08da0c2435f3fa4676e7a5f25@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d4b290f08da0c2435f3fa4676e7a5f25@208suo.com>
Precedence: bulk

No need to CC linux-staging@lists.linux.dev.  Use
scripts/get_maintainer.pl to find the appropriate lists.

Your From header doesn't have your name, just your email address.

The subject is too long.  Change it to:

[PATCH] soc: ti: smartreflex: Remove unnecessary return statement

The patch is corrupted.  Take a look at
Documentation/process/email-clients.rst.  Send an email to yourself
first to verify it applies.
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index 62b2f1464e46..20abfb0b8f26 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device
> *pdev)
>      if (sr_info->autocomp_active)
>          sr_stop_vddautocomp(sr_info);
> 
> -    return;
> +

This introduces two blank lines in a row which is a style violation.  In
fact, there should be no blank lines before the last } closing brace in
a function so delete the other blank line as well.

>  }

regards,
dan carpenter