Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32084165rwd; Fri, 7 Jul 2023 08:27:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlF+1RlUK8a/+3eJlIkL7On6hjRs/XNuciZ/Ra6XJHgy9gS2wUkvNLZhkpIuoe12xMUi8NYE X-Received: by 2002:a17:906:b307:b0:992:4c42:581c with SMTP id n7-20020a170906b30700b009924c42581cmr3618890ejz.62.1688743663584; Fri, 07 Jul 2023 08:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688743663; cv=none; d=google.com; s=arc-20160816; b=BjCC3sUC2MtoG5PaDQPswu9AGzUVbC7jgKDVoLiiIVHye18Fgepy2b2+0Ch4FtXWcV UKyV6DPkY0ldP3AkyzieOsGT+laK3kSAVPRdkgyxz1aaWdESw4QHarlg148fEM5tZNBc 6r4pAq6QZ2DBZgXOtJZzNnNavt1vnSQlJV8fjh/7H6syH3c/LOoeE5texTlEKm1q7CeI 4KKx5dSDsEg27MxlC5EPSFyqPkR5Xto7y4yJcxYVyeIB7MbF3mRXxzQrle3MIw/YyQfi REg9WKOEphG0jhHthOYEq57rDIxWXugEFFXa4yM3M67jeMR4T3SIrt+fQyR9JkwshT9p Accw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=riIQjEaVwcOPrUeedRD9ut4vCA1OigHTcf1/F5unN4s=; fh=RYrGGwm/c14Pfqk3YMiFiKtfPBAl72XZIwG4bU0JRGE=; b=NX6x+CKroAsliAPprMjI7vZBR9qUulHNo7gZdY5yjflk3C/E1B51uDAEqLoQkN2cHL qk5LDw9E3B4kNzlkqf2H8n6B/85n1j/yZuEZq19mkyZ845MGgt5N8muBTeN8bSXUDTRO nRd2UCdif/iz/K4EprD7r86fM0Kjkxi5hcJlrr0fr/vZnsaHc3sS/v0oQJFYfsrG+DsC 7Ii8C1j/J6zQd8Mztn9Jur3eJU9ToJBlSbUptk+YvS4eCPR1wfh/7afaIGpo1wZLgyKb F9qmb++SnnBndvD5d9SSrLeEUFLJ1ToqlmGn99hzrn9SxqavrU2juP/eKlzf0lhakKyW yuHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mLiNirxR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v23-20020a1709060b5700b0097391f75082si2178101ejg.838.2023.07.07.08.27.19; Fri, 07 Jul 2023 08:27:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mLiNirxR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233284AbjGGPGc (ORCPT + 99 others); Fri, 7 Jul 2023 11:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbjGGPGb (ORCPT ); Fri, 7 Jul 2023 11:06:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCA3A1FE1 for ; Fri, 7 Jul 2023 08:06:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AF57619F1 for ; Fri, 7 Jul 2023 15:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DF02C433C8; Fri, 7 Jul 2023 15:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688742389; bh=jYK2XSaPacxc90UzntYFLS4o3hAYHTTOBwjoUw67gLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mLiNirxRPGt4FJN/EmPkQBS31EKNSC6ucw1VG9g8eNXGm03GQALTl590WVSJqccGE brHu0jZLSnV9msktPZC5L9jDtfe0hcVPEMzrFf1cSw/kZ69CVITgK03A4KPKTBlpZS 0dUXWdoEvYIMrLgFPiPyjLlwSyMqYV2Mdf5N7zMmYz0i7x7bvJWc68eMVNI8tV5rVN O8+XlyKy1dqVkJx1Wj8yJYHDsJPB4Fr/Ir92Y0TkrLURTsvcIuC0gNtrcsc0NPWMSD 48sMklM2Scgkvdykxj+1SZFsUBV+NKnpJ6u81Hx4jJnSSmr/Zpf8NkpHlqnevugnO9 Z86E3TDdAKsJg== Date: Fri, 7 Jul 2023 16:06:24 +0100 From: Mark Brown To: Takashi Iwai Cc: Srinivas Kandagatla , Johan Hovold , perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: codecs: wcd938x: fix dB range for HPHL and HPHR Message-ID: <56aecc8d-2f6c-42c0-a13a-89c84cf53773@sirena.org.uk> References: <20230705125723.40464-1-srinivas.kandagatla@linaro.org> <87y1jrkgdx.wl-tiwai@suse.de> <3450ef1e-cb20-4242-b482-41d3d34c4564@sirena.org.uk> <87wmzbkfw7.wl-tiwai@suse.de> <87v8evkf3w.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tlUa9QKqH2IYfFLy" Content-Disposition: inline In-Reply-To: <87v8evkf3w.wl-tiwai@suse.de> X-Cookie: Victory or defeat! X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tlUa9QKqH2IYfFLy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 07, 2023 at 03:47:47PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > The ASoC generic control stuff supports inverting the value prior to > > presentation to userspace so it's masked there (instead of writing the > > number userspace sees to the register we subtract the number from the > > maximum value and write that to the register), pulling that up further > > to the ALSA core might be nice I guess? > I believe yes. Though, I'm still not sure how we can improve the > mismatch of dB min/max. The dB values of those inverted controls > reflect the result of subtraction, no? Yes, the dB scale presented to userspace is reversed relative to the ordering in the registers. --tlUa9QKqH2IYfFLy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSoKe8ACgkQJNaLcl1U h9Ctegf/U3PWgeDMZsd7FXUxx85bNLwdSWlDpYEqHFFJypwv/2YdY32iDhvNH6OR 9DmBkJN5P2e/DDad4QDRL7/Gwwhn4p6xl++jxf7oVpGoQDf1uh/ehNIitkwgOn6Y fHT5J83riAClR+lA2ZwPbe96qGARhRnO4kTCoKywefe6iQozLG/8vdEqnHx9J1rz 1Kf1CNXM01rVA900X8vU+iKWTwnWBQszjDJH/GVlm6ymQ+TJT9i4z2e4beGJJNGR bR7iMU002qW3Q2z1ZPEtESHw/6bGqna8UdRx71Nmrl7KB9nHuMGqOYYYSjwoPGld ZgsBB4NGUfGWHbiJVbBwYwWZ42HuWw== =cnPV -----END PGP SIGNATURE----- --tlUa9QKqH2IYfFLy--