Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754823AbXJWVUw (ORCPT ); Tue, 23 Oct 2007 17:20:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753447AbXJWVUf (ORCPT ); Tue, 23 Oct 2007 17:20:35 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:39895 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbXJWVUe (ORCPT ); Tue, 23 Oct 2007 17:20:34 -0400 Date: Tue, 23 Oct 2007 22:20:32 +0100 From: Christoph Hellwig To: Bjorn Helgaas Cc: thomas.mingarelli@hp.com, linux-kernel@vger.kernel.org, Wim Van Sebroeck Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch Message-ID: <20071023212032.GA26597@infradead.org> References: <20071022180711.5246.49013.sendpatchset@tmingo.cca.cpqcorp.net> <200710231431.15267.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710231431.15267.bjorn.helgaas@hp.com> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 14 On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote: > The driver assumes only a single instance of the device. But PCI being > what it is, it's often possible to have multiple cards, so you might > want some protection in case you trip over more than one. Yes. And even with that protection please move all the global variables into some per-device structure. That makes the code a lot more understandable and future-proof in case multiple devices of this type may appear somewhere. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/