Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <711c5c6d-4b7d-d139-e52f-5d15964402a9@intel.com>
Date:   Fri, 7 Jul 2023 10:03:58 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and
 devlink_port only once
Content-Language: en-US
To:     <poros@redhat.com>, <netdev@vger.kernel.org>
CC:     <pmenzel@molgen.mpg.de>, <intel-wired-lan@lists.osuosl.org>,
        <jesse.brandeburg@intel.com>, <linux-kernel@vger.kernel.org>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <davem@davemloft.net>
References: <20230619105813.369912-1-poros@redhat.com>
 <eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enVPTS83RjVVZVk3TlZZZzBKdW9vWTdBUDMwd01VRU1GQjlWcE5kWjRvd1F6?=
 =?utf-8?B?WHllaE93QWhtQnhqSmRBZnhhTHdHOHFqNGtNb1dXdXZlczljVDVObmJpMnhh?=
 =?utf-8?B?QjUwYnFBY0REdzF3dERUWVRIWWQ1eUpFMWsxNFFGdE9oTDErSHdtbXErcHZ1?=
 =?utf-8?B?ZUFSUnZ1N0JOalhFZzhoVnJFeVhxaUlLR21qN01pNnFEeXd4Vi9yL3hiT1Z4?=
 =?utf-8?B?SEl5eEt1MjJTdUovbHJoNmw2SU9NWGVodWlRTlBteVF2clJESWhaa3VEUGJP?=
 =?utf-8?B?RnB4bGtzR254czRJQ1BYRk9YMExId2ZuU0k3QVNUQlJUYWpHZkx5L1JJVktQ?=
 =?utf-8?B?OVFaeTUyNGhJbEFKV1gxSWNzbnFPRm9ValVYc054NjViNFBBN2g2RXJSRmoy?=
 =?utf-8?B?amlZMDNCbmdqWWluZk1od2R3RThUMjdNUFVvZDA2SUJ6T0xEK2I1QVRRSXA0?=
 =?utf-8?B?SlE1eHMzQkxuMlkzS1VhU0lYb3FYUGhlbGZvRXdtT2lpU1pXZzlPeXc0VFlr?=
 =?utf-8?B?Zm9oMXJOZ2lzdFowbzJsWDNNR25nb3RHelVhU1JUK0FtVzY5dFNiQmFoK3d4?=
 =?utf-8?B?SEczai81NTM5TTNIM1h6TTZKYWVDWDc3SEVwM05WeHVQSEpDcDFnOW5zN2pL?=
 =?utf-8?B?ZVFTZEtZdnpycjlYOW1mdC9JeWtNZWVZK2w5bVVuVXUyRENkV1BETEd4aVNB?=
 =?utf-8?B?MGZHUDYrbXJ0QTdxVVUrUFBaTEZRdmpSdUpXMlpFVy92clpGMWVmck02bGNy?=
 =?utf-8?B?dHRaYSttR2IxL1htVnc1MzBVaVFpOXIzNllvVWRlUXhUc2k4cEVzSUJuckRJ?=
 =?utf-8?B?L2ZSN0Yzb3BjRlJkZmJJMlU5YTZNMFhPeTk5Uy9vNWZkM1NlcWs0d3BESExs?=
 =?utf-8?B?THVpRnhxT3YzYkwwV1Q0WkJrbTIvQUVMdEhydk8vRFhWakg0QlBwOWRhOTRt?=
 =?utf-8?B?RDJaemF2dDdQZUUzNmw1SlQzOXVtVGt6MDd4ZUdoNXZybHJTTzd6WTBZQ3JJ?=
 =?utf-8?B?emZVbGRaOVdzbGMzMDRSOS83Q0NORVJOb1FIUFBLZzAxdGg2M1JyTnhhUnh1?=
 =?utf-8?B?cjBEcCs4UWxRSTZYTXhoM2k1UkJVR0RlOWg4WGt6ZUE1N3cwUG1aQmF5T2Ft?=
 =?utf-8?B?SE9OSEJaeWNVS3ZSK1Q5bzNsMnBsajNnM0grdFQxdm5CV2I5Y003aUszVWI2?=
 =?utf-8?B?VW1qbEtENFA0NFZNTEFSbUllaERUS081NnhIeXpCa01Ka2N6RWRISFVFRkI2?=
 =?utf-8?B?NHQ1QmtRZ3BkUHdMWW9CamFUK29hYnNkWVZ6dGZzTGVIbEppOVRaVGhURkoz?=
 =?utf-8?B?bE84MGgyVlpwcTIraG51Q3NTZjR1VDJuYitJdnQyMTlGZTd4OERZREhYM0pP?=
 =?utf-8?B?RU1oN2E4M3dPcURsQ3dMd3hhYTREai9wSExaQngvdFlSL21WR1c0elN5OHRT?=
 =?utf-8?B?UVM2YWpSNnRxeUtWb09DTTVMN0J4aU1WLzhFUFYraDBuUzJqTHR3Q0NJbU1u?=
 =?utf-8?B?NjdLalY2ZkhlSVQvYURkcUt6K0hzWTUyeVdmbGpIRmtsQ3RGMEZ0SHpZVWNS?=
 =?utf-8?B?d285dVJrVjY1Sm9YYTZaUkZCMEx5dzM1ZTBiNmMyUmIrcmhFdmNnb1BSd1lr?=
 =?utf-8?B?b1EyMCs5MGM0YjU3VTZ0bHJiNnNWcE8zSTg4elFjOGtOSnBrU0xicE5ZSEJP?=
 =?utf-8?B?V01ESXRyQzVNbjN2MGF0em8zWU05Tmx2L25xdU5Pb0dEdkMwYXRBbUlwWjV5?=
 =?utf-8?B?U0ZMSlAvaFpBR0FiYXlPaVhJZGl3ZkV3UmJhd3ZHL3lMMmZaVmNRUFRsQnJC?=
 =?utf-8?B?NDBWeS92aEluenJlVUZBWVcyZC9XSEwwZUJVd2xSODVVOUw1VncreEVnL2NC?=
 =?utf-8?B?RG1MU3ZzcW5NYU8wQ1ZSYURwcktmVXI4NVhldDEwajE5VE9rZ2Z0Rll4bmxv?=
 =?utf-8?B?ZVlmVk80V0ZIMVZtU0hkRTZML3pQcjVBY0ZNc2NoNzY3TnJzL09YQnVRSUZz?=
 =?utf-8?B?a0MrUjVSRzA0RGVoZC9CWExpUzlQZmtUczNCU0xwTHZSTzFvUmF5UU5xbWk3?=
 =?utf-8?B?cUtJTi9FTXdMZkdXamJabXdpcWZ3VEgyWWdmbytML0RFc1FlZmJac3ZhUmFn?=
 =?utf-8?B?NUhzRmJKb2hzbElJWlZvMW1PQjQvR1FpNFVPY1RVdGRHQm0wdE41eU1KSFRP?=
 =?utf-8?B?R2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd7a5275-25bc-48e2-003b-08db7f0c2a27
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 17:04:02.8437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nz5wzpV4uIU+eFp/Mw14GQIskjlYhV1CBrxZ5LR7ezlR4vFI6ABZNSScy1kUQpARRLM8rPIluoctB1YqvjRcjYqTDj5rGoQlnUI2fG4F/kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5230
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/6/2023 2:30 PM, Petr Oros wrote:
> Petr Oros píše v Po 19. 06. 2023 v 12:58 +0200:
>> Since commit 6624e780a577fc ("ice: split ice_vsi_setup into smaller
>> functions") ice_vsi_release does things twice. There is unregister
>> netdev which is unregistered in ice_deinit_eth also.
>>
>> It also unregisters the devlink_port twice which is also unregistered
>> in ice_deinit_eth(). This double deregistration is hidden because
>> devl_port_unregister ignores the return value of xa_erase.
>>
> Hi,
> 
> Is it possible to push this patch forward? I think the questions have
> been answered. Or is something still unclear?

I was expecting a new version based on the question/request [1] (so set 
to changes requested) before the response. Will apply and have it move 
forward.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/eda7b84e56123bce167a64133572440e6806ef1e.camel@redhat.com/T/#mbef0a70424d01bb8fcc1ae1a4865c617fbb4befc