Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32245299rwd; Fri, 7 Jul 2023 10:43:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFm0UVlFdf2PrsTfZQzXU3bUKAa6JZG/crFW+EXfwMVfkuxYWnLlxzZ/T2no4Em+cO1CnYK X-Received: by 2002:a17:907:c01c:b0:96a:4ea0:a1e7 with SMTP id ss28-20020a170907c01c00b0096a4ea0a1e7mr4615795ejc.50.1688751795867; Fri, 07 Jul 2023 10:43:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688751795; cv=none; d=google.com; s=arc-20160816; b=LNz7XjohCDVLx4HIFTzMnPO9LWroB9ZFqlWJkrU1BXN/xoXeozD6Yn72BXBaWe+9mC COcxo2cU+a39JhPLHuZJ8UefPZQcMjzHjLXt9+R0EwdSyv/6xsN+Ze5fAPXgC/xefimP 5iqKV4nZimo1TrzOxjhl5CnhyOPl6d0PBGfawUK4jGA/5vEbkHzQFaGI4EKlbhejAHKH 4Vfy5CsHWMLv7hZHlqlxhhc/Lzrve6GAgA8WhQOnfgfVp8tYKTbedBbA8fQRVxOybRI9 w8nCp1R9+/l727IYpB+TD92BQLKyUn/Z9Q7+R/8zkrEjP+SUJ8GHUdhDxZYknRVE3UI6 WIDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=pFu4flp75v9onUsNmfCEUOpEoM1tS1lAreinLjPuGSc=; fh=tIH6c5sj8WIWvyt4tbsSV39Wyy8Lcs/XAcNGoOwlHMI=; b=ThXE/uiMOFRZEroz7PoAhk42js4DsiGmK8KX9yuahad5QD4QbuzvcQWPoJ+P9H9Eej 0lRizF1xSbIL/0REKwCYVKW5tVIC5KA3N7d/sR69IGuOLKdrsta3HGg6yiE43Wqw5x/5 BwdrDvLV36ksaOYIyfRc+IPujkOpFBUKvu12Tjv05t6cs0gKvACKMKlPuWkCAWAkLiqC 57mhfYqUlUdWmgPTB1o+PAYsY0Q/k6hbJeuEbSSScHdv6dvVeoi2aJ2qbuWp6eY/NCFq CdI+T1bYDqWRyKDnsjzdQ7Y7870toPWjiAFO22vcp7iyDcWTtWEg+GyZUtINmR48M2qi mzVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="sgX0/Ifu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qu14-20020a170907110e00b0096633b5c0aesi2594113ejb.809.2023.07.07.10.42.50; Fri, 07 Jul 2023 10:43:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="sgX0/Ifu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232449AbjGGR2j (ORCPT + 99 others); Fri, 7 Jul 2023 13:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbjGGR2i (ORCPT ); Fri, 7 Jul 2023 13:28:38 -0400 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C07891BD2 for ; Fri, 7 Jul 2023 10:28:37 -0700 (PDT) Received: by mail-vs1-xe2a.google.com with SMTP id ada2fe7eead31-440b9d60606so895889137.1 for ; Fri, 07 Jul 2023 10:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688750917; x=1691342917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pFu4flp75v9onUsNmfCEUOpEoM1tS1lAreinLjPuGSc=; b=sgX0/IfuWQLnwlciUncvEw+t8Wj3pdMJUvHXNvaFKuZcWT5sgNOAnp9BZ+zhCDRfu7 OBoRDoAx61DBjg/tYlTZpOIEEA3Uimf6uN3lrNQKYDBCSDyM3cWIAjyuSFO40q+iQIhY 3zPFyk6vD7TBSck5UBViVZle4sIf02kBmFzISlHb6QVBNud4LaHUavRuV/D+NHZKH4rI OZk2qKe7mNeY4QDLhhqEJQUi9OESuOskgwd2/RnEtaUOsGaGbuongJBlmT/uXWw2Dekl dImwuO+dEHQP2c8/H7bOdoOs80kAB9Qya8pUwyh+MuHBr0Fn6OpQsmlvxEM0BBCPjaUA XLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688750917; x=1691342917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pFu4flp75v9onUsNmfCEUOpEoM1tS1lAreinLjPuGSc=; b=R4wNB1W8byPcYMrA3uGne+0o9EXG4t+la45rQzZVfTyNAgTnVfBgelFN0vSCTz3ncG UV37BxclPPBQj/0ydX456K9vYgOerjhBqRJAD5Ey2RA0KEYPw+YP9DkEtjgToOJ1eCSn 9nLfqloCBELoXWd+9NkkpHWxbJv3x0O8vAfaFVaEJk4F1RsSV4auQl8QDLF5I2nTDQCN 0BQwo55zcAo+TOyPV8ZIdRE00Q7jp+5znur+/JeL1FlKM2Z4eVIUAckdh/0LdjrmCHNu 5Z9w+SDp04iL0nm+yExICmPhrFyVtU+COtSheBDAj86r13qlf3UBbhxRl6zcYZyAyF/F VrMw== X-Gm-Message-State: ABy/qLYjnJLuKwzUkjoC6PH6CuqBswB7SVAkt0U45yGjD8rQa/uyogwA a1xDz8x9BEzJG2ReMXLttVAzujIV5KlA3JWSMy8= X-Received: by 2002:a67:e918:0:b0:443:6c53:e26b with SMTP id c24-20020a67e918000000b004436c53e26bmr3585085vso.10.1688750916646; Fri, 07 Jul 2023 10:28:36 -0700 (PDT) MIME-Version: 1.0 References: <20230706120103.GJ2833176@hirez.programming.kicks-ass.net> <20230707125942.GB2883469@hirez.programming.kicks-ass.net> In-Reply-To: From: Henry Wu Date: Sat, 8 Jul 2023 01:28:25 +0800 Message-ID: Subject: Re: Fwd: Possible race in rt_mutex_adjust_prio_chain To: Mike Galbraith , Peter Zijlstra Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Peter and Mike. Mike Galbraith =E4=BA=8E2023=E5=B9=B47=E6=9C=887=E6=97=A5= =E5=91=A8=E4=BA=94 23:39=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, 2023-07-07 at 14:59 +0200, Peter Zijlstra wrote: > > > > The below implements this duplication and seems to not insta-crash. > > RT bits of ww_mutex.h needed tree_entry -> tree.entry. Modulo that, RT > seems content. > > -Mike I patched my kernel with Peter's patch and tested it with my test program. I haven't seen any race so far and I will test more tomorrow. Fedora's default kernel config doesn't enable CONFIG_PREEMPT_RT so I didn't come across with compile error. I will test final patch if available.