Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230705-seama-partitions-v2-0-9d349f0d5ab7@linaro.org>
 <20230705-seama-partitions-v2-1-9d349f0d5ab7@linaro.org> <20230705195154.GA1702900-robh@kernel.org>
In-Reply-To: <20230705195154.GA1702900-robh@kernel.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 7 Jul 2023 19:34:27 +0200
Message-ID: <CACRpkdbwCYknVbyNdPivTsdbc+R3ndCkkgMTsryoautimpQguA@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: Add SEAMA partition bindings
To:     Rob Herring <robh@kernel.org>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 5, 2023 at 9:51=E2=80=AFPM Rob Herring <robh@kernel.org> wrote:
> On Wed, Jul 05, 2023 at 12:17:46PM +0200, Linus Walleij wrote:

> >    - $ref: redboot-fis.yaml
> > +  - $ref: seama.yaml
>
> I think this is in the wrong place. These should be device level
> partitioning schemas, not an individual partition type. (Though nesting
> is possible)

OK it wasn't there in v1, then Krzysztof said it should be there
(if I understood correctly) and I will remove it again then.

> > +select: false
>
> Remove this and your example will fail. You need unevaluatedProperties.

OK

> There's a problem in partitions.yaml. It never gets applied, so this
> schema never gets applied. The default 'select' is generated based on
> $nodename or compatible, but it has neither. This needs some more
> thought on how to fix given the variable way partitions can be combined.
> Probably at a minimum, all the 'select: false' need to be removed.

I don't think I can fix this problem, I'm not that good with schema.
I don't even understand the thinking around the existing partitions.yaml.

Yours,
Linus Walleij