Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32337092rwd; Fri, 7 Jul 2023 12:11:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlF5+hwbZgK4ds48Z3nqTIGQ3hDsJuv8NFsxRVUvvrfCQ7/6/jVCF3H3PKdKzZuvh5zwF7YG X-Received: by 2002:a05:6a20:9389:b0:130:898:633c with SMTP id x9-20020a056a20938900b001300898633cmr5870090pzh.34.1688757073559; Fri, 07 Jul 2023 12:11:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688757073; cv=none; d=google.com; s=arc-20160816; b=KNEz/P1zyiHHsnYTDLsqjKKs+QYCBIwTI02H560ATOMQzPARg9dq3t/PSNP41/Asu1 e2K4BDdOqA5iafjRHUa7o4/BmTU90VIJWrdbcoAD0HBNrXkRjhWpgF6ddIdhdjQ32de0 NWH0Ik2NTx6x+wOQXr+7mmcl7dFaWgmzxKexjrA7PicH61ubk6oBDu41b7BC+QlcwgFF PaJ/yvLSnV0wePXyQbkWLOhJDRoCJXtvJPiUQaqHrWsWLQtDhLJeGYAhVYSnANmqtPLV 0ll+ZCjp8QedpkW4jtmt22kpgatikc4ZvOYH8LijPO1/VgJ9kqG4szgmUbNiGT6FnNpq N+uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject; bh=27SCXrokpGKht3pF070iJglu2O6edaF/P50hrjamk9M=; fh=NxK186UNMJ4+KgXNOJvB6qlYAw6Uw3TUVrdKR9pYHfU=; b=YQhOAxwlLSkj/UXwMLcQNa/YM5fsXa8ZQ2z+2tIHt0Ahtl9sqrjlRUNfoutoExWmXq egozjdAq2YTNoL8s0YPNhLv0FY7IcFukMiqFTCZFPH6A5Y8Acoh/beL3zNqwrO4S2X8n dgj0BP9J4t1e3b076oa+nlXEYFIeXmOA4/jmyz4sQFt+z/wxKefmlFGWuPraYVNfV5Uz 2jeUql4XEit6GTweHorR4pCNwH2BTcJBuUZxtlSoZkdrOgpNBIrgPa6omJ7XVfNlJLPJ 9W6yLf9iHcgZR1VbM8amdx9pXN+VkbujDpiDqCKFUk6WgnI+CkwYqR/TOArTcoGd7bCI Evdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a170902eccd00b001b8819c1baasi4629069plh.592.2023.07.07.12.11.01; Fri, 07 Jul 2023 12:11:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232849AbjGGTE1 (ORCPT + 99 others); Fri, 7 Jul 2023 15:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232548AbjGGTEZ (ORCPT ); Fri, 7 Jul 2023 15:04:25 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F7362704; Fri, 7 Jul 2023 12:03:51 -0700 (PDT) Received: from [192.168.1.103] (31.173.86.230) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Fri, 7 Jul 2023 22:02:48 +0300 Subject: Re: [PATCH v2 05/11] ata: sata_rcar: drop useless initializer To: Yangtao Li , Damien Le Moal CC: , , References: <20230707095513.64224-1-frank.li@vivo.com> <20230707095513.64224-5-frank.li@vivo.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Fri, 7 Jul 2023 22:02:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230707095513.64224-5-frank.li@vivo.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.86.230] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 07/07/2023 18:41:49 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 178491 [Jul 07 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 520 520 ccb018a655251011855942a2571029252d3d69a2 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.230 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.230 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;31.173.86.230:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.230 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 07/07/2023 18:48:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 7/7/2023 3:11:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/23 12:55 PM, Yangtao Li wrote: > There is no need to initialize the variable ret, let's drop it. Drop what, the variable? :-) > Signed-off-by: Yangtao Li Aside from that: Reviewed-by: Sergey Shtylyov [...] MBR, Sergey