Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Jul 2023 21:01:41 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Suman Ghosh <sumang@marvell.com>
CC:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [net PATCH V4] octeontx2-pf: Add additional check for MCAM rules
Message-ID: <ZKhhFeKmxlN3hFYD@localhost.localdomain>
References: <20230707035321.2227742-1-sumang@marvell.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230707035321.2227742-1-sumang@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VqOM/3rkca4UsdLSkwvl22yZkUQuUv3ntvLRvrc7DH/uqbD1jv2Q3sCtaZUC?=
 =?us-ascii?Q?CoZxZVAVr4jUqezONOlRNLchDM8sZ2FqturWNzdxMWNChFnKK2wEFUTI+Q6c?=
 =?us-ascii?Q?sDmYQU11ZMKXYuXCfueQVYvlDEPIDR+pzZL7jDbjZTUBmJuAV3MNpccqWqD2?=
 =?us-ascii?Q?wwBj6EORgzHSip3OPGZKaEiY1tCbaQovhVTW5+qUngIyOiciJQDkzlnH5pwn?=
 =?us-ascii?Q?1ruGlgPy01m38Grkgqk8nMT0KeWZJ7ZSgXRVrgqoTngFtnaFfBGi7wXWwkg4?=
 =?us-ascii?Q?+nqMMyFY52siEyDpMrA/uC2PgrBE+ZW8nkMcJdGtDw7HEx9EPCwYJKP22b8O?=
 =?us-ascii?Q?+F+48kHXFGxnvf+Bogk897ubRwhvsSRQ8i0tBG9ysSzC7kXVvi93Hoa5w9zF?=
 =?us-ascii?Q?ImwnTfGRUY9Hok4M9TP0oLzYoy7ic+nbBGrXrj577/U8iqtdKjdEJ6jAwhY8?=
 =?us-ascii?Q?a88n2y9zMQ7mcEGSDoMiDnXcMvP052f7x9JgBD5ViihTpb/X5pE90WaH8HlK?=
 =?us-ascii?Q?MJp7P6VCe6ZcGARlX62msW516TifrrIl4wGsE43pH4VN8ps2pRuBse6aCS6H?=
 =?us-ascii?Q?ZjI6WVSwsiOvLVFswEYAdFDtt/oeSltOmup7CgYPEy9AVs0Ov4Nf737cicWI?=
 =?us-ascii?Q?iZXXtGLy3pNoE/WK9yAnh8Zm9+WmhdRleTIZLwE3y8C/Qafz4TLqAtckE8ql?=
 =?us-ascii?Q?HWjipKabwEPz0z17Ah98X20fE6o7XWFI51FTFqgv+MxgyhjiPN0I1BBAAZIL?=
 =?us-ascii?Q?1jK1ZvQRaONbXyi20haVuD/dHu7EfqM6XoMkw3srri8Qt2nM+MGfjfL8giWK?=
 =?us-ascii?Q?As180J/hQF6yKJnjiFdnfBVlcR49+DF7935dQZW3spZk/0WuxeRDTI5oxIIZ?=
 =?us-ascii?Q?2dNc5ShvNM04uaYdtgpWKlfwejbDMfOLk/WY7djBfXXM5ylE19Yu8+k+sqki?=
 =?us-ascii?Q?QVbIpHqA2att5zyF3Yv0u17HyFWFGXiEew48nS8Hf+3fu1XUCn6Cq2CLVG09?=
 =?us-ascii?Q?d2lovbAt2n+fP6FoS3vUM7yJ/hsbab9vtSgbq3mnQkpzg0fwbjkJihG5hXY5?=
 =?us-ascii?Q?aOsGdgZKvq9F57YYWIZjb3BmjbLTt4AEahGiB3gQ78taoBJlCBnp62cmakc9?=
 =?us-ascii?Q?27/SAz1JBEAH6mSO+9fDatu3T235RDOWkAbcd3d9Z7a8Rxaj+Nlro8bNpCSR?=
 =?us-ascii?Q?c4ZxYXEYhSpH4H7bMVsNMzaobM2orZUQ+N+QtzTSCyB1loHyG8Eku/0o5VZR?=
 =?us-ascii?Q?d7mmYH3YV/4E15w+dz0cOSIMC0IJxisi6HrXLQZJ+ScKl3pYV7Nal1CWyUYI?=
 =?us-ascii?Q?LpE3bNqYLhssu2DwvqLI75lLlBX9fP/yfzWJEXauCHJsPkNUv3r6u1roA8UK?=
 =?us-ascii?Q?XyvwvgYd7pYpnEMalfZG7mZ31H8h1Ctf7Rr+5Tpobs0jLfmrIclKxgAdezMm?=
 =?us-ascii?Q?IppP+u553Hd/PlRXzgVer7uAOn1xhxc9yY4BqFNW6pXXi9+fKBzygkHpd/mq?=
 =?us-ascii?Q?qN1TRtNHviMtQ/8ChPiEjSsuXOYokF9d0v8XleecdHguwkzUeBfrqTi1zf55?=
 =?us-ascii?Q?/8zz4jm0ijiwF3fAPUz4YZCaPAhVR21+njAKXGhuc3AJDnwFw5/uyHYWnWyo?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3459bc1e-3c8f-4751-97ea-08db7f1ca169
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2943.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 19:01:54.8856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k2isGb4VMN1/Oczs+zy6XHzmgiMRvqRSojbURfm37TTwWLowOg1YHFiKrsMSnD4Ocom2RQVOGlStkvZWLXo0zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5236
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 07, 2023 at 09:23:21AM +0530, Suman Ghosh wrote:
> Due to hardware limitation, MCAM drop rule with
> ether_type == 802.1Q and vlan_id == 0 is not supported. Hence rejecting
> such rules.
> 
> Fixes: dce677da57c0 ("octeontx2-pf: Add vlan-etype to ntuple filters")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>

(...)

> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -604,6 +604,19 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic, struct otx2_tc_flow *node,
>  			return -EOPNOTSUPP;
>  		}
>  
> +		if (!match.mask->vlan_id) {
> +			struct flow_action_entry *act;
> +			int i;
> +
> +			flow_action_for_each(i, act, &rule->action) {
> +				if (act->id == FLOW_ACTION_DROP) {
> +					netdev_err(nic->netdev, "vlan tpid 0x%x with vlan_id %d is not supported for DROP rule.\n",
> +						   ntohs(match.key->vlan_tpid), match.key->vlan_id);
> +					return -EOPNOTSUPP;

The code got very nested here.
Please consider moving the above check to a separate helper function,
or at least reformatting the error log to fix the checkpatch warning about
80 chars, for example:

			flow_action_for_each(i, act, &rule->action) {
				if (act->id == FLOW_ACTION_DROP) {
					netdev_err(nic->netdev,
						   "vlan tpid 0x%x with vlan_id %d is not supported for DROP rule.\n",
						   ntohs(match.key->vlan_tpid),
						   match.key->vlan_id);
					return -EOPNOTSUPP;
				}

Thanks,
Michal