Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32368425rwd; Fri, 7 Jul 2023 12:44:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlHrk9JIXCDXHaXzpHUG6o0vkXsB+qk4rfdJsH5k5bdegoowiRT08mhm17r5tEuRNxxQ7JXJ X-Received: by 2002:a17:90a:e40f:b0:261:110e:30c1 with SMTP id hv15-20020a17090ae40f00b00261110e30c1mr9329524pjb.4.1688759058655; Fri, 07 Jul 2023 12:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688759058; cv=none; d=google.com; s=arc-20160816; b=sznrB4O1ISAkLwDSSTu7MIViCY2uNxbNvw+vcJsdZkpuNFr0fwq32m208encGMQel6 cU4uTNr7QqO2Dp9D1CNYnNHwsxm3qvwezTSYYMhGNzK6T3qrl/S+PMW26n1SKIpRTCCL /BlXSCkmkCL0IQPTbpbreXFQ+RzXeyGxvH7A9YrE0qA0AAb3X2B4PnIjvvbtJh5H0VbQ jHdowndsLxuOsof3TYzlINCmXNoyyOGQJG4yWzMAeiJG8AYN0Klx6Xq0bXU8s7ePQKgK 6rHIqeaTlEtpFAHHeQBNdRgaZsbluFVDxHvDZ5J1jbpr42HZW8kD4fthzaLtRXvCWhGy IP9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4j/y0gv2OPm2qzE0lc3c76Dbw0fRiSEwa/Mkt12m7dc=; fh=qtT3I61/e7KL7H7hjx0F7aZ9k/rZju/ONjtu0Lq4BvE=; b=PAQ17AAd7KUD1dxLIT5Eru+cXrUBp4HT7+e8u0RFH4Bfcz+N7kl7KvHS2KGmGliBd+ XZedsYAifVOFDyxyJJt1wHpNZXNmwL1cVRTBZCgcAmOF+lNL3BcI68wYEXdX014V/t7n YDHhpkjGPDQuJewZgoZUh9na/cLkqifLeVAf5Q/BM0qFq3akDMsd13xTQjLxqiSLhM/n deVLmsMffskfZDqfDro4Rk+H2aFqTNVyCH3MtMt72SNIjyCSc5gmwaKjuNJB9K8pEO4n 7ZO+9yr6inOkFOd0NGl7o4ejdDKL5q1ZTW72i7J0wqfgdhaaoZxeRHTMcmOaikTgk8/u 4sjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=gsvPIT99; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g6-20020a17090a67c600b00262e99964bdsi2818305pjm.99.2023.07.07.12.44.04; Fri, 07 Jul 2023 12:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=gsvPIT99; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbjGGTnF (ORCPT + 99 others); Fri, 7 Jul 2023 15:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233057AbjGGTmy (ORCPT ); Fri, 7 Jul 2023 15:42:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C72626BA for ; Fri, 7 Jul 2023 12:41:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFFCB61A34 for ; Fri, 7 Jul 2023 19:41:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E629FC433C7; Fri, 7 Jul 2023 19:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688758877; bh=BIeNaJY/voqJfd9eF4kJLjzAy3Uzj1oevyqwzuncZRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gsvPIT99tQSE+DZ7q0ml7NndWr+YIdWiM+/tOR6whtqZxWXBeIP96OO2EubetbExF a8PEouGBKNZB9nhhVSCv5gJehoxDlnys1PI1zWpbTBKSp0uNv/8VAkFCcsrlfZgDnC Q6STSoVuJEI9/vKcwe9rqvvbyYlx2m0xiH0HbH38= Date: Fri, 7 Jul 2023 12:41:16 -0700 From: Andrew Morton To: Muchun Song Cc: mike.kravetz@oracle.com, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: hugetlb_vmemmap: fix a race between vmemmap pmd split Message-Id: <20230707124116.d7be4ba6504a452d11e2629d@linux-foundation.org> In-Reply-To: <20230707033859.16148-1-songmuchun@bytedance.com> References: <20230707033859.16148-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Jul 2023 11:38:59 +0800 Muchun Song wrote: > And inline __split_vmemmap_huge_pmd() > since it only has one user. "open code" would be a better term than "inline" in this situation. If we are to offer this change to -stable then it would be better to do the open-coding of __split_vmemmap_huge_pmd() in a separate, later patch.