Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32374134rwd; Fri, 7 Jul 2023 12:51:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlF5E2a+JLzHClIl+P7/b0e5+KrUJg6SZhO7mlALtMdfX41TKtLLlkJKKYMmBtBGg1wShie4 X-Received: by 2002:a17:902:c20c:b0:1b6:9b38:6004 with SMTP id 12-20020a170902c20c00b001b69b386004mr5640654pll.22.1688759468182; Fri, 07 Jul 2023 12:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688759468; cv=none; d=google.com; s=arc-20160816; b=QJzW/Or3M5X1LepJnfUPYbTwsFOjRYc+MbU2hQfMCQINiVrlBCkkXYEUORGYvO+J6z l+sNT+tU/v8b9G4Yv7o5CUfrdEckfNKqyKNvB9TZYRp1D+1yPf1+TkpEmqsmWqTNpeqO ABonWBcco6v05OmFHluswLGygMLNuZjY+o/t/W0pJ6fdDA+849fkioVc3V7GkdfnwRGp ZM1JpkHMR+y7/OrjY/haJfIWdSxK0S8tCniumjB7p0hT/nivzlQMIEHiBX1SbQqVCTe8 LjHYPf2iOrVHiZzaPkpwaNuZ3+BKMWCCNXGMJVCiku/+pHZvdlxivwuizOp4rwTyzRLU v3ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject; bh=7kww6KphI0HUiZEAajfJ6YQzItkCdvHcId7MgaMRljk=; fh=53L99Dy2m797K3msNwTVLSohKq8CnHdgkoY9Y5NmySQ=; b=En8hgE/DEUuH0qILUIU9lCEKy/9A0gjF3GUeOQng+/0uoNnazSrRgIuq27lA+7AT4V mWKEkUzzljXLCZsfs3cAHtSLHHEDanooy811jSxTM7Ve1L574P+gb28jw/7OASXwUAZ4 AxBeY8dB7B+UuNxnoCVISq0DJL9JAhlH/uKi9SdR/WP2jaGmpoP6RK7nQbZvY+NSNvdL vl37N0mL2CW2L370AL4B4rRgbwsZV+jsiOmxaXitDLMLb/FoDA4lLGPKoHlhW540YqAk cleNDYoIzDEz1ylVVV9MxF4wCrqbqpam4P86Ntw/SyCEl2i3T14ahxpfwSfDt8jieeFY LCHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a170902e84700b001b80ecdcb88si4695994plg.473.2023.07.07.12.50.55; Fri, 07 Jul 2023 12:51:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232230AbjGGTnX (ORCPT + 99 others); Fri, 7 Jul 2023 15:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231972AbjGGTnS (ORCPT ); Fri, 7 Jul 2023 15:43:18 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88B84269A; Fri, 7 Jul 2023 12:43:14 -0700 (PDT) Received: from [192.168.1.103] (31.173.86.230) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Fri, 7 Jul 2023 22:43:06 +0300 Subject: Re: [PATCH v2 09/11] ata: pata_ixp4xx: Remove unnecessary return value check To: Yangtao Li , Damien Le Moal CC: , References: <20230707095513.64224-1-frank.li@vivo.com> <20230707095513.64224-9-frank.li@vivo.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <31e094e4-a9e1-6bf3-27e4-df4a71981cab@omp.ru> Date: Fri, 7 Jul 2023 22:43:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230707095513.64224-9-frank.li@vivo.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.86.230] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 07/07/2023 19:22:57 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 178491 [Jul 07 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 520 520 ccb018a655251011855942a2571029252d3d69a2 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.230 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;git.kernel.org:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.230 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 07/07/2023 19:29:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 7/7/2023 3:11:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/23 12:55 PM, Yangtao Li wrote: > As commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 > is invalid") says, there is no need to check if the platform_get_irq > return value is 0. Let's remove it. Again, you refer to a wrong coommit, you need: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289 > Signed-off-by: Yangtao Li Aside from that: Reviewed-by: Sergey Shtylyov [...] MBR, Sergey