Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32402473rwd; Fri, 7 Jul 2023 13:20:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlHUPBCrptkeO/YT6thK7TDTJpRXIOF/RATLVTDyTBt8i2zfoq+df5RTiB1wMnTgsjqOzat7 X-Received: by 2002:a17:906:74c3:b0:993:4fd9:dece with SMTP id z3-20020a17090674c300b009934fd9decemr4523906ejl.12.1688761249723; Fri, 07 Jul 2023 13:20:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688761249; cv=none; d=google.com; s=arc-20160816; b=prerjtya/vLDLxJp0Pz71CLdo/tZ8C7uFEcky3mnO7nNoRNRimRgoYxkS9krbF9Xmq J9XyMlJZeZzfeCRSrfbZnyUddZnDLlQfpi0cTtqzk+TellfxsLHlBsV0ryFfSSCquYmh oW0qOTqZeMZdq4vIwnPOgx1D7n79SWiDqk3SybQIc8Zn7ReJN8uctAZOH8/cPLe1y+YE v17fP/4RKNB4n9LSkxvrHzpg5Sdwskpdr2rW3ifcqVcO7MTjF2otiRwPDANr67apac/y PE+3bDWgpvkWSs1o2xrc9MLQ+VhUi/93EI/TE3ZK7gFFOJhE0RYbzEhhA0OsG0dxhcgV URSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=eEXDOg8FLRF0KyVi32PAZbtHry6lLqLMGmBKMcsXwAs=; fh=0XokGMj3HDc2Xl9Xy1YxGkrCIREvIjIKii9vXcmzVg0=; b=IHrR5GYDHlmxNfbAzIvZ3nv1qC3WqyJnmdCmVLCWUvt4CjoYRNBDlMt8aJJKQwIjsP EwMJqMpkF4/XMxFXYS2RnD1fMwvkPEgNnotdJ1Ga8obQPp1pTy61DWIVB9b9p+u+r+EM ApVSPwRUjU3agYVnHbE4+Lo9DGnjGye2YP2FF1+m+/rmzZgtUOrYb5Z0W5aX791YYPI2 6zpQ/C4PxfxIrZlSjflzNZF5uSSlENd1GLrcVyo/cwkwm/tK6HHLprB5IsFPQLmLjQOY t8zmYTnfJnvL5D1iwPMgUSjdETXR/rgyz4zy1PVP7GKoED2TIL8o3ZRd1LKXzo72Jpxh VcYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p22-20020a1709061b5600b0098dd7b3684csi2502125ejg.994.2023.07.07.13.20.25; Fri, 07 Jul 2023 13:20:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232620AbjGGUMO (ORCPT + 99 others); Fri, 7 Jul 2023 16:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232617AbjGGUME (ORCPT ); Fri, 7 Jul 2023 16:12:04 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D75FE; Fri, 7 Jul 2023 13:11:54 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qHrnp-00062T-8e; Fri, 07 Jul 2023 22:11:41 +0200 Date: Fri, 7 Jul 2023 22:11:41 +0200 From: Florian Westphal To: Daniel Xu Cc: pablo@netfilter.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, kadlec@netfilter.org, pabeni@redhat.com, dsahern@kernel.org, fw@strlen.de, daniel@iogearbox.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v3 1/6] netfilter: defrag: Add glue hooks for enabling/disabling defrag Message-ID: <20230707201141.GB11622@breakpoint.cc> References: <8a20b0a3fff75bce1bed207631fe4f56abc3e99d.1688748455.git.dxu@dxuuu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a20b0a3fff75bce1bed207631fe4f56abc3e99d.1688748455.git.dxu@dxuuu.xyz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Xu wrote: > We want to be able to enable/disable IP packet defrag from core > bpf/netfilter code. In other words, execute code from core that could > possibly be built as a module. > > To help avoid symbol resolution errors, use glue hooks that the modules > will register callbacks with during module init. Reviewed-by: Florian Westphal