Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32404312rwd; Fri, 7 Jul 2023 13:22:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlHM9fvu3dxm/l44Z1mWApic1CsfqWwPJ1fPX3FpWZOIqMM1MCEXU+t65JkkBBfCWq8KV0uV X-Received: by 2002:a5d:53d0:0:b0:311:110d:5573 with SMTP id a16-20020a5d53d0000000b00311110d5573mr5723470wrw.64.1688761372122; Fri, 07 Jul 2023 13:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688761372; cv=none; d=google.com; s=arc-20160816; b=hWvPBGqHMcz47JkWQybIJ18VyydD6hXBjgk6HL+77kbbJ4om6rkLh2nphi7w5/o3Ie OOxdK3f50W74ax9jMGSHL8YcffLkWrkocq0fg/X03Y6ACH1zE7qJNWVr5XkNlx/U7KFD ZC21fgD01JJF+N6niXRXOWliv6PfeU/uQjb4bkB5PfPtGaVgU/PbRSyVM3SpFfz89ptQ pjLVqS5lm7n7rr3aJ8p6lru3nsVqh+03IdDExeyPJelEGmvoEUg3h86tjj1MAbOxoCni 0qEP7BGVF3+ZPDAkMvBrZVNUP+0Ep9qdZC613tZBo4++9O1hocCe7yr/DBNZaHpHMmQG 3IYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+g+kFfyv7AuJUFV79l9Re5Jgo2/mJklcl8yOvO4DJsA=; fh=JtVXB65MjbBjhAmEJFnEiXcQspPOp2EVV2Nny2rG4N4=; b=uYdNRAGXgW+L6HpzOn+ghVpYq0sfu/cdX5v8oDeW3cJeuOS6fEVXqN9CQb1y13dBB4 fZtd6fjNbxQJqZagd5TjVlm/m/dXqT6nsGAmx7TCsQlABgYz6TT/fkTmFwsNjF5NQUuM dWo8prUfhnNdLP3/5wDeXPQ9C5Qrb7mZSHiyXBqrbo7SWxH+ZkYm2+dIAuErb3N/+tQT nDa0z0V9AZGVx5pNgAt6PSNL2EMVYzAnmtiCYFcyuRJS9Lvf7/DpRC7JxR2JjUJTGPI5 pstD+phf4vXX3mPrhjzVhzz63SPvfOtRd2fR6br8lQYX5bTiBP7UAnLVnam3df8lAulB lsEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa5-20020a170907b9c500b0099381745ba7si2610094ejc.878.2023.07.07.13.22.28; Fri, 07 Jul 2023 13:22:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232408AbjGGUSA convert rfc822-to-8bit (ORCPT + 99 others); Fri, 7 Jul 2023 16:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbjGGUR7 (ORCPT ); Fri, 7 Jul 2023 16:17:59 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD5CD1FF9; Fri, 7 Jul 2023 13:17:58 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qHrtj-00064i-8R; Fri, 07 Jul 2023 22:17:47 +0200 Date: Fri, 7 Jul 2023 22:17:47 +0200 From: Florian Westphal To: Daniel Xu Cc: ast@kernel.org, kuba@kernel.org, daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com, kadlec@netfilter.org, andrii@kernel.org, pabeni@redhat.com, pablo@netfilter.org, fw@strlen.de, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH bpf-next v3 2/6] netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link Message-ID: <20230707201747.GC11622@breakpoint.cc> References: <3b1c20ea7eb2f77065c683e21a2a5d457a57011d.1688748455.git.dxu@dxuuu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <3b1c20ea7eb2f77065c683e21a2a5d457a57011d.1688748455.git.dxu@dxuuu.xyz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Xu wrote: > This commit adds support for enabling IP defrag using pre-existing > netfilter defrag support. Basically all the flag does is bump a refcnt > while the link the active. Checks are also added to ensure the prog > requesting defrag support is run _after_ netfilter defrag hooks. > > Signed-off-by: Daniel Xu Reviewed-by: Florian Westphal