Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93285ee9-cc63-ed74-f7e9-4ff0fb56e7c8@linux.ibm.com>
Date:   Fri, 7 Jul 2023 22:19:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH net v2 0/3] s390/ism: Fixes to client handling
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexandra Winter <wintera@linux.ibm.com>,
        Jan Karcher <jaka@linux.ibm.com>,
        Stefan Raspl <raspl@linux.ibm.com>,
        "David S. Miller" <davem@davemloft.net>
Cc:     linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230707105622.3332261-1-schnelle@linux.ibm.com>
From:   Wenjia Zhang <wenjia@linux.ibm.com>
In-Reply-To: <20230707105622.3332261-1-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07.07.23 12:56, Niklas Schnelle wrote:
> Hi networking developers,
> 
> This is v2 of the patch previously titled "s390/ism: Detangle ISM client
> IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
> up. While doing so I noticed another problem that was fixed by this patch
> concerning the way the workqueues access the client structs. This means the
> second patch turning the workqueues into simple direct calls also fixes
> a problem. Finally I split off a third patch just for fixing
> ism_unregister_client()s error path.
> 
> The code after these 3 patches is identical to the result of the v1 patch
> except that I also turned the dev_err() for still registered DMBs into
> a WARN().
> 
> Thanks,
> Niklas
> 
> Changes since v1:
> - Split into three patches (Paolo Abeni)
> - Turned the dev_err() in ism_unregsiter_client() on still registered DMBs
>    into a WARN() as it should only happen due to client bugs.
> 
> Niklas Schnelle (3):
>    s390/ism: Fix locking for forwarding of IRQs and events to clients
>    s390/ism: Fix and simplify add()/remove() callback handling
>    s390/ism: Do not unregister clients with registered DMBs
> 
>   drivers/s390/net/ism_drv.c | 153 ++++++++++++++++++-------------------
>   include/linux/ism.h        |   7 +-
>   2 files changed, 74 insertions(+), 86 deletions(-)
> 
> 
> base-commit: d528014517f2b0531862c02865b9d4c908019dc4


Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>