Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19e87eb3-7dcf-d38e-474f-52a18b5e3bb1@intel.com>
Date:   Fri, 7 Jul 2023 14:38:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.12.0
Subject: Re: [PATCH v5 2/8] x86/resctrl: Simplify rftype flag definitions
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168564586603.527584.10518315376465080920.stgit@bmoger-ubuntu>
 <168564606414.527584.9565322327658331140.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <168564606414.527584.9565322327658331140.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnlXdWNCSW5FWi9EVi9EMWdGWjZPZmw5RWdoN2dCMmFON0dQNk83bC9yQ3RQ?=
 =?utf-8?B?SUluUjY5bDkza0VrOFpTWFBFSnljVmlBYm90RmhSR0NxYncwaUFXd1VFc01C?=
 =?utf-8?B?b2Jvc1dGSHFicDJsWXpRZU1GVkx1cDVhenZDbXNwREFVUWIreUhpZi9OdEw0?=
 =?utf-8?B?aFZPMldNZkYrNml0VDF5TmxYUXM0anRYK1pwSDJVWnVlN2JIYXY4eWJHQXA1?=
 =?utf-8?B?R09XV2krVmNxdW1iMWs5dGR4UHU5bkZyWVVOZ1ErZHB2TXROVW9aQ0pUV1dn?=
 =?utf-8?B?dHFaV3ZiTXc5bGNhYTBpVCtYNUdVdVRTdHIvZjRsbU05b3hhWHdFZU5adHh5?=
 =?utf-8?B?SFloL2VVRG82RWh4RktyWDZmbGJ4SVhVcCtlZGpsT0cxVUVxbHMzMDE3cmtJ?=
 =?utf-8?B?bGFITm9tWXJtTittdDV2TjhGWFErTy92dzdqUUdEbUFMR0tyTU0xYnZ1WDNi?=
 =?utf-8?B?KzdEdXpnNnZXSkQwWnRvZDBGQnJuaXBhcTZMdTNOTjk1R2pyaFhPR0pQV0pR?=
 =?utf-8?B?U0N1TlU3YktGMGZvMXhoRmVXdmpOdFN0ZTUzZDRadWZ0UjN2M3VRbitKRnRu?=
 =?utf-8?B?SWF0N1dBMEl5aDRYcWNvT1hqTkFVNkV2NENQRmVwQjdUeFdlTXNIVlZnWXh0?=
 =?utf-8?B?OUVGVzljbGhXbkptaWRHZ1pNSVk2a0RvRVRUQlZMUXVOcDIvQVc4WlVtNmRH?=
 =?utf-8?B?MmpIQngxRjgxV1VRajI2SWpWVU8zK1RKOE1VQ2ZrOHMxUkExckFtVDczOHBM?=
 =?utf-8?B?aUlKd09HOUl4cks2WTQza1J0eW80TERaMklSUTN4bjhPM3laMkY4TUsxVnpm?=
 =?utf-8?B?WCthaDQ1SGZHWlBTa1Q1czltVW13c0tLS1N2SEJ4OWcySGFrRDJ0Mlp3QUNF?=
 =?utf-8?B?Q1dvT1lacHRCaWdZcmZ1aWU0S05EVG9iSm1PMVRGcDdRb2ZTUmd6b09sRmVI?=
 =?utf-8?B?M3dtRUVYckphN2tHeHdEajY2UTZ1RXhzd2VhdWo5eGxqQnZ3UjJYWUR6cXNP?=
 =?utf-8?B?N2t4YUVPRVhOWmJTeUxROXQ5R3JMekltOUNaM2lFempTdzA0Q3pTNmdITnZj?=
 =?utf-8?B?SjFWZHpWZXFLK2FleDdib3UreTRGQkM1MGVOdGV5SzBVZ1JtaTF3b2Zkd25i?=
 =?utf-8?B?STZneTZmSFc0SkxhVVhtUERQaXpUNlk3K2doVkhqK0o5bHpCVk5QWk9rMnMy?=
 =?utf-8?B?ZjkyZWtCbWRXejE3SVVpZlZ6ZzkreDZjcTgrMjVQODNZaWpLR0JtdHEra0pR?=
 =?utf-8?B?MWEwS1BOY3M4VGlmVDBoSXpZVDlVU29VdDZ5dU9OaHNmNXNlY2dPOVNZMnhI?=
 =?utf-8?B?RFJuVWQveXlOUWxiSENwekF0eEh4M0dGQVcxcExOTHM5dGozWEJ4LzQxQndG?=
 =?utf-8?B?dlBrN09mMDhyeU1EaDU5eVVTMjExUnA2N0lwMmNFcHUwUThGSGRSUGpiTGFl?=
 =?utf-8?B?ZUtYRDc1d0JLUFN3QzVtSGhhUUh1VXgrRW1oTGtnbEhvQVhqeHVnSHo0RWFk?=
 =?utf-8?B?ckVpVXN2ZjJHUHpSZTJqL2FQdXF6V1d5QWtvcVlaZ01OZTdCaGhneEVYemxo?=
 =?utf-8?B?YTc5aWxWemIzeXhSWHJBeU9jSFlRS3JraVlTWDFEd08yNThwMkMrdGdqL0lp?=
 =?utf-8?B?RDdXU2xWK0F4cVpPcERzSGxHR1luUWFvOXhDSlozaUNnVWFNQW5vZU5XWmFj?=
 =?utf-8?B?MHpTbDhJeTJqbEoxUUxpKzk1cjhXYmFYR3p1aE05aTNhR1VITTRIRlJ1NzJh?=
 =?utf-8?B?VTA5aEpOV1JQT1F5dWJSR1FMQkNGVTVTamdlbW1yUDZRYnRaRjB5akxpSG5q?=
 =?utf-8?B?bE82NGloZ3djS2lpaUI2SVB0bzNHR0R1SEJhbjdYakxNRDRkUHh5ZjJLSDYr?=
 =?utf-8?B?OXJBNXlPNk1jODBMbWxvUnAreG1ra2tRbEoyaE1kUlhSejJCaXBQZURmUVBO?=
 =?utf-8?B?OWV1dWRYMmtSOEgwMFVQVzRLRWtPdnRHbE9EMEwwM0srYU45Y3RDNlZVS21x?=
 =?utf-8?B?YllEUGxFN2dac1VaY0thcjJGa0FkYmRWcHd1RUFKdDdQOWpXRnNtdjc0dE43?=
 =?utf-8?B?bDlTaGwvT3JRbGhpQmdkREZick9QdVQvSXFvcWNRVVYwZTljdFpidWNzai9x?=
 =?utf-8?B?NUtWQXJoM3V6RDB5US9URndqTTI4ZTNhaUF4ampGbzNVRmE3RUkyY0tHb2h5?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e1a6c9f9-c0a7-4d38-ea82-08db7f32855b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 21:38:36.7095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4tf5+PGWnoQ7L92XOEOiwVf2k4ZUM11ws4wkWUqKOLoLtQebr9peUhR01CVG9dcjdisrBGaQlTZqBFpKYZggKy7NWCaHlWgeO6nNXtZuXR0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6726
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 6/1/2023 12:01 PM, Babu Moger wrote:
> The rftype flags are bitmaps used for adding files under resctrl
> filesystem. Some of these bitmaps have one extra level of indirection
> which is not necessary.
> 
> Make them all direct definition to be consistent and easier to read.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette