Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <94694f76-62e0-3751-3791-936db8b7e3ce@intel.com>
Date:   Fri, 7 Jul 2023 14:45:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.12.0
Subject: Re: [PATCH v5 6/8] x86/resctrl: Display CLOSID and RMID for the
 resctrl groups
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168564586603.527584.10518315376465080920.stgit@bmoger-ubuntu>
 <168564611100.527584.7981937236207103115.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <168564611100.527584.7981937236207103115.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGllSG9OSTYwS2YwUWs4ZDdSUHR3MVhUY1hDeTFwUDRJRXhSR1NqM3BoUVV1?=
 =?utf-8?B?cmtMdmNSQlZUN0kvbFpTMXNKcFFzaGRwWW1sK01XaExMVXFZSDNneVRrK1M1?=
 =?utf-8?B?UTZreEczczRTb2dkMmlNMDh6RHlORmNkZzZMTzZUZjdPeWh5VnNacGRDdGRt?=
 =?utf-8?B?QUFBT0VuWGtML1NFVlBVdm15NlZrM2ovQmp2L2plbFZjVUE5bldEVUx3TzlM?=
 =?utf-8?B?ak1YK3l6VnFqTk5BMHRlQSs0Wk5Xc2VtM0NydFdoN0h4SDNIcHd4d1FETGM1?=
 =?utf-8?B?bHJ6MXd6MTc4NGFDSGFmanYrbHYvM3h4UVczQmRoK040UGgzblhKcUl2cTR4?=
 =?utf-8?B?b3pocGdGdUtMdjh3RWxELzJtYVBMYS9CNXdtUXRBd090SFJXSXJ5aXhhSW1y?=
 =?utf-8?B?dEZ6T3RlK2ROeVVaZUZCNFVFRkdjWUtWdkljOE9DZ2xMZ3QwY0xZTzdJQTFX?=
 =?utf-8?B?RzNFNUJQOStRTkdTTmFCVVFybjhmVjdFd3JwSXBXYjkwVkNtazllL24yaEVD?=
 =?utf-8?B?KzJTZXhpNllCVWRaU1ZQVHFUeFRtVU1nSzRyZWhUOVFQZkpaR0l6YU4xUVpN?=
 =?utf-8?B?aENQN0ZjSFBiWGpGSit4Q0krWHhMZFRCQ0lOc0RDYUhFb1Fscm1rcWFpWURh?=
 =?utf-8?B?RjJnVVpyMGk0RXBjWm5ZemxFTVFzeVlhemZzeWFURnI2Q0Z3QmprS3dhbjJn?=
 =?utf-8?B?OGluL1RKQ3hXcVhTaWgyMGJlc2M4eDZmeGE1U0RBUUNUZytwd2hWQnBFUGhK?=
 =?utf-8?B?SFhmTUhILzhOTGxERWRNbFI4SVFOTE1PLzRYYi84d2xQeERxeXlsOTRMM3FX?=
 =?utf-8?B?NHBNa2txdGFPSlN0aHViWHN2R2hqdlV1NEpUUDg0L0RnY3paZnd3ZFA4RWdF?=
 =?utf-8?B?ZjVZSHRvYXczRExJWnQ5S0RvMUZzT0JwVUV5akplTFAyVVg2cjluaTgwY1ZN?=
 =?utf-8?B?SkFTeWV1M0dWb242dWpWbXJ2bVF2NEFibGJIeTVUYnBkbTlzdFRCUDFCeVJL?=
 =?utf-8?B?c2FNdGQwOUp2c2FyOUUwUm4zYTF4cVVIaVN1Vkh2VWVTZnRYb0FjOUwzakZO?=
 =?utf-8?B?R2luRnpBNjRhemp0VnpqdlQ1WHBqZEt5ZEYrb1IwMHMzS2RjTkxNZzhWWkJ5?=
 =?utf-8?B?ZDFXZ0d0SlJycm9KRG5NUno2NEIrdS9sTUx4V3VSU2xIQ1pUaWllQU5LMkYx?=
 =?utf-8?B?UDBmdFdGaDd4M1BkUUpPRVloemQxVUc3VVI0UGRtWSs1bjBOT1NQTkhHZlZX?=
 =?utf-8?B?K0VIUUFRVkNOYUN3NjRuM2Nma1hyaHprR3V2MWkwcTRLSG1SMnlRYS83b3B3?=
 =?utf-8?B?Y01hUWZtaEt6TFFydU1Rc2xlUHV6cHAvZGtCYVZTdUVZV21HSVo3YlltRVlS?=
 =?utf-8?B?Q3hjWDU3OE9KUklTM09PK1NudGVqOG1wcWJ1WjRaOVRhOHpFUC9IMVZEVzIy?=
 =?utf-8?B?VFMwNEZuS2FEL01TSm5rdWZaSXFtVUN1bFFqVEZvZVVvZnRXQVFpZ29OWTND?=
 =?utf-8?B?M3hDVWpZaUF5a2diMTVXSjFDV2tOalJxRUtxSG05UjhFVUZ3a1ZkSHBkYUU2?=
 =?utf-8?B?R2hjWGpjUnNQdmN4ODMxTWQvenh6NlBrUXc2TzFDYi82WHdCZGdyaUtWRkph?=
 =?utf-8?B?SzRlV1VGanQvNHhZUHRNRFdTL0xBNVYrZGttQnNoRUtYdWJxSk1ycDdDZ1A0?=
 =?utf-8?B?ODI5MUNtbHpTZTE5dzdHRzR4cVArSHh0ZjVWdnEwNzBEQmZocEN0TFdkSFJK?=
 =?utf-8?B?djNUWHlSQUpyeVdHam1aaEFUenJqS0MwWTZQMVFnL2s4SU9TTGVuYWFjMkRv?=
 =?utf-8?B?MG5VMU9neCtVbkJvVE9ZbjVKbklCWHRFbHRTSzQxa0p6Qk4xUXFLazFPUndM?=
 =?utf-8?B?SDRGK3d4TWJZck5BL2MwbkpxTWlMQk4xYlJPSExCUFdoaXdHdS9TSzNxNWY3?=
 =?utf-8?B?b29WcEc5SEc3dU1NVnRZWndPNklCQzJQWm1FMjNDbHExTW1XWkI4NnRQZ296?=
 =?utf-8?B?NHNTeWdXL3Z1anBGSWFZWDN0K0FPQjkrUUg5WXN0bldMMFZvZmJkYkZrRVZ3?=
 =?utf-8?B?akxLckxPOEpJRzVEZnhuaWhvWldWZm5jQ3ZIMDhaUDZTaTJRZVpxSk1HRFFq?=
 =?utf-8?B?WkhWclhIUVZFWFZzbUlBUUxYVXVYSi9JS3FRR3pFMHFIbTVNU1ZkMk41aXFq?=
 =?utf-8?B?Q3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 380bce7c-9bc5-4825-1851-08db7f338daf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 21:46:00.2609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mbVe7n8H2c7yIJSGnDyBwlnzWSljB//PZ7KQ6GjfLox98mfMcOjzOZgUKa3Tew2yu/myKcuvLjRQRiDWGRPyP31f4OS+ay5Ha1e6RU01Q34=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 6/1/2023 12:01 PM, Babu Moger wrote:
> In x86, hardware uses CLOSID and an RMID to identify a control group and
> a monitoring group respectively. When a user creates a control or monitor
> group these details are not visible to the user. These details can help
> to debug the issues.

"to debug the issues" -> "to debug issues"? Even so "issues" is vague,
perhaps just "These details can help debugging."

> 
> Add CLOSID(ctrl_hw_id) and RMID(mon_hw_id) to the control/monitor groups
> display in resctrl interface. Users can see these details when mounted

"when mounted with" -> "when resctrl is mounted with"?

> with "-o debug" option.

Could you please add a snippet to explain the file naming choice? Just a
mention that this is done in support of other architectures that do not use
"CLOSID" and "RMID". 

Considering that, "x86/resctrl: Display hardware ids of resource groups"
may be a more appropriate subject.


Reinette