Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43ca50af-a58c-36de-74f7-47750faf79c5@intel.com>
Date:   Fri, 7 Jul 2023 14:47:09 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.12.0
Subject: Re: [PATCH v5 8/8] x86/resctrl: Introduce RFTYPE_DEBUG flag
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168564586603.527584.10518315376465080920.stgit@bmoger-ubuntu>
 <168564613667.527584.13233260903070279360.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <168564613667.527584.13233260903070279360.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkNpRlJxZDBXcmVXczJvWk9tdk1OTnovcnpjamRLKzR5bG9YK2ZoMVU2bFFt?=
 =?utf-8?B?b3ltYkNYemY5UWx4N241QWx2cDcyRy9rbm1KQkNVVTRUcyt0SGR5eThxMlN3?=
 =?utf-8?B?NmFmcE0wKzBmYUZ2eDJoYUhnR3RGYmZKVkY4bHMyZWh0NjJXcG9vT2RNcndp?=
 =?utf-8?B?L24wZURaamwra1dlZzk3NVRoV0gzeDNiR1pxcEJqUDl4Y1JJb3dxSlMvVm81?=
 =?utf-8?B?UkJSUStsM2toTE5GaFNQclFrRUFQR1BmUDlmSmRtazBXcXJJdDZqMGdEU1Mx?=
 =?utf-8?B?S0FFaFdJUzZ2OTRGdUdHYWxRZDExVlVvSWV2c1o5d3F5THpzK2Q1VVdEK2tp?=
 =?utf-8?B?TTJRak9pTnEyQ0dES1htaTVPSm5vazlQNlp5ajVGejY5cDc5RmcxUkF3VjhG?=
 =?utf-8?B?YXlUcnBWNjBMNXFyeEdhcnhYVlI0S3pleFZWVjlmT2ZiUzl2Y1FxM21SSnh0?=
 =?utf-8?B?TmQzUVdWUmgrUjFic2VBdWdPSUVzRGlsamNBMnJvWTJZYTF4clpRZ2ZNVm9S?=
 =?utf-8?B?L2FsdXc5TFJ3TUllejFHdFVsUG5ab1lraXQzQTd6UjVsaGUwTGlDSytxenRF?=
 =?utf-8?B?K1RuOEhJTGtYVUIzTk5WYTdWZXphZnBrc0N2aVJwNXlGT2hiWGg2RUNUMjhX?=
 =?utf-8?B?b2pnT1A1cFdlMDBOdEdQT2pUcDU1SndvZEY3MnJwZmd2M21jalEvZGlFNzJP?=
 =?utf-8?B?MzFickJDWDlGdGE5ZUdEQS9makxUcCtadm90SExyYTVCRHZReGdrOExYZGJa?=
 =?utf-8?B?KzNaVENWczQ3Q2tWd2hTb3NiRllWdWphRS92VXVmSWkvdXV6QmgxdGlmSHBG?=
 =?utf-8?B?QzVobEJNcmM3bE1QNzNrc0hSSUFoUHU1RE4zbGRVZ3piNkpjYVRKeUw1RzBT?=
 =?utf-8?B?R1RQR1pSU2MrVm1LZFZteTV6VDUxLzZJUWFxZW1TczBwMldUZDlBcStJdC8r?=
 =?utf-8?B?ejBqWnRHTDUvSFp6WTkwdmd2R2RmR2YwRDN1Rjk1R0NzMVZ3dW9HaU4ySG1q?=
 =?utf-8?B?emxvYjVid2FVK04ra21uRDE2c2VmVjFDNEwrbGUvVlNGVmZxZFdKU3VUMHNn?=
 =?utf-8?B?ZnZ6c1hlM3MxV1hQakV4WFB2ZEh6b3lqczZVaWRZUDFMVEFSc2JKVHlTb1BJ?=
 =?utf-8?B?VkxEc2VCaE1RNkJJMzVoUnB0RWxmVUhjOGZ3d2N5M21nNldrV1NsQ0ovVlI4?=
 =?utf-8?B?R0YxYVgxb3lsL1RZbEFETGZFYzVYSmVzbjBwRG14K1ZlVkxjRlA1N3hDY1VI?=
 =?utf-8?B?R3RxSUxVeWMxa1JndlBzR1h1alFuNWMyTWZmUXhxNjBYL2FyaFhUZTBpam56?=
 =?utf-8?B?RUQvZFBmL2xpNHV4UE5zY1NTS3Q1dUlWWHRMUi9GSnlrZytTR2RQNXNSSjVD?=
 =?utf-8?B?RjJNeE1GUWFCL1h0azVSSGZqSXdOSDhRTHhaSFllZ2wwODJ0Nkg0eXd0U3lq?=
 =?utf-8?B?WmxiRkNGcGZRSmxJMTFuTXR4emhXem1PdW9YWXpHUkJuRTZ2dkwralJpT0hQ?=
 =?utf-8?B?YnpDRStveE9sWGV3VFl4TURka2NUeUhiSG52SmV0Mkg4eHVsTThnTzhybU5n?=
 =?utf-8?B?Z0dyUUU1QXZuRHRDQXpRS1ZSMjhGRDB0dHVibHU0cjJkck5wWHhrYTFEVndP?=
 =?utf-8?B?dWEvS1NmSGVuUlZUY3pEVW9IMFZpZ3VwWUtHYjRWMnozVTVhR1M4RWFjdVJ4?=
 =?utf-8?B?aG1lLzNPb2VJbjAzUmk0K0dEdWtzZE92TWk5YlVCTUNKL0VnTHNKNUl6MjQ2?=
 =?utf-8?B?QjBkRkdweWtVVVpTMm5FbC9oYS81VHo3d25xRkg3SStzTE5ndVYzWHZtY1Ni?=
 =?utf-8?B?YzR3ZWwzN3FqNEt3UExXa25CU255WElGeU5jS0MyNDB2aWd6Mk5mNkpKWjh1?=
 =?utf-8?B?NkFMSmJYYytvL1N1K1pESjFWdXU1NitCaFhqajBHYmJxZlpCRW9xendUQk9B?=
 =?utf-8?B?SEFVcDdVUkowZGViOE5MaUUrYVZYMmhrRjYzdUhla29ZZnJtcDUxNDRTV0Y2?=
 =?utf-8?B?S211WWxTUWkybUYwcHEzWk5uUWJYMGM1dnBNY0tzSkZWOE9jL1oxMGpLL0Q5?=
 =?utf-8?B?SjFoQUJPVGRHd2VvdmNzcENUcU9sN0pFcE5tSERhMDcwU3NLNytmLzRXRkUz?=
 =?utf-8?B?QVA5TVVHS3hQY29aMXV2YjFFMW1DbVdLdGFveUc4anVtcTlxTXF4T3I1V01F?=
 =?utf-8?B?bkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a7c8b2da-b69e-4ff8-c5d6-08db7f33b8ea
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 21:47:12.7785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zW8MOf6Q2kJOrJ+6MNQzXLMiR+60wkYHi3MLsRO11+Y83ldhRAcluiM4ZrUjW+ZR1FqLkOyMleFXU+U4C5p5mSkuQ9nWxJYtTLCew9OtIHM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 6/1/2023 12:02 PM, Babu Moger wrote:
> Introduce RFTYPE_DEBUG flag which can be used to add files when
> resctrl is mounted with "-o debug" option. RFTYPE_DEBUG is OR'd
> with other RFTYPE_ flags. These other flags decide where in resctrl
> structure these files should be created.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h |    1 +
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c |    5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index c07c6517d856..5bc8d371fc3e 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -294,6 +294,7 @@ struct rdtgroup {
>  #define RFTYPE_TOP			BIT(6)
>  #define RFTYPE_RES_CACHE		BIT(8)
>  #define RFTYPE_RES_MB			BIT(9)
> +#define RFTYPE_DEBUG			BIT(10)
>  #define RFTYPE_CTRL_INFO		(RFTYPE_INFO | RFTYPE_CTRL)
>  #define RFTYPE_MON_INFO			(RFTYPE_INFO | RFTYPE_MON)
>  #define RFTYPE_TOP_INFO			(RFTYPE_INFO | RFTYPE_TOP)
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index e03cb01c4742..9e42ecbb9063 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -1862,6 +1862,7 @@ static struct rftype res_common_files[] = {
>  		.mode		= 0444,
>  		.kf_ops		= &rdtgroup_kf_single_ops,
>  		.seq_show	= rdtgroup_rmid_show,
> +		.fflags		= RFTYPE_BASE | RFTYPE_DEBUG,
>  	},
>  	{
>  		.name		= "schemata",
> @@ -1891,6 +1892,7 @@ static struct rftype res_common_files[] = {
>  		.mode		= 0444,
>  		.kf_ops		= &rdtgroup_kf_single_ops,
>  		.seq_show	= rdtgroup_closid_show,
> +		.fflags		= RFTYPE_CTRL_BASE | RFTYPE_DEBUG,
>  	},
>  
>  };
> @@ -1905,6 +1907,9 @@ static int rdtgroup_add_files(struct kernfs_node *kn, unsigned long fflags)
>  
>  	lockdep_assert_held(&rdtgroup_mutex);
>  
> +	if (resctrl_debug)
> +		fflags |= RFTYPE_DEBUG;
> +
>  	for (rft = rfts; rft < rfts + len; rft++) {
>  		if (rft->fflags && ((fflags & rft->fflags) == rft->fflags)) {
>  			ret = rdtgroup_add_file(kn, rft);
> 
> 

I think that the first and last hunk of this patch can be
squashed with patch 5. From what I can tell it would help
the motivation of patch 5 and fit nicely with what its
changelog aims to describe. The remaining hunks can be
moved to patch 6.

Reinette