Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230706145154.2517870-1-jforbes@fedoraproject.org>
 <20230706084433.5fa44d4c@kernel.org> <CAFbkSA0wW-tQ_b_GF3z2JqtO4hc0c+1gcbcyTcgjYbQBsEYLyA@mail.gmail.com>
 <20230707151206.137d3a94@kernel.org>
In-Reply-To: <20230707151206.137d3a94@kernel.org>
From:   Justin Forbes <jforbes@fedoraproject.org>
Date:   Fri, 7 Jul 2023 17:19:12 -0600
Message-ID: <CAFxkdApnEo8RPOQ3zVjAZBeTtH2UbaT2798gQ5w0SA5e-dtZng@mail.gmail.com>
Subject: Re: [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Jul 7, 2023 at 4:12 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 7 Jul 2023 11:50:16 -0500 Justin Forbes wrote:
> > > On Thu,  6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:
> > > > The rmnet driver is useful for chipsets that are not hidden behind
> > > > NET_VENDOR_QUALCOMM.  Move sourcing the rmnet Kconfig outside of the if
> > > > NET_VENDOR_QUALCOMM as there is no dependency here.
> > > >
> > > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> > >
> > > Examples of the chipsets you're talking about would be great to have in
> > > the commit message.
> >
> > The user in the Fedora bug was using mhi_net with qmi_wwan.
>
> Hm, if anything mhi_net should not be sitting directly in drivers/net/
>
> I don't think this is a change in the right direction, just enable
> VENDOR_QUALCOMM? Or am I missing something?

Enabling it is not a problem, but it seems that if devices not hidden
behind VENDOR_QUALCOMM are able to use rmnet, then it is incorrect for
rmnet to be hidden behind VENDOR_QUALCOMM. I have already enabled
everything for Fedora users, so I am not worried about how to support
my users, just a matter of correctness, and the fact that Kconfig deps
are more difficult for people to understand in general.   Someone
reading online hears they need to turn on rmnet, so they add an entry
for it, and don't realize that the entry is ignored because
VENDOR_QUALCOMM is not enabled.  Either all devices capable of using
rmnet should be hidden behind VENDOR_QUALCOMM or rmnet should not be.

Justin