Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Jul 2023 16:27:37 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Justin Forbes <jforbes@fedoraproject.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency
Message-ID: <20230707162737.0a411b18@kernel.org>
In-Reply-To: <CAFxkdApnEo8RPOQ3zVjAZBeTtH2UbaT2798gQ5w0SA5e-dtZng@mail.gmail.com>
References: <20230706145154.2517870-1-jforbes@fedoraproject.org>
        <20230706084433.5fa44d4c@kernel.org>
        <CAFbkSA0wW-tQ_b_GF3z2JqtO4hc0c+1gcbcyTcgjYbQBsEYLyA@mail.gmail.com>
        <20230707151206.137d3a94@kernel.org>
        <CAFxkdApnEo8RPOQ3zVjAZBeTtH2UbaT2798gQ5w0SA5e-dtZng@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 7 Jul 2023 17:19:12 -0600 Justin Forbes wrote:
> they add an entry for it, and don't realize that the entry is ignored

Maybe that someone should not be "adding an entry" to a file which 
has this at the top:

#
# Automatically generated file; DO NOT EDIT.

?

> VENDOR_QUALCOMM is not enabled.  Either all devices capable of using
> rmnet should be hidden behind VENDOR_QUALCOMM or rmnet should not be.

I agree that Qualcomm drivers are an atrocious mess.
They should live neatly in the wwan section. But it's Qualcomm,
they don't care. Let's not have it sprawl even more.