Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32663225rwd; Fri, 7 Jul 2023 18:57:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlFoK8N0tjs9Il9PA9iM0t4Ux/wh1tGPqx25RP6Ie9LDJ/xnVACUHubrcU3SldaEdz0ymxJ1 X-Received: by 2002:a05:6a00:228a:b0:682:7d8a:f891 with SMTP id f10-20020a056a00228a00b006827d8af891mr7834607pfe.20.1688781450938; Fri, 07 Jul 2023 18:57:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688781450; cv=none; d=google.com; s=arc-20160816; b=bINbd0TDFRsNPiHudHg11oGhm5FP8RcrAfqFndahfEpcsfyhvXfZL0czbJOuMnYKSS j0P7eSSvIa9eXs4gjexGqESSvqBxJhTg5L2sf59ht7/jOmWYAy8rHeznDpU0gz4Us+k2 faCyzEEGiQio1nxJkM1HKhLtYyC/cc0fE/9+jvJcE87EMZGOeynPjl3I3aI0rWf3KCgO 6w77NpOiKWBNEeuWha5aq/0xX5k5AIWhWcAoACVnFeiaJ7DJAEcW9ohnhzZuTeh2Rkg5 CN2KIBJ+LRQa5KD8dl0S70ks5ufoh631lFe7DF6sFKQApDhih0apWmwFhYytoC72BdDf CYAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=gGHAfKCfeJfB76MjRKDpDrWWXgs2TtNTkwBPZgd+Gp8=; fh=7FDJYXw0kf2YWYrVui8AkyYg9HdMbs30crnruk6g7mU=; b=bTAhaGEmf+jRyL8tQnpWUSV8XR+cagxUGYM/ckI8Qw0XSXaNRd1B79p27HQcPRIige uZ1reH2Kl1ZvNhf/p1c7PPau72eqWHE68ramXgja300sMd69xbBObJh0CPE1/61YDqMm Sdbcz5JtHT2m55wldb/SIx7xADbzFpsriJ2jqSuy2rSGWeo/5ZpmRclWteG9p3tz0ljr fnpSFjC/euE4cjuKxaPz1BOJrWkoMjW9MI14S3riJRTyqB8k82/g/ZB2Mf4Jsl/U2mv5 HF39JvI5VV4PNhyMwWIIryeaPSI/R9AD9fS8qgrCdIau9/mP03fXDYtdX5rzHcERxe4F MDlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=j6vA5LBm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n37-20020a635c65000000b0055be61476b4si4776133pgm.288.2023.07.07.18.57.18; Fri, 07 Jul 2023 18:57:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=j6vA5LBm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232770AbjGHBZX (ORCPT + 99 others); Fri, 7 Jul 2023 21:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbjGHBZL (ORCPT ); Fri, 7 Jul 2023 21:25:11 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06ECF1999; Fri, 7 Jul 2023 18:25:10 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3681K0La006492; Sat, 8 Jul 2023 01:24:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : date : subject : mime-version : content-type : content-transfer-encoding : message-id : references : in-reply-to : to : cc; s=qcppdkim1; bh=gGHAfKCfeJfB76MjRKDpDrWWXgs2TtNTkwBPZgd+Gp8=; b=j6vA5LBmSTzcVC8+WVp8THJttxA2/uMswcOKIF9DPzjygzOAARzixo4ADSsyGopcJjhC mSeR0UqWp+4B7LGRuTSE/AOiwjsv1ETg9xSysNWdlKYAw4wmexTkYY2fIkiUN0L7VWa9 2S+5OZVnQJ3iemJPkEYWmX6/iHbuaDdBeAlt0AHXdnYBANZKJtXYMeHT1xy96WPvVmQb unY5hsI0xupicybs/SQmy1+0E8Is0lqRdIGuNEQHrLrWOBRSse5MBYKJw5YZVqzghkif LW8j5j+2j7FPsMzfiFxfYHGvCVMBcW9JvAQQOWhJ1i4v0pHSRQSATcZAaXJjHRNCZFys Ow== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rp96vtt8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 Jul 2023 01:24:58 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3681Ovvb013453 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 8 Jul 2023 01:24:57 GMT Received: from hu-rmccann-lv.qualcomm.com (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 7 Jul 2023 18:24:57 -0700 From: Ryan McCann Date: Fri, 7 Jul 2023 18:24:42 -0700 Subject: [PATCH v5 3/6] drm/msm/dpu: Define names for unnamed sblks MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20230622-devcoredump_patch-v5-3-67e8b66c4723@quicinc.com> References: <20230622-devcoredump_patch-v5-0-67e8b66c4723@quicinc.com> In-Reply-To: <20230622-devcoredump_patch-v5-0-67e8b66c4723@quicinc.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter CC: Rob Clark , , , , , , Ryan McCann X-Mailer: b4 0.13-dev-8a804 X-Developer-Signature: v=1; a=ed25519-sha256; t=1688779496; l=3178; i=quic_rmccann@quicinc.com; s=20230622; h=from:subject:message-id; bh=8uqN88NSiqkEAYRrWOmUQw7N7ik+O7fGkiC9MrwAEGo=; b=iwzoySSdX5d4qdy4YJzMptdCORVI1n94oalpLqfsw9AeSFDREM9MTfKqrKBNi+TKEnD6fsEUt CGcZyl0FqBzAtYtUSWAmU5rd7XTf20Xpw615GXMNJhNh9vO4AECQsgR X-Developer-Key: i=quic_rmccann@quicinc.com; a=ed25519; pk=d/uP3OwPGpj/bTtiHvV1RBZ2S6q4AL6j1+A5y+dmbTI= X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: IY7Sb1BCvUBHRxqm0dqTwZ5UDogMDQj9 X-Proofpoint-GUID: IY7Sb1BCvUBHRxqm0dqTwZ5UDogMDQj9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-07_16,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=927 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307080011 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some sub-blocks in the hw catalog have not been given a name, so when the registers from that block are dumped, there is no name to reference. Define names for relevant sub-blocks to fix this. Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Ryan McCann --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 1291251e4c90..e2879cc84ee0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -444,12 +444,12 @@ static const struct dpu_lm_sub_blks qcm2290_lm_sblk = { * DSPP sub blocks config *************************************************************/ static const struct dpu_dspp_sub_blks msm8998_dspp_sblk = { - .pcc = {.id = DPU_DSPP_PCC, .base = 0x1700, + .pcc = {.name = "pcc", .id = DPU_DSPP_PCC, .base = 0x1700, .len = 0x90, .version = 0x10007}, }; static const struct dpu_dspp_sub_blks sm8150_dspp_sblk = { - .pcc = {.id = DPU_DSPP_PCC, .base = 0x1700, + .pcc = {.name = "pcc", .id = DPU_DSPP_PCC, .base = 0x1700, .len = 0x90, .version = 0x40000}, }; @@ -465,19 +465,19 @@ static const struct dpu_dspp_sub_blks sm8150_dspp_sblk = { * PINGPONG sub blocks config *************************************************************/ static const struct dpu_pingpong_sub_blks sdm845_pp_sblk_te = { - .te2 = {.id = DPU_PINGPONG_TE2, .base = 0x2000, .len = 0x0, + .te2 = {.name = "te2", .id = DPU_PINGPONG_TE2, .base = 0x2000, .len = 0x0, .version = 0x1}, - .dither = {.id = DPU_PINGPONG_DITHER, .base = 0x30e0, + .dither = {.name = "dither", .id = DPU_PINGPONG_DITHER, .base = 0x30e0, .len = 0x20, .version = 0x10000}, }; static const struct dpu_pingpong_sub_blks sdm845_pp_sblk = { - .dither = {.id = DPU_PINGPONG_DITHER, .base = 0x30e0, + .dither = {.name = "dither", .id = DPU_PINGPONG_DITHER, .base = 0x30e0, .len = 0x20, .version = 0x10000}, }; static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = { - .dither = {.id = DPU_PINGPONG_DITHER, .base = 0xe0, + .dither = {.name = "dither", .id = DPU_PINGPONG_DITHER, .base = 0xe0, .len = 0x20, .version = 0x20000}, }; @@ -517,13 +517,13 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = { * DSC sub blocks config *************************************************************/ static const struct dpu_dsc_sub_blks dsc_sblk_0 = { - .enc = {.base = 0x100, .len = 0x9c}, - .ctl = {.base = 0xF00, .len = 0x10}, + .enc = {.name = "enc", .base = 0x100, .len = 0x9c}, + .ctl = {.name = "ctl", .base = 0xF00, .len = 0x10}, }; static const struct dpu_dsc_sub_blks dsc_sblk_1 = { - .enc = {.base = 0x200, .len = 0x9c}, - .ctl = {.base = 0xF80, .len = 0x10}, + .enc = {.name = "enc", .base = 0x200, .len = 0x9c}, + .ctl = {.name = "ctl", .base = 0xF80, .len = 0x10}, }; #define DSC_BLK(_name, _id, _base, _features) \ -- 2.25.1