Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp32689675rwd; Fri, 7 Jul 2023 19:37:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlGt0CCQQutH6stVZbP1m96iQpkepPT4l3wLaKKvhddruLwDts5iWeUhteUNOXJvK3qC4M6U X-Received: by 2002:a17:906:104e:b0:993:d6e8:2389 with SMTP id j14-20020a170906104e00b00993d6e82389mr2191495ejj.26.1688783838457; Fri, 07 Jul 2023 19:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688783838; cv=none; d=google.com; s=arc-20160816; b=ANqMIXMsT6DluuDkV8Qwy7M8ScIFfK5QyqVY0QIwfkZ3IoUvN0zu5giX3oLqlNNWO8 F/phg95lzBTV+oUhm8E1FnHfBeeMTeO12wDOh2L1W22FPHb/LH8z33IURd7P8jG523gP uUnW7CgP4gmVG4NeRquCwhztT35YOpwuof5e/gu7Mlm55y+IHPRR/NLj78i3Ha/DsyYO Ee16cNVMzvxVBTIOwoUslQalWtJLlu92bxhj1Sv/8rKfopwjWJOcHlvsOBe80sUUtFSI RwXaWjyZgEuInLknyIsBsPrVUV+PKWBW2dUwAiv9Z+LKmrdRx1eAIjwSRTzxqm2q9my0 JOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=eeUH/nmI79dOUPcJ3kTAppnbqbmbdI0HKLu5luMdeQU=; fh=N7MpUiJCyOb8l80VsCWVqK2KP/gKI68rdN/umZcGLrY=; b=D6IgeDocOytkwqugMOZrDoQg6gddp9sDiH4pr2EHqYlzrI5QTKNjsHe3U/DaKoQsCr jTN6cPvGS8vdNsx03fLwBCNC+C78GdLvfCyYlg7OiaK0WCaCtqkEo8HPf68QD7crOua4 LazardMIrh6qY5JBs1vDzJPPm74wUSc1EKoxph8U9/S4GVkfjERM1l7ye8mQulMEC5Ya jP1lGm0xjoaLA8MyrKLV6zb8cRNJRFWDcuMq6WobLBuYglc0QX/0extH9JY4Ce+cWmAb ILWD9N6gImZN1m3UJQqgBieZ4/5hlyd+TLeDEMNoYwKPlQf+gTm69ja/tbLbctvd3/ga AOnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ly066dcu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k9-20020a170906680900b00987c203c563si2772839ejr.182.2023.07.07.19.36.55; Fri, 07 Jul 2023 19:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ly066dcu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231909AbjGHB6o (ORCPT + 99 others); Fri, 7 Jul 2023 21:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbjGHB6n (ORCPT ); Fri, 7 Jul 2023 21:58:43 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F272AC3; Fri, 7 Jul 2023 18:58:42 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3681ta4t004076; Sat, 8 Jul 2023 01:58:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=eeUH/nmI79dOUPcJ3kTAppnbqbmbdI0HKLu5luMdeQU=; b=ly066dcuTkyieJr7nN3K3uoAXh5jzm5Pzb03a8d3srjYaeNJa+wLwWNmi9v6MJGS4LHD alEolXRFinqEIoNIWQY8xEonYaVzOTyniHHZSLutY/ZpvIKlekJ2Hb2cRECSh5NdfAyU EDkhI1EjNv7nMDef0w2Pn4qtoo4Is61zRMKdPJJjkFG/pNjzxC/aUt145qhSicEuvv/t 159BAL7EU+tHv8mVWHppNaXXqkTfz42daKh3KimmgljeyoHw3OMLIRdkA1UDGzGIXTGW JwZBnqsHOpF8VBMvN6z7rETeMU+hfY3y0AZefsUgBCVgyIEzD2txS+h1VORi9DSAtGVe 9Q== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rp96vtu8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 Jul 2023 01:58:33 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3681wWcT005966 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 8 Jul 2023 01:58:32 GMT Received: from [10.110.118.168] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 7 Jul 2023 18:58:31 -0700 Message-ID: Date: Fri, 7 Jul 2023 18:58:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 6/6] drm/msm/dpu: Update dev core dump to dump registers of sub-blocks Content-Language: en-US To: Ryan McCann , Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter CC: Rob Clark , , , , , References: <20230622-devcoredump_patch-v5-0-67e8b66c4723@quicinc.com> <20230622-devcoredump_patch-v5-6-67e8b66c4723@quicinc.com> From: Abhinav Kumar In-Reply-To: <20230622-devcoredump_patch-v5-6-67e8b66c4723@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: pVFZQNw9QnFT27OSd45KGo_UqMwL-3bS X-Proofpoint-GUID: pVFZQNw9QnFT27OSd45KGo_UqMwL-3bS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-07_16,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=940 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307080016 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/2023 6:24 PM, Ryan McCann wrote: > Currently, the device core dump mechanism does not dump registers of > sub-blocks within the DSPP, SSPP, DSC, and PINGPONG blocks. Edit > dpu_kms_mdp_snapshot function to account for sub-blocks. > > Signed-off-by: Ryan McCann > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 66 +++++++++++++++++++++++++++------ > 1 file changed, 54 insertions(+), 12 deletions(-) > Overall, I like this one. Reviewed-by: Abhinav Kumar