Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230707165221.4076590-1-fengwei.yin@intel.com> <20230707165221.4076590-2-fengwei.yin@intel.com>
In-Reply-To: <20230707165221.4076590-2-fengwei.yin@intel.com>
From:   Yu Zhao <yuzhao@google.com>
Date:   Fri, 7 Jul 2023 23:47:56 -0600
Message-ID: <CAOUHufb=f1KUyXFGm7XjXJu8sp+pYrhUreiTe=ypqMnJbgwGKg@mail.gmail.com>
Subject: Re: [RFC PATCH 1/3] mm: add function folio_in_range()
To:     Yin Fengwei <fengwei.yin@intel.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        ryan.roberts@arm.com, shy828301@gmail.com,
        akpm@linux-foundation.org, willy@infradead.org, david@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 7, 2023 at 10:52=E2=80=AFAM Yin Fengwei <fengwei.yin@intel.com>=
 wrote:
>
> It will be used to check whether the folio is mapped to specific
> VMA and whether the mapping address of folio is in the range.
>
> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
> ---
>  mm/internal.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/mm/internal.h b/mm/internal.h
> index f1276d90484ad..66117523d7d71 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -585,6 +585,32 @@ extern long faultin_vma_page_range(struct vm_area_st=
ruct *vma,
>                                    bool write, int *locked);
>  extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags,
>                                unsigned long bytes);
> +
> +static inline bool
> +folio_in_range(struct folio *folio, struct vm_area_struct *vma,
> +               unsigned long start, unsigned long end)

Is there a caller that's not "folio_in_range(folio, vma,
vma->vm_start, vma->vm_end)"?

If not, then just "folio_within_vma(folio, vma)" or a wrapper on top
of  folio_in_range().