Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp33072070rwd; Sat, 8 Jul 2023 04:50:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlGMfDIm3KdwcS+VTf4BBg3hn2sWPvHQsjaQPvlzDjAFCFoZJZdc1Cl+uttHuVFs2iQRuWou X-Received: by 2002:a17:907:1b1d:b0:98e:1729:aeee with SMTP id mp29-20020a1709071b1d00b0098e1729aeeemr10457175ejc.2.1688817040882; Sat, 08 Jul 2023 04:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688817040; cv=none; d=google.com; s=arc-20160816; b=k14CmkbsdKMEw17H7qPHC+w4UIQSoP17CB5n5esWpbiUfE2TC/NtTPEG7yCbokGURq PJONIdkmrLi7ljXni78vtwnGy5LvLxAwJVNPpNQGbb3Cwb7Y4weOmekYvnjFdJX5SrD+ 2yVV/KiRrkvbSQfHqO4FN0MqSj41LKJnAV/GTAZmmOh+lC8bKHpDU3Qg5vxNz7spPZtN 1qvjyh4+b5FwKq06xl9/FU2XMSfs7szRLgJ5oU9qYHp+G/+Hiu9+FXXnm5vNHsYpi48T 1V1j2HBeYc/wRB0UCghCP13GQkRKhnCNJ7l6IVpv7mtaFz75S5eo7XCqfk5IBLjykXXI SsEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uATCbfvIE9rINaAg/s7eZTuS1qSF295zfe+fVz6pU5M=; fh=fstfkBR1O/TWEoNxe/ETUdiZwINFahnXj/TUajPMdik=; b=ZfFdMDGYsxRtGsNO3mz5E+X2EjSD9bqyLwLeCx1eFESiauEIeHGM20/mYmxNjNMvsd yF44PYyU6ixKXisMu8c8ANpy5sEUV9yZujEYdvSE/wbPbgHgmWdWtRtks7Fe1epEM+8F yVUEd70VEu0oiFCzt3w9gEmmgCyQkm0cvGfqvflZbV2l5xTWvXiGTYHqScwZKAmZH/yd BgQAzWMJBv8MK8WZkP9kSz6uYm9XMfG85ZA9wSNmQj06TaCPV6fALcSn9sfu0X3lFPqq S0taNR7y/tIJHMBxTMXg+oUErVM/hk2fSG7vZ3mhGrfTbpJKn5EbfWno5bg5cpHD6W2h 9bOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=byUOD5YF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a170906198700b00992be03096dsi3005175ejd.846.2023.07.08.04.50.08; Sat, 08 Jul 2023 04:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=byUOD5YF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbjGHLKg (ORCPT + 99 others); Sat, 8 Jul 2023 07:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbjGHLKf (ORCPT ); Sat, 8 Jul 2023 07:10:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9EA129; Sat, 8 Jul 2023 04:10:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3784260B35; Sat, 8 Jul 2023 11:10:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E825C433C7; Sat, 8 Jul 2023 11:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688814632; bh=/eagb1g41jlYbYNVD/k/nT4mBSx2guvjO7rd3V9z7Oo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=byUOD5YF14hpBIR0uIdMKA8jpGyLsxjhCpB/SrabkT5MPGLXrLxxLjNWghMzp6SwO GcTxBXHYzF9s/JAuahyxdqIAODFbtj47Law+AHbkjCMFNNAu5maaINvndsogHkBlwI sTAtI7oRolezDqz+MO7jjLpMx571EC5iP/5rETaA= Date: Sat, 8 Jul 2023 13:10:29 +0200 From: Greg Kroah-Hartman To: Madhumitha Prabakaran Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: Re: [PATCH] Add struct ad9832_platform_data to the include/linux/iio Message-ID: <2023070858-brewing-outpour-764c@gregkh> References: <20230707211553.GA110890@madhu-kernel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707211553.GA110890@madhu-kernel> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 07, 2023 at 04:15:53PM -0500, Madhumitha Prabakaran wrote: > Add struct ad9832_platform_data to the include/linux/iio > for maintaining code organization and clarity. > > Signed-off-by: Madhumitha Prabakaran > --- > drivers/staging/iio/frequency/ad9832.c | 3 +-- > drivers/staging/iio/frequency/ad9832.h | 34 -------------------------- > include/linux/iio/frequency/ad9832.h | 30 +++++++++++++++++++++++ No, not yet, sorry. Staging drivers should be self-contained, why does this .c file need a .h file at all anyway? It should all just be in the .c file, can you do that instead? thanks, greg k-h