Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp33154534rwd; Sat, 8 Jul 2023 06:14:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlFdVcg8OPMe9G2g+iUGiehBBFUzX3HgFg6k1bfeKs8Fwylk4ZLOFmmKY1VdBnDBd2bHqQ3+ X-Received: by 2002:a05:6512:4014:b0:4fb:a0ec:983f with SMTP id br20-20020a056512401400b004fba0ec983fmr6842369lfb.14.1688822083438; Sat, 08 Jul 2023 06:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688822083; cv=none; d=google.com; s=arc-20160816; b=tW6288vv1/KoB83r7EDK13ftXiGYZBOB8RCeHGpZgdJtV9cnqBAyE0+PTPbeCPqs/N qzgnXJZ+7Mhujb93oxkNJggkgJjWaDlZh8UVBZbR/M+V4IepabTWaNpL+H1INSRrIkqe IbbjBFTrb4SkVJeXtLlgwMNbHijJEZGEA863ZoausDoV9vl7wWbH0ZJp6t02nfKfi/ay bKXgxAnlX71saK9Y0ZHeGVPlJBxiqOCRX2c3bUttqpsZmp5C5FI63CefCHJ5GP4RK2XF 7gmsI12qdb2u3K/Sb1n2eqOFzHCeq0wEaYWdc0aXSVU65DBxbSAvKhHxbAyh4ITKXXY6 JUsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Hi8xZv3kp+ZMXDHujeHE4MCbxE/IeD639P+0kPjf6lQ=; fh=mgB2PlfxbNLD3XICsnoABf9D4Q4PTlffobpCOgsooaI=; b=R8sJYCo9XMuvt3fzwyKtpiQhWo7+u7GooHlSAyySxyqoVpeNGotMzWOz8b7tjYDFeh /uTW5QJlmsezxE37iR3HbF6OJu7X9X7NgPcDdXj+PTEk/lo4fRybLct7ZZt4o3SOk7HA 6RViVMdObS4xBVS2TMxP05DIdcyb9iva7ghdKQsaXK2EGDTi9QtWfWnzt8lqeJg5vkez zjn2jXMlzvBXHL6dMlm/wR4voilNDOCNvX0lLj4j7n7k3LJk+of/rWDQ5z30x6gIR6MN bG6T8dZT6TKXptGVEI+skQJUMXFqFCRyzXcs7zvbwz27IAqexfeAiwFE15+kchKVRjl7 WfGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="Bb20ypz/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n21-20020aa7d055000000b0051df52aa65bsi3610876edo.155.2023.07.08.06.14.18; Sat, 08 Jul 2023 06:14:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="Bb20ypz/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbjGHMcf (ORCPT + 99 others); Sat, 8 Jul 2023 08:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbjGHMce (ORCPT ); Sat, 8 Jul 2023 08:32:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC1B10FF for ; Sat, 8 Jul 2023 05:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Hi8xZv3kp+ZMXDHujeHE4MCbxE/IeD639P+0kPjf6lQ=; b=Bb20ypz/EKXowf/2x3o84ZThQF c6W5aqRCw9gSxDWAGgd8f29Dq6Y8+N7QZPcE/nyFnUe3hf1BnclGqC7h4DuY4byvnSQGiL+4avXn5 YRz27j8igvtdDe7fxyD/dYOd1o2jc3UNqVK9UZ+7cNYTwEbmnNKLlF/UmCSDni7Gcobx/Eo9o/ORp KJI031XpDVhGMgmni02Kzcicohov5Y6p9VRuPl6KpTtjwydjQvO2C8Ty2mLFyfeGenjF5X5rT3KVj TwwVTyBCxjIHfHUWZ0UgPPffpZCI7iZrRmOON6cBwoRhIWeObQuWyfsdYy9y6BBk66OZaiEWhceKH fwb1NjBg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qI76D-00Ct0m-2S; Sat, 08 Jul 2023 12:31:41 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CFC7D300222; Sat, 8 Jul 2023 14:31:37 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B158224B8B4FF; Sat, 8 Jul 2023 14:31:37 +0200 (CEST) Date: Sat, 8 Jul 2023 14:31:37 +0200 From: Peter Zijlstra To: Tim Chen Cc: Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V . Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J . Wysocki" , Srinivas Pandruvada , Steven Rostedt , Valentin Schneider , Ionela Voinescu , x86@kernel.org, linux-kernel@vger.kernel.org, Shrikanth Hegde , Srikar Dronamraju , naveen.n.rao@linux.vnet.ibm.com, Yicong Yang , Barry Song , Chen Yu , Hillf Danton , Ricardo Neri Subject: Re: [Patch v3 5/6] sched/x86: Add cluster topology to hybrid CPU Message-ID: <20230708123137.GB2934075@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 07, 2023 at 03:57:04PM -0700, Tim Chen wrote: > From: Tim C Chen > > Cluster topology was not enabled on hybrid x86 CPU as load balance > was not properly working for cluster domain. That has been fixed and > cluster domain can be enabled for hybrid CPU. > > Reviewed-by: Ricardo Neri > Signed-off-by: Tim Chen Yeah, you didn't actually try appling this to something recent did ya :-) You missed 8f2d6c41e5a6 ("x86/sched: Rewrite topology setup"). I'll replace this patch with the below. --- arch/x86/kernel/smpboot.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index ed2d51960a7d..3b751d79cdfb 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -632,14 +632,9 @@ static void __init build_sched_topology(void) }; #endif #ifdef CONFIG_SCHED_CLUSTER - /* - * For now, skip the cluster domain on Hybrid. - */ - if (!cpu_feature_enabled(X86_FEATURE_HYBRID_CPU)) { - x86_topology[i++] = (struct sched_domain_topology_level){ - cpu_clustergroup_mask, x86_cluster_flags, SD_INIT_NAME(CLS) - }; - } + x86_topology[i++] = (struct sched_domain_topology_level){ + cpu_clustergroup_mask, x86_cluster_flags, SD_INIT_NAME(CLS) + }; #endif #ifdef CONFIG_SCHED_MC x86_topology[i++] = (struct sched_domain_topology_level){