Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp33159390rwd; Sat, 8 Jul 2023 06:19:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlEywnKTDjwZRaF3OyHA+l+2uJi1dmZ2C6VD/h0/ROonKjEIbU7W0ufulHN9j7xGH81XHVpl X-Received: by 2002:a17:903:1246:b0:1b8:17e8:5475 with SMTP id u6-20020a170903124600b001b817e85475mr7066127plh.24.1688822347815; Sat, 08 Jul 2023 06:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688822347; cv=none; d=google.com; s=arc-20160816; b=xk12vXd4DsLo1jwJkJrLB5DrBQjHuQpwAyn+D6lepqflzBPpLbpLeB/gZ/U2M+lEtv ozV0EfNfGcnwv0p+UUEdKyUt+SmFwCNApNOPh836UyoAU7cxdurQbMZhxQavw+UxSRb4 NOD3qVvDAUCmiIoIWuQb6Dv8SWXAqKjeyF8/KB4ynBu5BOIwJgZEwdRFlkIwZBjE8WA7 AqAoxabrUtOQR7eA+0QhqF+/DEskqVwv6uZo/XrO1G3Vi7uKgYgQUwviNYNkkHU4LmXA SonA62NkeSHsaVSJ1ILLoo8YHJgS28Ywd16fbSnBtsV93wZQdCSOxwRiHoOX+087/imq tV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=IvddLfxwhrH7kTVtfgBFgKokYGybU9LtMq+/etkdvbI=; fh=19RLv47QoqdphjioQxpxpZb3gI6SjNcfuVJi4VLbSDo=; b=b9GwbI0sK1CQo9GEerQEQnAjy/CQbP/YDgH99IYpuWV35uCDsJ5+P/Dt/65G4/Cr8E Iwe1LVvn/66a4NBqX9HvH65/+KgI4Q8elMyNBL1WfS090p3cPIS+iMC5yRbloUt2JRdl FDhdwV3eo+EqOB638xp++17UtAk8cDsiNzduzYa3mL9MxqhdleEBGs/BpxFCdKJmbomt K3LTHTjXVFLXuSyxDpNm/4u7ul3+RJdDY2P4VI8k/kTqCJlltG82zY3O2/BB+jnpEJRG rZZWc/9BgKMTUm2eiV6+8x9fhjeNyPmShawkyjDrX3rheAkQKsitaNAgA7M77rIXuXnz MVSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b="NHqRydq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j3-20020a655583000000b0055b766191f4si5721389pgs.218.2023.07.08.06.18.54; Sat, 08 Jul 2023 06:19:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b="NHqRydq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=denx.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbjGHMxH (ORCPT + 99 others); Sat, 8 Jul 2023 08:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbjGHMxG (ORCPT ); Sat, 8 Jul 2023 08:53:06 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 997C41737; Sat, 8 Jul 2023 05:53:04 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id CB1F0861A1; Sat, 8 Jul 2023 14:53:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1688820782; bh=IvddLfxwhrH7kTVtfgBFgKokYGybU9LtMq+/etkdvbI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NHqRydq/3DWpKNfzIpfw3UKozdmCaMiozNFilkMiJMlziIeTSdMqOTMJ2cQw14JKI ruGev34X1eYWi8FvOyvKSOPUidKLzZL63NBpXZ8YMMRoD/bG12sF7vF2+PeFszVewa WIAsD7sgfn/VbOL4miCL8falHNw9TI+1Z5BBy2tW/oIzOOTOzpe9OrkyiNuV9rqmm0 6ORny8Uo/MywvdnVktK+h6squ6maxI4NBwr+B4HWjQNhilCSlTngNB/8ir03B90ami PjWd/c53V7RmBPTSCi5WJGnu7QPEVyB+6oJcmTMDOvnk+2yc21FQwAYYoWGczGNQCl xF0GxvbOw2lMw== Message-ID: Date: Sat, 8 Jul 2023 14:52:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] thermal: imx8mm: suppress log message on probe deferral To: Ahmad Fatoum , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230708112647.2897294-1-a.fatoum@pengutronix.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <20230708112647.2897294-1-a.fatoum@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/8/23 13:26, Ahmad Fatoum wrote: > nvmem_cell_read_u32() may return -EPROBE_DEFER if NVMEM supplier has not > yet been probed. Future reprobe may succeed, so printing: > > i.mx8mm_thermal 30260000.tmu: Failed to read OCOTP nvmem cell (-517). > > to the log is confusing. Fix this by using dev_err_probe. This also > elevates the message from warning to error, which is more correct: The > log message is only ever printed in probe error path and probe aborts > afterwards, so it really warrants an error-level message. > > Fixes: 403291648823 ("thermal/drivers/imx: Add support for loading calibration data from OCOTP") > Signed-off-by: Ahmad Fatoum Reviewed-by: Marek Vasut Thanks