Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] sh: Avoid using IRQ0 on SH3 and SH4
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Guenter Roeck <linux@roeck-us.net>
CC:     Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>, <linux-sh@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <fbfea3ad-d327-4ad5-ac9c-648c7ca3fe1f@roeck-us.net>
 <544f02b696a0a1554efe63f799754f3e5fbfecdc.camel@physik.fu-berlin.de>
 <b75efe15-e679-2557-253a-0cc82ff8f926@omp.ru>
Organization: Open Mobile Platform
Message-ID: <6e65fc43-0fea-055f-791d-2201ddb75883@omp.ru>
Date:   Sat, 8 Jul 2023 23:43:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <b75efe15-e679-2557-253a-0cc82ff8f926@omp.ru>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/8/23 11:35 PM, Sergey Shtylyov wrote:
[...]

>>> On Thu, Jun 01, 2023 at 11:22:17PM +0300, Sergey Shtylyov wrote:
>>>> IRQ0 is no longer returned by platform_get_irq() and its ilk -- they now
>>>> return -EINVAL instead.  However, the kernel code supporting SH3/4-based
>>>> SoCs still maps the IRQ #s starting at 0 -- modify that code to start the
>>>> IRQ #s from 16 instead.
>>>>
>>>> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they
>>>> indeed are using IRQ0 for the SMSC911x compatible Ethernet chip.
>>>>
>>>
>>> Unfortunately it also affects all sh4 emulations in qemu, and results in
>>> boot stalls with those. There isn't a relevant log to attach because there
>>> is no error message - booting just stalls until the emulation is aborted.
>>>
>>> Reverting this patch fixes the problem.
>>>
>>> Bisect log is attached for reference. Note that bisect requires applying
>>> commit 7497840d462c ("sh: Provide unxlate_dev_mem_ptr() in asm/io.h"),
>>> which is also the reason why the problem was not observed earlier since
>>> it was hiding behind a build failure.
>>
>> Interesting. My naive understanding was that IRQ0 is no longer usable in the
>> kernel as Sergey claimed. Was that not correct?
> 
>     According to Linus, using IRQ0 should only be allowed in the arch/ code
> (usually the i8253 driver). As for the platform devices, this have been finally
> enforced by this patch.

   Sorry, I meant *that* patch:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289

>> Adrian

MBR, Sergey