Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230707042644.94061-1-namhyung@kernel.org> <CAHk-=wgRP0qeuTSWtHgDdvgUTfBD1mGwrenbOyJC7_ygsbWCEQ@mail.gmail.com>
In-Reply-To: <CAHk-=wgRP0qeuTSWtHgDdvgUTfBD1mGwrenbOyJC7_ygsbWCEQ@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 8 Jul 2023 20:23:25 -0700
Message-ID: <CAM9d7cjvowtUcfew12k7oLs6g19FHZipcQ9UsX9pOKXENeGEYw@mail.gmail.com>
Subject: Re: [GIT PULL] perf tools changes for v6.5: 2nd batch
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Linus,

On Sat, Jul 8, 2023 at 12:16 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, 6 Jul 2023 at 21:26, Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > Hello Linus,
> >
> > Please consider pulling more perf tool changes.  These are remaining
> > changes and fixes for this cycle.  The last two fixes are relatively
> > new but other changes have been sitting on -next for a number of days.
>
> Hmm.
>
> I htink there's some dependency problem in the perf tools build that
> just caused a random build error for me:
>
>    util/expr-flex.c:214: error: unterminated #ifdef
>
> that error went away on a re-build, and it's clearly nonsensical when
> I look at that file, so it looks to me like somehow the parallel buld
> used that file while it 3as being generated.
>
> I don't see anything obviously wrong, and I've only seen this error
> once. I've done the pull - I doubt it was introduced by the recent
> changes - but I wanted to just mention that there seems to be some
> problem in this area..
>
> Am I the only one to have ever seen something like this?

I saw a similar problem before and it was ok after a re-build.
I also believe it's not related to this pull request.  But I will
take a deeper look at the problem.

Thanks,
Namhyung