Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbXJWXeS (ORCPT ); Tue, 23 Oct 2007 19:34:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752597AbXJWXeJ (ORCPT ); Tue, 23 Oct 2007 19:34:09 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:48844 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbXJWXeI (ORCPT ); Tue, 23 Oct 2007 19:34:08 -0400 X-Sasl-enc: qR28FD0gY0elZ3sUM6/OWU7Yj9kM2HthWDLVQEM0SkFy 1193182446 Date: Tue, 23 Oct 2007 21:34:03 -0200 From: Henrique de Moraes Holschuh To: Dmitry Torokhov Cc: Matthew Garrett , Linus Torvalds , Jeremy Katz , linux-kernel@vger.kernel.org, davej@redhat.com Subject: Re: [PATCH] Map volume and brightness events on thinkpads Message-ID: <20071023233403.GD8224@khazad-dum.debian.net> References: <20071017162827.GA9778@srcf.ucam.org> <20071017173532.GB2974@khazad-dum.debian.net> <20071017204250.GA13377@khazad-dum.debian.net> <20071018223915.GA4483@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 22 On Tue, 23 Oct 2007, Dmitry Torokhov wrote: > in question. Probably simply adding separate key notify events (such > as KEY_BRIGHTNESSUP_NOTIFY) to EV_KEY instead of creating EV_NOTIFY is > not such a bad idea - this way we can fix keymap from userspace (if > needed) instead of needing to modify the krenel. That is a killer argument for EV_KEY over EV_NOTIFY if I have ever seen one. > So, EV_KEY (and extending KEY_MAX to 1024) or EV_NOTIFY? EV_KEY, please. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/