Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 9 Jul 2023 10:56:13 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Kristina Martsenko <kristina.martsenko@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>, will@kernel.org,
        james.morse@arm.com, mark.rutland@arm.com, amit.kachhap@arm.com,
        maz@kernel.org, anshuman.khandual@arm.com, joey.gouly@arm.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 07/12] arm64: cpufeature: detect FEAT_HCX
Message-ID: <ZKrKjS7sDFxhKoJT@sashalap>
References: <20230702195057.1787686-1-sashal@kernel.org>
 <20230702195057.1787686-7-sashal@kernel.org>
 <b37a9f79-97a8-4f74-a25c-b51128fbc9bb@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <b37a9f79-97a8-4f74-a25c-b51128fbc9bb@sirena.org.uk>
Precedence: bulk

On Mon, Jul 03, 2023 at 12:51:57PM +0100, Mark Brown wrote:
>On Sun, Jul 02, 2023 at 03:50:52PM -0400, Sasha Levin wrote:
>> From: Kristina Martsenko <kristina.martsenko@arm.com>
>>
>> [ Upstream commit b0c756fe996ac930033882ca56410639e5cad1ec ]
>>
>> Detect if the system has the new HCRX_EL2 register added in ARMv8.7/9.2,
>> so that subsequent patches can check for its presence.
>>
>> KVM currently relies on the register being present on all CPUs (or
>> none), so the kernel will panic if that is not the case. Fortunately no
>> such systems currently exist, but this can be revisited if they appear.
>> Note that the kernel will not panic if CONFIG_KVM is disabled.
>
>This is a new feature, it's not clear why we'd backport it (especially
>since it's a new feature which is a dependency for other features rather
>than something that people can use outside of the kernel)?

The second paragraph (above) suggested it should be.

-- 
Thanks,
Sasha