Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <tencent_513E2ED35A17B9569C91CF75664724C7620A@qq.com> <d60c850cbfa5a25fcf97eef724f5b701@208suo.com>
In-Reply-To: <d60c850cbfa5a25fcf97eef724f5b701@208suo.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 9 Jul 2023 21:14:27 +0300
Message-ID: <CAHp75VcbUOuQ9_2VL9mcs3e1x=ZOV5yd+c1U_iE24G5k-Uk7AA@mail.gmail.com>
Subject: Re: [PATCH] efi: x86: prefer 'unsigned int' to bare use of 'unsigned'
To:     xuanzhenggang001@208suo.com
Cc:     ardb@kernel.org, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org, dvhart@infradead.org,
        andy@infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jul 9, 2023 at 5:20=E2=80=AFAM <xuanzhenggang001@208suo.com> wrote:
>
> This patch fixes the following checkpatch warning:
> arch/x86/platform/efi/efi_64.c:109: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'
> arch/x86/platform/efi/efi_64.c:177: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'
> arch/x86/platform/efi/efi_64.c:182: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'

> -int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned
> num_pages)
> +int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned int
> num_pages)

Nice, but you shouldn't just blindly do some mechanic "fixes". Now
your patch makes differences between the function prototype and its
implementation.

--=20
With Best Regards,
Andy Shevchenko