Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp34486353rwd; Sun, 9 Jul 2023 13:09:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlGhfG6x8rC9nsAQlW/232WLsx8Y7UvQsFQhjeprWOXM9FlaYfW4gZ/hDmZ2Xr4LG5zm+bKN X-Received: by 2002:a17:906:4792:b0:991:d5ad:f1a7 with SMTP id cw18-20020a170906479200b00991d5adf1a7mr13153151ejc.51.1688933393014; Sun, 09 Jul 2023 13:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688933393; cv=none; d=google.com; s=arc-20160816; b=pENDDlo161O9IRkWfjWm84oHrvxht34D3FYvIoxsMOxS1wKGDQ8S7qlkOKziFqXm5S LJ2n/zvT2zHMdEl9iVEoQuf1y38YlNbmNWhlgKh1OBK6OnaQjow/KMR52T4MEeN7WYg+ rHbab20EeiivGuLXMND331skYP0O1vLHCc1aDgpwGnn8oM4d7O8idECxMCQdaxL81i3S eQc1ykzOu+ABFbfr9YXqjNugaSvzCJhnFPQRUKkgQnFiqRd4WG5js58pwIjxk6ZL0uGa EfwH3jYbf5VBvcDOy/f7EKzPkvVxjw5DjbxJkltnEIPiUOdBYuLOCq8Kx0wLiVoXgAtr Y9GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0pveTWgFRr5mN5v32TgV3qLTNvcCzrdqvG9KBp/LfDM=; fh=R8NnXs4mHtaAJyLePqbTp37LF/y+t4RBoB8dD4RG0Sc=; b=p5l3BMVxaqp6zqnsZtidmEkxEzMcCFvd0x5SlIuWJUcaMi+X60J54RvVsnWakn74nd K6YS/tbgNSEPSpstSYw/Ex5Ukor/SJ2AqnFPVZbg/Iba1PJX++y/2I9P4R3OO9ExhRQ2 MwqmWqcvjQFjrxYetzX3P1cNGNOf1vKwcWGMIeEn5O2vI3XmuQNGM0xiBseP+1nRzeOF EccSur52B3jA0359O3ZWyiSd7FYshXwT8X7k0elk7t05nK067FqOvnNCl9goDb1iPPVC Y1Vmd+SiYqL4KAG/zxofwyC2E28jGrJAvZS0NJRxnvnxX0FD1QIm3pniRSIVjMvJe1wz I9Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CKvxMWf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020a1709065e4200b00993a37afc87si3909462eju.919.2023.07.09.13.09.28; Sun, 09 Jul 2023 13:09:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CKvxMWf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjGIUGE (ORCPT + 99 others); Sun, 9 Jul 2023 16:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjGIUGC (ORCPT ); Sun, 9 Jul 2023 16:06:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56241FE; Sun, 9 Jul 2023 13:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0pveTWgFRr5mN5v32TgV3qLTNvcCzrdqvG9KBp/LfDM=; b=CKvxMWf1oJIhSQLDpLkOVg107b 8gXWkpndkDR6J484pKeK9yBY6PVCcnX9DT31gBUbv/3Oj1JzGoqZRA+Gm9qYPzoaJ0XQIO5LzyqPK thfGelT9Kdj9Tmn89+S+D2xa84QpAqrQSuSDPciNnd+2cbBKATfQzYVmPLHZ9uFPsZpqlO/H/bnN6 hKgcpXdx27TTyUJiTUEiDGidQN4dCRhDWbTdX/VY9IbFZxnuiSV5yM0Y8o4Zd9bJrZXydF/LHwa3P ELmkUJocCfn9vqzgWpC+MooCN1wWFdQT54RS9YMVvkHOnXBNGYW3DPZ5G3UX/KPkFCQcFGgCFfAXq s1LVW+jw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qIafF-00DyMr-3X; Sun, 09 Jul 2023 20:05:49 +0000 Date: Sun, 9 Jul 2023 21:05:49 +0100 From: Matthew Wilcox To: Markus Elfring Cc: Wen Yang , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alexander Viro , Christian Brauner , Jens Axboe , LKML , Christoph Hellwig , David Woodhouse , Dylan Yudaken Subject: Re: [PATCH] eventfd: avoid overflow to ULLONG_MAX when ctx->count is 0 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 09, 2023 at 09:13:28PM +0200, Markus Elfring wrote: > > For eventfd with flag EFD_SEMAPHORE, when its ctx->count is 0, calling > > eventfd_ctx_do_read will cause ctx->count to overflow to ULLONG_MAX. > > Please choose an imperative change suggestion. Markus, stop this nitpicking. It puts off contributors. The changelog is perfectly clear.