Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 9 Jul 2023 22:13:29 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Kristina Martsenko <kristina.martsenko@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>, will@kernel.org,
        james.morse@arm.com, mark.rutland@arm.com, amit.kachhap@arm.com,
        maz@kernel.org, anshuman.khandual@arm.com, joey.gouly@arm.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 07/12] arm64: cpufeature: detect FEAT_HCX
Message-ID: <ZKsi+UOdjlmDnhdj@finisterre.sirena.org.uk>
References: <20230702195057.1787686-1-sashal@kernel.org>
 <20230702195057.1787686-7-sashal@kernel.org>
 <b37a9f79-97a8-4f74-a25c-b51128fbc9bb@sirena.org.uk>
 <ZKrKjS7sDFxhKoJT@sashalap>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+qXkK1XcJkg4nect"
Content-Disposition: inline
In-Reply-To: <ZKrKjS7sDFxhKoJT@sashalap>
Precedence: bulk


--+qXkK1XcJkg4nect
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jul 09, 2023 at 10:56:13AM -0400, Sasha Levin wrote:
> On Mon, Jul 03, 2023 at 12:51:57PM +0100, Mark Brown wrote:
> > On Sun, Jul 02, 2023 at 03:50:52PM -0400, Sasha Levin wrote:

> > > KVM currently relies on the register being present on all CPUs (or
> > > none), so the kernel will panic if that is not the case. Fortunately no
> > > such systems currently exist, but this can be revisited if they appear.
> > > Note that the kernel will not panic if CONFIG_KVM is disabled.

> > This is a new feature, it's not clear why we'd backport it (especially
> > since it's a new feature which is a dependency for other features rather
> > than something that people can use outside of the kernel)?

> The second paragraph (above) suggested it should be.

That's saying that the code won't work properly on systems where some
but not all of the CPUs support the feature.  Note that the changelog
says nothing about fixing any issue here.

--+qXkK1XcJkg4nect
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSrIvgACgkQJNaLcl1U
h9AASgf/VUrMTlXCkMU4qomOSAYkBpeDf7op2KUSgZUUHu5rDYjCyxTgwqmtfnE2
+P4vQIovegrMJBKbupm80uqadBMfxS2kH/yT4BuIBzVTuuR9kSRZeuXaBTtXQxZc
Ha4rsOYJ3bXeoMkGLIJrS6UPUfULg406ccC39LFf1fOZd6YWG2iLM5Z2Z7+szL5D
AiYc6uOS3onLDcUGH/gpoxH5rGbzrFqvgxW9w90H9UgLIoZHFLrorKAuCG20vc7m
D6MMY+DrAiEGdOvpI7CCUPmXZAVpdceLYrAPaRAs5JBLIK0Q4OCWQNK0kjebqv8p
WQWjjUQ57C3uXR4IHyRid7q3EJ1w1Q==
=dQnC
-----END PGP SIGNATURE-----

--+qXkK1XcJkg4nect--