Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <dlemoal@kernel.org>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 09/11] ata: pata_ixp4xx: Remove unnecessary return value check
Date:   Mon, 10 Jul 2023 10:45:48 +0800
Message-Id: <20230710024550.59544-9-frank.li@vivo.com>
In-Reply-To: <20230710024550.59544-1-frank.li@vivo.com>
References: <20230710024550.59544-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N6V36n/1i4m8XNKUYrH7P2WIlTFQkmC6paWnnSIT4meoLwzDJi/ANFVruxmL?=
 =?us-ascii?Q?m8A3FT7ADy5zhzv0ouMwsVbzMTq3R9YJnN9AJ5HuviKOUiJnbuGN3SCXaPox?=
 =?us-ascii?Q?2515k3RmL5S3ycZf/xohEhHlauxljncJ84xAOMCJDyjbqNhExcTU72S3+OSe?=
 =?us-ascii?Q?mKI9ch4WQDd4N6YPBiR9xF/O70vwpZ58hHC7UjSUFQRFskd7CCCRFCW55BxT?=
 =?us-ascii?Q?cPCDUgoffKZmsj4T3nxhEnQvd8TZUO3utQlRw2fWTdcdj+coOdwRMemBR06n?=
 =?us-ascii?Q?eT8ZywOVTFBrONwoidPj/kQWuSgeaXskiDSl/SdpYx+1LNRIr3KfvD0kQXkh?=
 =?us-ascii?Q?meO9TPlo12znli97FyrQOiwtfKqq/xJIxOkJATl7XzqoCiqUydlBJrabLIrE?=
 =?us-ascii?Q?arodXKniOyN3b/Th/maklp/Cg1aSKnkvjwFQdTC2MxtKnbzJjQj//m0gsMUb?=
 =?us-ascii?Q?fsBSq68cAahiqdSyGQaRFdQrYXYAnkQGfw2Dcw2N2u6UMEx47iyVIABlrWdT?=
 =?us-ascii?Q?WDHoXXIqsw9uSz6jBmj9uGStmFRQOdSaAYDTFlAmLBg5VAISNv39gQsUmtZZ?=
 =?us-ascii?Q?i1pIUhqixsnwyuvpHcPF2KoP+9HIc+7F827EUwVG00Nf4KglNPZobARtuR1Z?=
 =?us-ascii?Q?HnFRQYwZ4RTPq4Uuha4UvnSiyiBsUJYRzp1JqwZnfx6s2GWn4UqEpm4Lnhml?=
 =?us-ascii?Q?856RDyrb18i3DCpT3yQEMa+nzfmHD7ghX8QU23bLu+AkjH4ELfItrYzKWvC4?=
 =?us-ascii?Q?XNFyZVmZg1YAe2F2cSax0BGYD83GfYSWt7gkwNjx2rXB43B2G0i4bjrCCUgf?=
 =?us-ascii?Q?3cS2l2Sd6GC1hFMmVfLF5JCJdSvcd9I5iQJa5WAdTaK6tXqpPUjElbuzKMv8?=
 =?us-ascii?Q?nYM0y3RmckZSDGc+6jOjQXVmzLYJgEfRx9wWlJ9nRyFIQH7JJtKGJKKT+hYW?=
 =?us-ascii?Q?zcgJ5x1V+UJrSfXxW1UCLW6fBOJvcYiqZRDMudEf4V+2mgBmxUhb0nQu9WOl?=
 =?us-ascii?Q?YtV5TyHQcDr+FOw4Ydih1nbX4PAztpkFUs2bas8J2jxpVinwF0ME6/bkS0qY?=
 =?us-ascii?Q?rURzsk4sGzqiLW3PmstgKHCEw/Ud9DirVcDm5bz+UIUgQ+F5QqO6ndJ8OI7/?=
 =?us-ascii?Q?TDfXRtFaHV79h38kTlLRQVc0sPrgBNhIOKJSKun/KupmJ4j1z5kpNWVw3z4s?=
 =?us-ascii?Q?iOg3OYMNjpnxZlNGiSfkSvKC94wSzOLprwd6rj5z4ZwxLvVPhyQcPJ5uAj7E?=
 =?us-ascii?Q?WDGsBYPu3csZVEglois3PA1wqOZBOkTilE2T5QkeabW+T5pqWoL3nG8lZF8d?=
 =?us-ascii?Q?8tDUje78f/VcJdZmDzRLmh5knD0qzt8/G7J6RSc2ikQAEUEYGue15o4nFFi6?=
 =?us-ascii?Q?sp859Ld6XkaXZ1PkDKaYRMsSpM22fFRihsP8OZZq0b3s429fLR7397/TrYD+?=
 =?us-ascii?Q?QKHOBoiO1uh/gEvaVn6rzDzGFaKYJy4znr7W81VJTLiNFKDakJxBNNr5ofQu?=
 =?us-ascii?Q?SzrLLNyQ1w8kSYNiM9qrvw0zL8+cHdx+mrDdspQ5Tqw3xBrLubQqSGStEl2k?=
 =?us-ascii?Q?vDu/ZzwTfnNpKf91BXBevwZPpAxxJ7HlBFCXDxut?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57335ec3-5180-4e79-33bf-08db80efd6f0
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 02:46:19.7059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JSewvr1gXjxuCqc4UvpReB0sbGOULGyrK1vu401NF04cuBWEqmEQMOvBMP6jdYfEwccfkSLzowiDiCbiML5uSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4273
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As commit ce753ad1549c ("platform: finally disallow IRQ0 in
platform_get_irq() and its ilk") says, there is no need to
check if the platform_get_irq return value is 0. Let's remove it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
 drivers/ata/pata_ixp4xx_cf.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 1b9f67e16864..246bb4f8f1f7 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -274,12 +274,9 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
 		return PTR_ERR(ixpp->ctl);
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq > 0)
-		irq_set_irq_type(irq, IRQ_TYPE_EDGE_RISING);
-	else if (irq < 0)
+	if (irq < 0)
 		return irq;
-	else
-		return -EINVAL;
+	irq_set_irq_type(irq, IRQ_TYPE_EDGE_RISING);
 
 	/* Just one port to set up */
 	ixp4xx_setup_port(ixpp->host->ports[0], ixpp, cmd->start, ctl->start);
-- 
2.39.0