Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp34762510rwd; Sun, 9 Jul 2023 20:05:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEax+N0LNyREyMNUuvyXcAkOOihbpbThj1ePeVIx+syAOgKKF8hgEap1kowKcIV1ClHob/o X-Received: by 2002:a05:6830:1481:b0:6b8:8a3b:86be with SMTP id s1-20020a056830148100b006b88a3b86bemr9691775otq.26.1688958343603; Sun, 09 Jul 2023 20:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688958343; cv=none; d=google.com; s=arc-20160816; b=pQZwfxYUP0StwkKQzs4GpQ0tYK7D+VhC+vQ2qSBUQC7HyYaU9vMlGjQ49R/Cy2mPyE a1vQIn9DGtxAft1de6FsyrVxPl3iLV1Qqs9TbtWLU8YxdseQBrtYWgKw/Jumsrr128aU Z6xE4193gSYRCO07hBNYSgG81tY9h62cZpTrTNxTMBfhmgykYe5l7df/IV9ehBBkeH72 ZWBQag3olZ6aI/0JNbxGpK3j0wir43ySXCqmx9p+GN6JqzI39aycuCdLa9yK4mxxr6k0 Mk3IYfjS5ED0KkvQCaSEcJkjj7uyLOtcjEW+4URJ1SLQlHhL+J9qapEUKH1uEG9jYUdy 4N8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=MnswSw0dMyxevZAi3I7pFIOLeeUNaS1z235vOuO8H4o=; fh=VY9KnarpIJdMWeodkXDRNKuqPGFncKhzxckczVeHYBo=; b=vqOelUeAhD3t3gPX8fTrHjZ2oCSCX/c8Ny6FOLqe1xP4KnJHm6kHLYKV6K5z0bJEOt F6gw0Xu2VvqVNMk4T8ceCFSZUS8fVOhUUAsw0WLpQ3NCdq/8pAtl7gPcux1P033iBRPB Q836DxAYluot/T/KNiA86JLJKsdh2vFc+a459ylr9iPBp8JafBgG6rK1v31xx5H/x+ou 1mdyBO4jnrIYPdfKydq1wEaqlYFotwtNlMNyyKAozjM/KpaChr+rgvEPNlvlcN/KLFc+ 8o256SjQtShnGxfrjjYROZpCnuj8MsSgBvfaIi0E3hyS7rqaSjSiyimn93Ot/+Ct7il/ VJ2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v69-20020a638948000000b00557390cc5acsi8529158pgd.145.2023.07.09.20.05.31; Sun, 09 Jul 2023 20:05:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbjGJCxe (ORCPT + 99 others); Sun, 9 Jul 2023 22:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbjGJCxd (ORCPT ); Sun, 9 Jul 2023 22:53:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A492FB; Sun, 9 Jul 2023 19:53:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD45A60DBC; Mon, 10 Jul 2023 02:53:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43C7DC433C7; Mon, 10 Jul 2023 02:53:29 +0000 (UTC) Date: Sun, 9 Jul 2023 22:53:27 -0400 From: Steven Rostedt To: Nadav Amit Cc: Ajay Kaher , "mhiramat@kernel.org" , "shuah@kernel.org" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Ching-lin Yu , Nadav Amit , "srivatsa@csail.mit.edu" , Alexey Makhalov , Vasavi Sirnapalli , Tapas Kundu , "er.ajay.kaher@gmail.com" , "linux-kselftest@vger.kernel.org" , Ching-lin Yu , Nadav Amit , "sri\"" Subject: Re: [PATCH v3 03/10] eventfs: adding eventfs dir add functions Message-ID: <20230709225327.777ea466@rorschach.local.home> In-Reply-To: <1C0CB205-B56F-44AE-B9B4-3668E06C840E@vmware.com> References: <1685610013-33478-1-git-send-email-akaher@vmware.com> <1685610013-33478-4-git-send-email-akaher@vmware.com> <20230701095417.3de5baab@rorschach.local.home> <20230703110857.2d051af5@rorschach.local.home> <84CA259A-8A99-471C-B44C-08D289972F43@vmware.com> <20230703155226.1ab27bc1@gandalf.local.home> <20230709215447.536defa6@rorschach.local.home> <1C0CB205-B56F-44AE-B9B4-3668E06C840E@vmware.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jul 2023 02:17:01 +0000 Nadav Amit wrote: > > On Jul 9, 2023, at 6:54 PM, Steven Rostedt wrote: > > > > + union { > > + struct rcu_head rcu; > > + struct llist_node llist; /* For freeing after RCU */ > > + }; > > The memory savings from using a union might not be worth the potential impact > of type confusion and bugs. It's also documentation. The two are related, as one is the hand off to the other. It's not a random union, and I'd like to leave it that way. -- Steve