Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] net: dsa: Removed unneeded of_node_put in felix_parse_ports_node
Date:   Mon, 10 Jul 2023 11:18:59 +0800
Message-Id: <20230710031859.36784-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5aRKIn0KF7UY5lJ4ugK06Mimt/DR6X1KPgsxcequZt6pyIj+X2iMv1NzSAH2?=
 =?us-ascii?Q?C3OwYn+nqZqVEBuTv35gmUaGVmYJlN9nFtzMaUGQFXr1E9ECA4de2mdSmWfy?=
 =?us-ascii?Q?EpWKGacAZQ72xRkU8pIjmiBGZXi5LA12cKMu7+F8VXZK1FrsPVxjI1Yf82xj?=
 =?us-ascii?Q?TSikEmD2xj8BoZaNIJ0O/wrJeiClQmLLj8+hEmVKUdA7Ec5UIZHQ6io6clk4?=
 =?us-ascii?Q?slatw52nsNvtx9ejiQXRQ8QPi29uju4i6TbYBAnGtq38q8puj6Jvvf0BiLVl?=
 =?us-ascii?Q?X2LuHv9wbllYtKdofC+Ld8x0tXGA7RqIXasGkttUoerASPLyOH5nQ/F0EWZd?=
 =?us-ascii?Q?T2eeR8Yb0OIyFRyhszPn48YFCkDCwedbKt+lhNUDZhSQF2vPeAJ3xk+PFCOn?=
 =?us-ascii?Q?gxXvser8jo4wH9k7lhmyxKoWmsgLUxuVX6CzLciVsilWlO2YYobLIC/KZKoV?=
 =?us-ascii?Q?+BRM7a6eUfc7O7RCEo0i5Re3S3weC8bdms3uHglRnIvHg946tir6UwDxyFnB?=
 =?us-ascii?Q?YCYTWZplc0HcHcB+2a27fP/2Pl3AS6y1Y2IiijnIcbQz2o0zSnX0fMLyjLgN?=
 =?us-ascii?Q?U35d70VOoqDBQS+TOIaGbDX1DuuU2pRVM2yZzjB5uZK8dBvKCmJIIt74lqR7?=
 =?us-ascii?Q?ZxE77O9plYvG7/LGQhpgqdYlVundSAeInZvw8qGwdnENa+bVPnNF0XlGkmJj?=
 =?us-ascii?Q?AKUfC0zpptZ4i+dk5ZH+I68b4uu5UcTa8mKhfpyLMhPPlxQXzrZ1vuVsu8qX?=
 =?us-ascii?Q?MpU+jH9+110PIKzlhH83GnRm4uxzGPlS2HC0Q2nOZOyY2pefH/u/vfvIvVBA?=
 =?us-ascii?Q?xoeKqwLy3Y0BRy8crbtxkFR2I8WwuVWgLTNvHRlUpkNFcnpkkLJANfATubFf?=
 =?us-ascii?Q?w1QnkQ99Fc1pu8sVcFUNelvlxN6yKq9vyrDJ1LHlxDa88AbBwASaqa6WF8aX?=
 =?us-ascii?Q?6vqn6w53x6Xs6gEJlEYOt+ny81rni6+Utx5xYa76N9lHeATAm6UKchmH9eRh?=
 =?us-ascii?Q?q+qenZ4t3ibK+FRvDw522VHwOBaB3luVgRrbqC4i3vY0aYxqa8QeQ+mYoBzz?=
 =?us-ascii?Q?9jxCS9GHcH4Cjk0tZ0ghqWwBWjPdmc1NK/b65qH9BhxKjBHlOUr2QKcNbBaH?=
 =?us-ascii?Q?cWLPYzIfrR07A3VsGz5vWjkThQRdPeRcsZFe291h7Xe2u7s0JsJJ2rshbFmE?=
 =?us-ascii?Q?LtS6I20LhFfAO9fpdZDl57M6PHnXXGGaRUsmUpb4j8LIwro04fCjDOrrsA3l?=
 =?us-ascii?Q?Cb9nIC2dcBZABU/HO9q4mvOVsPandeEyxj8IuRrQmnx7SlclqkQJWVaSz1vd?=
 =?us-ascii?Q?lSYcXqN84zsgvsDOiXqXbW9e5bJLwp8dpqhcaaqSk2nFztTF9m4xmXbG1nXX?=
 =?us-ascii?Q?aGSeBd/uOtdc8FF9Me/QN6AAJAEfxlLqWL1h5Zjx0mVut6AGjTBACgXXyoJ+?=
 =?us-ascii?Q?lzs2dCX2GyneLTFclOrwfRqZxskBN5oyiXa66LF0nUw8d7j0ZkH6snSz/M8U?=
 =?us-ascii?Q?T9SXaXTvKEvS5cWD8IAPvuJLhcqKXZApC2VGiZXv9lhADDXcKA7SxnsIjk/6?=
 =?us-ascii?Q?U5O38bFjvAYBSRUAtg1MoVFTCQY5wzVVjpY2n1d2?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba25be94-1963-42e4-8c6b-08db80f46dfa
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 03:19:11.5612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T/GgNjrA17pT3X01kf2xcyq42BGIswKyUHnYomYmBBsrCNlroZZoao0QVot2HjUTDkVUPeY88iKPSHhpWShA2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6606
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove unnecessary of_node_put from the continue path to prevent
child node from being released twice, which could avoid resource
leak or other unexpected issues.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/net/dsa/ocelot/felix.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index dee43caee19e..8da46d284e35 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -1286,7 +1286,6 @@ static int felix_parse_ports_node(struct felix *felix,
 		if (err < 0) {
 			dev_info(dev, "Unsupported PHY mode %s on port %d\n",
 				 phy_modes(phy_mode), port);
-			of_node_put(child);
 
 			/* Leave port_phy_modes[port] = 0, which is also
 			 * PHY_INTERFACE_MODE_NA. This will perform a
-- 
2.39.0