Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1408364e-6b73-7b50-e61c-470f3548a3a7@infradead.org>
Date:   Sun, 9 Jul 2023 20:33:28 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: =?UTF-8?Q?Re=3a_=5bPATCH=5d_kernel=3a_params=3a_Remove_unnecessary_?=
 =?UTF-8?B?4oCYMOKAmSB2YWx1ZXMgZnJvbSBlcnI=?=
Content-Language: en-US
To:     Li zeming <zeming@nfschina.com>, mcgrof@kernel.org,
        linux@rasmusvillemoes.dk, mbenes@suse.cz, rafael@kernel.org,
        linux@weissschuh.net, gregkh@linuxfoundation.org,
        christophe.jaillet@wanadoo.fr
Cc:     linux-kernel@vger.kernel.org
References: <20230711194331.4361-1-zeming@nfschina.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230711194331.4361-1-zeming@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/11/23 12:43, Li zeming wrote:
> err is assigned first, so it does not need to initialize the assignment.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  kernel/params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/params.c b/kernel/params.c
> index 6a7548979aa9..f8837a5f2c3e 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
>  
>  int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
>  {
> -	int err = 0;
> +	int err;
>  	bool new_value;
>  	bool orig_value = *(bool *)kp->arg;
>  	struct kernel_param dummy_kp = *kp;

-- 
~Randy