Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230628083735.19946-2-zev@bewilderbeest.net>
In-Reply-To: <20230628083735.19946-2-zev@bewilderbeest.net>
From:   Joel Stanley <joel@jms.id.au>
Date:   Mon, 10 Jul 2023 04:22:18 +0000
Message-ID: <CACPK8Xei-295TNmkjg53qXyQHwSUf3s+Sj87_o7ZEw1G0+NPpw@mail.gmail.com>
Subject: Re: [PATCH] soc: aspeed: uart-routing: Use __sysfs_match_string
To:     Zev Weiss <zev@bewilderbeest.net>
Cc:     Andrew Jeffery <andrew@aj.id.au>, linux-aspeed@lists.ozlabs.org,
        Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
        Oskar Senft <osk@google.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 28 Jun 2023 at 08:43, Zev Weiss <zev@bewilderbeest.net> wrote:
>
> The existing use of match_string() caused it to reject 'echo foo' due
> to the implicitly appended newline, which was somewhat ergonomically
> awkward and inconsistent with typical sysfs behavior.  Using the
> __sysfs_* variant instead provides more convenient and consistent
> linefeed-agnostic behavior.

Nice.

Fixes: c6807970c3bc ("soc: aspeed: Add UART routing support")
Reviewed-by: Joel Stanley <joel@jms.id.au>

>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
>  drivers/soc/aspeed/aspeed-uart-routing.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/aspeed/aspeed-uart-routing.c b/drivers/soc/aspeed/aspeed-uart-routing.c
> index ef8b24fd1851..59123e1f27ac 100644
> --- a/drivers/soc/aspeed/aspeed-uart-routing.c
> +++ b/drivers/soc/aspeed/aspeed-uart-routing.c
> @@ -524,7 +524,7 @@ static ssize_t aspeed_uart_routing_store(struct device *dev,
>         struct aspeed_uart_routing_selector *sel = to_routing_selector(attr);
>         int val;
>
> -       val = match_string(sel->options, -1, buf);
> +       val = __sysfs_match_string(sel->options, -1, buf);
>         if (val < 0) {
>                 dev_err(dev, "invalid value \"%s\"\n", buf);
>                 return -EINVAL;
> --
> 2.40.0.5.gf6e3b97ba6d2.dirty
>