Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chunhai Guo <guochunhai@vivo.com>
To:     xiang@kernel.org, chao@kernel.org
Cc:     huyue2@coolpad.com, jefflexu@linux.alibaba.com,
        linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Chunhai Guo <guochunhai@vivo.com>
Subject: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF
Date:   Mon, 10 Jul 2023 12:25:31 +0800
Message-Id: <20230710042531.28761-1-guochunhai@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DlGh5m+wm4exOdPjIa11oK4Jo+rx2W1/DF4tSwAbAflcPpDSmGz5deiUL1ek?=
 =?us-ascii?Q?Q9xCoKNu6haQtCHkvGWh+olxSO1DaabTmRiPG96o2ExVGWBnQ3BOVj/08SPJ?=
 =?us-ascii?Q?Fq+KV6SbnAgLP1gi3phrqxS2T8v7HyGRM7ZCBDxMoC06z0Z259Hsi2Mznrc5?=
 =?us-ascii?Q?Xee5TB07j5Uw4SYRBS2XSNbiCmAHM6qdMU1s7XrKuW24W4bMFyOQhQc6xkyj?=
 =?us-ascii?Q?Xg3IPeBwc+IjGG5ZHb/YTND7/X8dDcfh4kN5YS99ZtH1rQ0Sdgh3fCbA3gvd?=
 =?us-ascii?Q?OJuNFJqw2vOY4sg6VB5mxMmmbU4R8fPs4BFzjyf3E1EOgvYLZR60uZKmuC5d?=
 =?us-ascii?Q?MeYBZwVvl6YdFb67GvaO+1iTADgqeO4eXXWUPwBaKaAwQjIrml2cRw1TmFPo?=
 =?us-ascii?Q?At5JuQH8V704iqKPTTvN3UVJRer2NGd7xDMfpZLHK2MBvMhnnTucpTMyyo2a?=
 =?us-ascii?Q?buVyXYv7NFdfKVFSw9GR9b243K3SIGLGEUU/vh/6Gxuk+d3KrX7JJCAlGvqs?=
 =?us-ascii?Q?1GdBnhcQ3Z1nj+37kIRpcPoIg/yxEm3k2cp1fPzTG58g+HltTQfhgRmXSyOl?=
 =?us-ascii?Q?HD5VfwzMqRc3aJIyjoWZkHJVn+oz9Pbl+G/YD5brNhNTCKxjOiIm1z2993p+?=
 =?us-ascii?Q?4v6VAJUMBYikV2bz7k3eA2rr+G4lRpd9en/noLnUXaCjYuaTioMvjaiDgeCJ?=
 =?us-ascii?Q?/OACE1KUUakc5dftgT4S/Sk2iTrQron/WVyMRXHd/N9K9FfLmw5D4QqqvhXq?=
 =?us-ascii?Q?M1rnqIgi7m/+0XaIoW2DiLyNACNFJjcUYYFYoGv10Vse+JgssgZ6tIJTCREP?=
 =?us-ascii?Q?QYIyMe8b/7vU0WQzOM1G+EDwmKhUUBey+eQAWZaY0Z4Nyho2dCocAq6CKboR?=
 =?us-ascii?Q?BlWfA0lP8q6+dub/qgFeJYqoNAq4cgFAi5HIQKuq4Llmfqyu4CycbCW830wi?=
 =?us-ascii?Q?aktFyf1PjgG7BRCkLUvKqanCLxc6hLXCQ2NjyTSgKneaYZpwCCdQ1mUZkxQT?=
 =?us-ascii?Q?ngVl3UiMUv3T79nwC9xmxz1/FlQhC/ZqO8wTwL1i0o+Ygct6B72nFFCVSKId?=
 =?us-ascii?Q?9lacMdgZvDqBTne1FsmXxOxj/El0S1/WSqtzWjVYbsxyiUBUagvLPd/V8JGB?=
 =?us-ascii?Q?N+remP51qUtV/zGa6HCiMJiDwjyVa5gVfW1uKKiL6Wy8PIZHwUNfVXxY7RM4?=
 =?us-ascii?Q?phOcGiR8VM7KwrVsUJBsC+CNeA4+fno2ppWIn8/KAg0zq6YUXVR9AsZZH6Tm?=
 =?us-ascii?Q?j1ZlAH7xk1KJ/sCm0vIZRErd7y7/H9FBtSnXDkC0tFURLU2JjcJ4b/bNLi/I?=
 =?us-ascii?Q?pyDLNCrj0mVX/t/kme1JJN5qb3li78F35U6mwEc192YGAZ7K15anSup6c3VB?=
 =?us-ascii?Q?EoZ9Rpx20CCkI7tLpuueunX+hUcblrik8cDiZPeqzxY6GeNhWqQ21IzWRzsR?=
 =?us-ascii?Q?EjuGrDJe4VZaat5Kw++05IWVkdWFQzSvoE/gHfD6MKVKWkn+xnJfD7fnjQCJ?=
 =?us-ascii?Q?71KWO7P1huJoSZaFmz8VXHSQyaJyJVpynzmnPDB8y0Q6mdnUzwzNcvOARBJA?=
 =?us-ascii?Q?eVKuxn+m1IyO95WV+552gBk99saJjA/F+XjydgdM?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 724ee590-16f6-44cf-9848-08db80fdbdf4
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3338.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 04:25:50.6277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H0VWPcOmRPTpL5O1IRR2Q7MQSutGtvr4Nn3n05Reg5h16mRVycnXjMEMKaLLcN4xpWzUdo5xc9kLmLr52rQCWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4109
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

z_erofs_pcluster_readmore() may take a long time to loop when the page
offset is large enough, which is unnecessary should be prevented.
For example, when the following case is encountered, it will loop 4691368
times, taking about 27 seconds.
    - offset = 19217289215
    - inode_size = 1442672

Signed-off-by: Chunhai Guo <guochunhai@vivo.com>
---
 fs/erofs/zdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 5f1890e309c6..d9a0763f4595 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -1841,7 +1841,7 @@ static void z_erofs_pcluster_readmore(struct z_erofs_decompress_frontend *f,
 	}
 
 	cur = map->m_la + map->m_llen - 1;
-	while (cur >= end) {
+	while ((cur >= end) && (cur < i_size_read(inode))) {
 		pgoff_t index = cur >> PAGE_SHIFT;
 		struct page *page;
 
-- 
2.25.1