Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230710042924.2518198-1-chenhuacai@loongson.cn> <51181fd7-fc1f-2222-9b8a-8ce44fe85ea5@xen0n.name>
In-Reply-To: <51181fd7-fc1f-2222-9b8a-8ce44fe85ea5@xen0n.name>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Mon, 10 Jul 2023 13:01:21 +0800
Message-ID: <CAAhV-H5MW+X17H9vj4jCp5eLcyFdQm4O1jVrSVOfRc64uE=08g@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: Fix module relocation error with binutils 2.41
To:     WANG Xuerui <kernel@xen0n.name>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>, loongarch@lists.linux.dev,
        linux-arch@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
        Guo Ren <guoren@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 10, 2023 at 12:45=E2=80=AFPM WANG Xuerui <kernel@xen0n.name> wr=
ote:
>
> On 2023/7/10 12:29, Huacai Chen wrote:
> > Binutils 2.41 enable linker relaxation by default, but kernel module
>
> "enables" / "will enable"
>
> > loader doesn't support that, so disable it. Otherwise we get such an
> > error when loading modules: "Unknown relocation type 102".
>
> IMO it could be better to also justify the disabling (instead of adding
> proper support): linker relaxation is relatively large complexity that
> may or may not bring a similar gain, and we don't really want to include
> this linker pass in the kernel.
OK, thanks.

Huacai
>
> >
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > ---
> >   arch/loongarch/Makefile | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > index 09ba338a64de..7466d3b15db8 100644
> > --- a/arch/loongarch/Makefile
> > +++ b/arch/loongarch/Makefile
> > @@ -68,6 +68,8 @@ LDFLAGS_vmlinux                     +=3D -static -n -=
nostdlib
> >   ifdef CONFIG_AS_HAS_EXPLICIT_RELOCS
> >   cflags-y                    +=3D $(call cc-option,-mexplicit-relocs)
> >   KBUILD_CFLAGS_KERNEL                +=3D $(call cc-option,-mdirect-ex=
tern-access)
> > +KBUILD_AFLAGS_MODULE         +=3D $(call cc-option,-mno-relax) $(call =
cc-option,-Wa$(comma)-mno-relax)
> > +KBUILD_CFLAGS_MODULE         +=3D $(call cc-option,-mno-relax) $(call =
cc-option,-Wa$(comma)-mno-relax)
> >   else
> >   cflags-y                    +=3D $(call cc-option,-mno-explicit-reloc=
s)
> >   KBUILD_AFLAGS_KERNEL                +=3D -Wa,-mla-global-with-pcrel
>
> The code changes are good. With the commit message improved:
>
> Reviewed-by: WANG Xuerui <git@xen0n.name>
>
> --
> WANG "xen0n" Xuerui
>
> Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
>
>