Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b5bde1a-08e2-15ad-ebe1-08a16de00468@kernel.org>
Date:   Mon, 10 Jul 2023 08:02:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
To:     Alina Yu <alina_yu@richtek.com>
Cc:     broonie@kernel.org, linux-kernel@vger.kernel.org,
        cy_huang@richtek.com
References: <cover.1688569987.git.alina_yu@richtek.com>
 <341af3996c430549243365bb8204d33a15a482be.1688569987.git.alina_yu@richtek.com>
 <d3308334-aa91-f265-2469-8a6fbc727798@kernel.org>
 <20230706103040.GA32138@linuxcarl2.richtek.com>
 <20230710030858.GA16636@linuxcarl2.richtek.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20230710030858.GA16636@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/07/2023 05:08, Alina Yu wrote:
>> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
>> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
>>
>> Is it more understandable if I modify that to enum ? And description will be like this
>>
>> richtek,mtp-sel:
>>   enum: [0, 1]
>>     description: |
>>       vout register selection besed on this value.
>>       0 - Using DVS0 register setting to adjust vout
>>       1 - Using DVS1 register setting to adjust vout
>>
> 
> May I ask one more question ?
> If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> It will be like this,
> 
> richtek,mtp-sel-high:
>   type: boolean
>   description:
>   vout register selection besed on this value.
>   0 - Using DVS0 register setting to adjust vout
>   1 - Using DVS1 register setting to adjust vout

You don't have 0 or 1 values in such case. The property can be bool, but
description is not good.

Best regards,
Krzysztof