Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5006633-889b-9371-f5d9-8d5d6bb9ed4e@loongson.cn>
Date:   Mon, 10 Jul 2023 14:34:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] drm/hyperv: Fix a compilation issue because of not
 including screen_info.h
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        Deepak Rawat <drawat.floss@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20230709100514.703759-1-suijingfeng@loongson.cn>
 <BYAPR21MB16887E35CE80D293DE2243E0D730A@BYAPR21MB1688.namprd21.prod.outlook.com>
Content-Language: en-US
From:   suijingfeng <suijingfeng@loongson.cn>
In-Reply-To: <BYAPR21MB16887E35CE80D293DE2243E0D730A@BYAPR21MB1688.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

OK, thanks a lot,

done!

On 2023/7/10 13:20, Michael Kelley (LINUX) wrote:
> From: Sui Jingfeng <suijingfeng@loongson.cn> Sent: Sunday, July 9, 2023 3:05 AM
>>     drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
>> in this function)
>>      1033 |                 base = screen_info.lfb_base;
>>           |                        ^~~~~~~~~~~
>>     drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
>> only once for each function it appears in
>> --
>>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
>> (first use in this function)
>>        75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>>           |                                                      ^~~~~~~~~~~
>>     drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
>> reported only once for each function it appears in
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
>> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
>> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>>   drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> index a7d2c92d6c6a..8026118c6e03 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> @@ -7,6 +7,7 @@
>>   #include <linux/hyperv.h>
>>   #include <linux/module.h>
>>   #include <linux/pci.h>
>> +#include <linux/screen_info.h>
>>
>>   #include <drm/drm_aperture.h>
>>   #include <drm/drm_atomic_helper.h>
>> --
>> 2.25.1
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>